Skip to content

modified docs/tutorials/cicd Github Action's install path to follow download_cli script #5240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
taniandjerry merged 1 commit into from
Oct 21, 2025
Merged

modified docs/tutorials/cicd Github Action's install path to follow download_cli script #5240

taniandjerry merged 1 commit into from
Oct 21, 2025

Conversation

@vietbui1999ru
Copy link
Contributor

@vietbui1999ru vietbui1999ru commented Oct 17, 2025

Summary

Fixed documentation inconsistency in CI/CD tutorial where INSTALL_PATH was referenced, but the actual install script (download_cli.sh) uses GOOSE_BIN_DIR.

Type of Change

  • Feature
  • Bug fix
  • Refactor / Code quality
  • Performance improvement
  • Documentation
  • Tests
  • Security fix
  • Build / Release
  • Other (specify below)

Testing

Verified the fix by:

  1. Created a Dockerfile following the CI/CD tutorial
  • Test Dockerfile:
FROM ubuntu:22.04

RUN apt-get update && apt-get install -y curl bzip2 libxcb1

# FAILS if replace GOOSE_BIN_DIR with INSTALL_PATH
RUN mkdir -p /app/.local/bin \
    && curl -fsSL https://github.com/block/goose/releases/download/stable/download_cli.sh \
    | CONFIGURE=false GOOSE_BIN_DIR=/app/.local/bin bash

RUN /app/.local/bin/goose --version
  1. Tested with GOOSE_BIN_DIR (should work as expected)
  2. Tested with INSTALL_PATH (should fail as expected)
  3. Also confirmed that both env CONFIGURE=false and CONFIGURE=false syntax work identically.

Related Issues

Relates to #3946
Discussion: LINK

Screenshots/Demos (for UX changes)

Before:

After:

Email:

@vietbui1999ru vietbui1999ru requested a review from a team as a code owner October 17, 2025 19:33
@Abhijay007
Copy link
Collaborator

Abhijay007 commented Oct 20, 2025 •
edited
Loading

Hi @vietbui1999ru thanks for making this PR, can you please check the DCO, here are the steps to do that : https://github.com/block/goose/pull/5240/checks?check_run_id=53045506354

@vietbui1999ru
modified docs/tutorials/cicd Github Action's install path to follow d…
a7f8d4a 
…ownload_cli.sh

Replaced INSTALL_PATH with GOOSE_BIN_DIR for the GH Actions.

Signed-off-by: vietbui99 <[email protected]>
@vietbui1999ru vietbui1999ru force-pushed the docs/cicd-tutorial-edit branch from 404a22c to a7f8d4a Compare October 20, 2025 16:39
@vietbui1999ru
Copy link
Contributor Author

vietbui1999ru commented Oct 20, 2025

Hi @Abhijay007, thank you for providing me with the steps to fix this. I just updated the PR with the signoff! Let me know if everything works!

@taniandjerry taniandjerry added hacktoberfest Issues awarding points for Hacktoberfest 2025! medium Weight label for Hacktoberfest 2025 issues labels Oct 21, 2025
@taniandjerry
Copy link
Contributor

taniandjerry commented Oct 21, 2025

Thank you so much for working on this! Surfaced this with the team to review <3

@taniandjerry taniandjerry merged commit 326c1b0 into block:main Oct 21, 2025
11 checks passed
@taniandjerry taniandjerry mentioned this pull request Oct 21, 2025
Closed
@taniandjerry taniandjerry linked an issue Oct 21, 2025 that may be closed by this pull request
Error in ci/cd documentation #3946
Closed
wpfleger96 added a commit that referenced this pull request Oct 22, 2025
@wpfleger96
Merge branch 'main' into wpfleger/session-name
f1774ed 
* main: (33 commits)
  Add Web Accessibility Auditor recipe to cookbook (#5318)
  To do mcp tutorial (#5317)
  workflows: add a manual trigger option to pr-smoke-test (#5302)
  documenting `goose recipe list` command (#5278)
  add a system prompt snapshot test (#5305)
  fix: handle non exist subrecipe path (#5287)
  Next camp (#5237)
  more lowercasing of TabItem labels (#5307)
  modified docs/tutorials/cicd Github Action's install path to follow download_cli script (#5240)
  Fix artifact download to work across workflow runs (#5304)
  Added extension search (#5283)
  docs: lowercase 'goose' in TabItem labels for consistency (#5297)
  feat(prompts): add format to save code snippet (#5007)
  fix: use Windows-compatible default path for CLI installation (#5221)
  feat: add Test Coverage Optimizer recipe (#5118) (#5272)
  Upgrade node to fix canary (#5301)
  Remove reliance on localstorage for pendingScheduleDeepLink when scheduling a recipe (#5290)
  Add historical tracking with trend indicators using artifacts (#5295)
  roll back vite and electron package upgrades breaking canary win and linux (#5292)
  Revert "Revert "Rewrite extension management tools"" (#5273)
  ...
BlairAllan pushed a commit to BlairAllan/goose that referenced this pull request Oct 25, 2025
@vietbui1999ru @BlairAllan
modified docs/tutorials/cicd Github Action's install path to follow d…
f08fbad 
…ownload_cli script (block#5240)

Signed-off-by: vietbui99 <[email protected]>
Signed-off-by: Blair Allan <[email protected]>
BlairAllan pushed a commit to BlairAllan/goose that referenced this pull request Nov 29, 2025
@vietbui1999ru @BlairAllan
modified docs/tutorials/cicd Github Action's install path to follow d…
76c4a31 
…ownload_cli script (block#5240)

Signed-off-by: vietbui99 <[email protected]>
Signed-off-by: Blair Allan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blackgirlbytes blackgirlbytes blackgirlbytes approved these changes

Assignees

@vietbui1999ru vietbui1999ru

Labels

hacktoberfest Issues awarding points for Hacktoberfest 2025! hacktoberfest-accepted medium Weight label for Hacktoberfest 2025 issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error in ci/cd documentation

4 participants

@vietbui1999ru @Abhijay007 @taniandjerry @blackgirlbytes