chore: move list recipes and archive recipe to goose server #4422

lifeizhou-ap · 2025-08-29T10:51:49Z

Pull Request Description

Move list recipes and archive recipe logic from UI to goose server

What

Created RecipeManifest that maps to local and global recipe files
Create /recipes/list route to render the recipe files in the global recipe directory and current working directory
Create /recipes/archive route to archive recipe

Next PR

move load recipe to server side

* main: no streaming for ollama and re-arrange cards (#4335) Enable load nested hint files (#4002)

…howing goosehints, etc on RecipesView

* main: (40 commits) new recipe to lint-check my code (#4416) removing a leftover syntax error (#4415) Iand/updating recipe validation workflow (#4413) Iand/updating recipe validation workflow (#4410) Fix (Ollama provider): Unsupported operation: streaming not implemented (#4303) change databricks default to claude sonnet 4 (#4405) Iand/updating recipe validation workflow (#4406) Add metrics for recipe metadata in scheduler, UI, and CLI (#4399) Iand/updating recipe validation workflow (#4403) making small updates to recipe validation workflow (#4401) Automate OpenRouter API Key Distribution for External Recipe Contributors (#3198) Enhance `convert_path_with_tilde_expansion` to handle Windows (#4390) make sure all cookbook recipes have a title and version, but no id (#4395) Nest TODO State in session data (#4361) Fast model falls back to regular (#4375) Update windows instructions (#4333) feat: linux computer control for android (termux) (#3890) feat: Added scroll state support for chat-session-list navigation (#4360) docs: typo fix (#4376) blog: goose janitor (#4131) ...

lifeizhou-ap · 2025-08-29T11:43:54Z

crates/goose-server/src/state.rs

    agent: Option<AgentRef>,
    pub secret_key: String,
    pub scheduler: Arc<Mutex<Option<Arc<dyn SchedulerTrait>>>>,
+    pub recipe_file_hash_map: Arc<Mutex<HashMap<String, PathBuf>>>,


This in memory map maintains the mapping of recipe id (hashed based on recipe path) and recipe path. recipe id is the key of map

lifeizhou-ap · 2025-08-29T11:46:34Z

ui/desktop/src/components/RecipesView.tsx

                </div>
              )}
-
-              {selectedRecipe.recipe.goosehints && (


Hi @zanesq I am not sure whether this is really used in RecipeView UI. It seems not. same as profile and mcps.

Good catch I was wondering the same thing, might have been legacy functionality that we can drop now.

lifeizhou-ap · 2025-08-29T11:47:10Z

ui/desktop/src/recipe/recipeStorage.ts

- * @param recipeName The name of the recipe to restore
- * @param isGlobal Whether the recipe is in global or local storage
- */
-export async function restoreRecipe(recipeName: string, isGlobal: boolean): Promise<void> {


This function is not used at all

lifeizhou-ap · 2025-08-29T11:47:25Z

ui/desktop/src/recipe/recipeStorage.ts

- * @param recipeName The name of the recipe to permanently delete
- * @param isGlobal Whether the recipe is in global or local storage
- */
-export async function permanentlyDeleteRecipe(


This function is not used at all

lifeizhou-ap · 2025-08-29T11:47:32Z

ui/desktop/src/recipe/recipeStorage.ts

- * @param recipeName The name of the recipe to delete/archive
- * @param isGlobal Whether the recipe is in global or local storage
- */
-export async function deleteRecipe(recipeName: string, isGlobal: boolean): Promise<void> {


This function is not used at all

It might have been accidentally dropped with the ui refactor should we add it back to the ui instead? Seems like we need a way to delete recipes still?

My bad we do have delete already nvm on this comment go ahead and remove it 👍

Hi @zanesq,

Your previous comment is right!

Before this PR, delete is actually "archive". Talked to @DOsinga and he suggested we delete recipe directly instead of archive because there is no way to restore.

Now the delete is "delete the recipe file" and it used the server side to delete

lifeizhou-ap · 2025-08-29T11:48:13Z

ui/desktop/src/recipe/recipeStorage.ts

- * @param recipeName The name of the recipe to archive
- * @param isGlobal Whether the recipe is in global or local storage
- */
-export async function archiveRecipe(recipeName: string, isGlobal: boolean): Promise<void> {


this function is no longer required as we perform archiveRecipe via api call

lifeizhou-ap · 2025-08-29T11:51:28Z

ui/desktop/src/components/RecipesView.tsx


-  // Render a recipe item with error handling
-  const RecipeItem = ({ savedRecipe }: { savedRecipe: SavedRecipe }) => {
-    try {


removed try/catch here as the server side will ignore the yaml files that do not conform to recipe format.

DOsinga · 2025-08-29T13:09:17Z

ui/desktop/src/recipe/recipeStorage.ts

-
-/**
- * Delete a recipe (archives it by default for backward compatibility).
- *


This is just all LLM generated non-sense - there was never backward compatibility here

DOsinga · 2025-08-29T13:11:48Z

crates/goose/Cargo.toml


 arrow = "52.2"
 oauth2 = "5.0.0"
+xxhash-rust = { version = "0.8.12", features = ["xxh3"] }


I don't think we need yet another hashing library, ahash should do the trick

DOsinga · 2025-08-29T13:12:51Z

crates/goose/src/recipe/recipe_manifest.rs

+        Ok(())
+    }
+
+    pub fn archive(file_path: &Path) -> Result<()> {


let's drop archive. we have no way to restore archived recipes it seems and we call it delete. let's delete them.

DOsinga · 2025-08-29T13:16:37Z

crates/goose/src/recipe/recipe_manifest.rs

+use utoipa::ToSchema;
+
+#[derive(Serialize, Deserialize, Debug, Clone, ToSchema)]
+pub struct RecipeManifest {


this RecipeManifest in the client was a mistake. they should never be saved to disk - @jsibbison-square already build some compatibility in so we can read this client side version of recipes.

In the client we just list the recipes and don't show is_global anywhere. name is a duplicated. last_modified should not be stored either, that's just when the file got updated.

in short, we shouldn't need this at all. just load recipes from disk and if the client needs it, ad the modification date (if you need an intermediate class for that, fine, but just in routes)

I moved the list_recipe, manifest related object sas view objects to goose-server.

list_recipes is now calling goose core to get the recipe objects

If cli needs list recipes in the future, we can move list_recipes (only get the recipe objects part, no the manifest) to goose core

DOsinga · 2025-08-29T13:19:56Z

crates/goose/src/recipe/list_recipes.rs

+}
+
+fn get_all_recipes_manifests() -> Result<Vec<RecipeManifestWithPath>> {
+    let current_dir = std::env::current_dir()?;


this should not use the current_dir, but use the current dir of the session

where working directory is changed on UI, it started goosed with the working directory.

So current_dir here is the session working directory.

yeah, I know that is currently the case, but once we move to having multiple agents per goosed, this will no longer be the case

DOsinga · 2025-08-29T13:20:25Z

crates/goose/src/recipe/list_recipes.rs

+
+    let global_recipe_path = choose_app_strategy(APP_STRATEGY.clone())
+        .map(|strategy| strategy.in_config_dir("recipes"))
+        .unwrap_or_else(|_| PathBuf::from("~/.config/goose/recipes"));


this should not hardcode .config - app_strategy has a handler to get to I think the data_dir?

DOsinga · 2025-08-29T13:21:25Z

crates/goose/src/recipe/list_recipes.rs

+    format!("{:016x}", hash)
+}
+
+fn load_recipes_from_path(path: &PathBuf) -> Result<Vec<RecipeManifestWithPath>> {


we already have read_recipe_in_dir, use that. this would be a good opportunity to unify the recipes the user sees in CLI and the desktop

DOsinga · 2025-08-29T13:23:30Z

ui/desktop/src/recipe/recipeStorage.ts

@@ -1,3 +1,4 @@
+import { listRecipes, RecipeManifestResponse } from '../api';
 import { Recipe } from './index';
 import * as yaml from 'yaml';


I think this entire file should now be deleted

It will. There are still some codes for save and load. When we move these recipe operations to server side, then we don't need it

DOsinga · 2025-08-29T13:24:29Z

ui/desktop/src/components/RecipesView.tsx

+          <p className="text-text-muted text-sm mb-2 line-clamp-2">{manifest.recipe.description}</p>
+          <div className="flex items-center text-xs text-text-muted">
+            <Calendar className="w-3 h-3 mr-1" />
+            {recipeLastModified(manifest.lastModified)}


do this locally, not worth two calls

i renamed recipeLastModified to convertToLocaleDateString. basically it convert the utc time string to local date

This reverts commit 030303d.

DOsinga · 2025-08-29T22:05:57Z

crates/goose-server/src/recipe/recipe_manifest_metadata.rs

@@ -0,0 +1,48 @@
+use anyhow::Result;


this file should not exist

DOsinga · 2025-08-29T22:20:54Z

crates/goose-server/src/recipe/list_recipes.rs

@@ -0,0 +1,85 @@
+use std::fs;


we shouldn't need this, just read the recipes just like we always have

* main: chore: move list recipes and archive recipe to goose server (#4422) deleting a recipe and testing workflow (#4451) adding a new recipe (#4449) docs: autovisualiser extension (#4380) trying to restore functionality for api-key sending after merging a recipe (#4446) restoring a deleted recipe (#4445) testing recipe removal (#4443) updating our 3 workflows to only operate if the PR is adding/editing a recipe (#4441) [cookbook recipe] Update Wording (#4438) feat: show enabled extensions at top of extensions page (#4423) test recipe (#4436) Extensions loading indicator on desktop launch (#4412) removing trailing slash (#4433) [recipe cookbook] test recipe (#4431) [recipe cookbook] switching to SHA (#4429) [recipe cookbook] Update url build (#4427) [Recipe Cookbook] test recipe flow (#4426) [Recipe cookbook] Addressing GitHub api format issue (#4424) feat: integrate tool call icons with status indicators and daisy chaining (#4279)

Signed-off-by: Carine Bruyndoncx <bruyndoncx@gmail.com>

Signed-off-by: Matt Donovan <mattddonovan@protonmail.com>

lifeizhou-ap added 12 commits August 26, 2025 23:05

added list recipe route

61e8aef

Merge branch 'main' into lifei/more-recipe-tracking

0e1f9ef

* main: no streaming for ollama and re-arrange cards (#4335) Enable load nested hint files (#4002)

list_recipe wip

ed77066

added list recipe endpoints

c703516

generate open api

4433b92

fixed the attribute name

429d3ab

update ui to use api to list recipes. todo: load recipe, and remove s…

8043c08

…howing goosehints, etc on RecipesView

return recipe id

f9510c4

removed unused functions in ui

f872413

move archive recipe to goose server

6b7cbe1

show locale date string

17d5a51

lifeizhou-ap changed the title ~~Lifei/move list archive recipes server~~ chore: move list recipes and archive recipe to goose server Aug 29, 2025

lifeizhou-ap commented Aug 29, 2025

View reviewed changes

lifeizhou-ap marked this pull request as ready for review August 29, 2025 11:54

lifeizhou-ap requested review from DOsinga and zanesq August 29, 2025 11:56

DOsinga reviewed Aug 29, 2025

View reviewed changes

lifeizhou-ap added 6 commits August 30, 2025 01:43

removed archive

030303d

Revert "removed archive"

73a3311

This reverts commit 030303d.

changed archive to delete

0c4fb89

ui change

1753564

list all recipes without include archived query

987a587

used built-in hash

85836c3

move recipe manifest to server as view object

310e35f

DOsinga approved these changes Aug 29, 2025

View reviewed changes

removed recipe mod in goose server and moved it into router mod

3ad6ae1

lifeizhou-ap merged commit ce69b39 into main Sep 1, 2025
11 checks passed

lifeizhou-ap deleted the lifei/move-list-archive-recipes-server branch September 1, 2025 01:28

cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Sep 2, 2025

chore: move list recipes and archive recipe to goose server (block#4422)

9de218d

Signed-off-by: Carine Bruyndoncx <bruyndoncx@gmail.com>

This was referenced Sep 9, 2025

chore(release): release version 1.8.0 #4572

Closed

release/1.8.0 #4577

Merged

thebristolsound pushed a commit to thebristolsound/goose that referenced this pull request Sep 11, 2025

chore: move list recipes and archive recipe to goose server (block#4422)

702c2b2

Signed-off-by: Matt Donovan <mattddonovan@protonmail.com>

chore: move list recipes and archive recipe to goose server #4422

chore: move list recipes and archive recipe to goose server #4422

Uh oh!

Conversation

lifeizhou-ap commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description

What

Next PR

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lifeizhou-ap commented Aug 29, 2025 •

edited

Loading