no streaming for ollama and re-arrange cards #4335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
is Ollama only there because it's detected on your system? Hoping it's not shown by default, since most people wont have the hardware to support a local model that performs well with agents |
Contributor
|
Thanks! I think the team prefers that Ollama is not shown at all, and it's within the Other Providers section. How does it determined detected? is it checking that someone has ollama installed on their device? |
zanesq
approved these changes
Aug 25, 2025
Collaborator
Author
|
@blackgirlbytes yeah it looks on device for it being installed |
Collaborator
Author
|
@angiejones at the moment it detects but I don't think it shows/hides as it can offer to link to download (idea was to detect machine capacity, but perhaps that is too ambitious), if it is trapping people (who have very small ram) can make it hidden easily? |
shellz-n-stuff
pushed a commit
to shellz-n-stuff/goose
that referenced
this pull request
Aug 27, 2025
Signed-off-by: Alex Rosenzweig <arosenzweig@squareup.com>
This was referenced Aug 27, 2025
dorien-koelemeijer
pushed a commit
to dorien-koelemeijer/goose
that referenced
this pull request
Sep 2, 2025
Signed-off-by: Dorien Koelemeijer <dkoelemeijer@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #4329
fixes: #4334
ollama now will advertise streaming, the goose provider incorrectly said it would support it, which would break it as of latest goose and ollama, this fixes that.
as requested, ollama below the fold (with a note that is for advanced users):
