Add metrics for recipe metadata in scheduler, UI, and CLI #4399
Conversation
Kvadratni
changed the title
Kvadratni
force-pushed
the
mnovich/improve-recipe-telemetry-UI
branch
from
531d09a to
d0a1125
Compare
|
Looks good, would you please test it to make sure it works. Thank you! If it works, then I'll approve it! |
| session_working_dir: String, | ||
| scheduled_job_id: Option<String>, | ||
| recipe_name: Option<String>, | ||
| recipe_version: Option<String>, |
There was a problem hiding this comment.
do we need to pass this in? do we not have this information in the session meta data, that seems like a better place. same actually for the schedule_job_id I think.
There was a problem hiding this comment.
we do not have it currently no
There was a problem hiding this comment.
so we want to move the source of truth for conversations to the server, not add stuff to the reply handler. I also don't think this does record what you want it to record. I think you want to measure how often recipes are used, not how many messages users send to recipes. not that it is doing that, if you resume a conversation, it won't remember it was started by a recipe.
I would suggest to wait with this until the https://github.com/block/goose/pull/4216/files lands and then add the logging to agent/start which should know whether it was done through a recipe (and if not, that would be the right place to add).
| }) | ||
| .unwrap_or_else(|| "unknown".to_string()), | ||
| Err(_) => "unknown".to_string(), | ||
| }; |
There was a problem hiding this comment.
you filtering through the list of jobs twice here, once to find the name, once to find the version? make that into one thing
There was a problem hiding this comment.
yeah that's on me. let me fix this quick
| session_id: chat.id, | ||
| session_working_dir: window.appConfig.get('GOOSE_WORKING_DIR'), | ||
| ...(chat.recipeConfig?.title | ||
| ? { |
There was a problem hiding this comment.
title is required, so you want to check on recipeConfig here, not title
There was a problem hiding this comment.
that's what this is doing
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining
There was a problem hiding this comment.
It's checking chat.recipeConfig?.title not hat.recipeConfig
* main: new recipe to lint-check my code (#4416) removing a leftover syntax error (#4415) Iand/updating recipe validation workflow (#4413) Iand/updating recipe validation workflow (#4410) Fix (Ollama provider): Unsupported operation: streaming not implemented (#4303) change databricks default to claude sonnet 4 (#4405) Iand/updating recipe validation workflow (#4406) Add metrics for recipe metadata in scheduler, UI, and CLI (#4399) Iand/updating recipe validation workflow (#4403) making small updates to recipe validation workflow (#4401) Automate OpenRouter API Key Distribution for External Recipe Contributors (#3198) Enhance `convert_path_with_tilde_expansion` to handle Windows (#4390) make sure all cookbook recipes have a title and version, but no id (#4395) Nest TODO State in session data (#4361) Fast model falls back to regular (#4375) Update windows instructions (#4333)
* main: (40 commits) new recipe to lint-check my code (#4416) removing a leftover syntax error (#4415) Iand/updating recipe validation workflow (#4413) Iand/updating recipe validation workflow (#4410) Fix (Ollama provider): Unsupported operation: streaming not implemented (#4303) change databricks default to claude sonnet 4 (#4405) Iand/updating recipe validation workflow (#4406) Add metrics for recipe metadata in scheduler, UI, and CLI (#4399) Iand/updating recipe validation workflow (#4403) making small updates to recipe validation workflow (#4401) Automate OpenRouter API Key Distribution for External Recipe Contributors (#3198) Enhance `convert_path_with_tilde_expansion` to handle Windows (#4390) make sure all cookbook recipes have a title and version, but no id (#4395) Nest TODO State in session data (#4361) Fast model falls back to regular (#4375) Update windows instructions (#4333) feat: linux computer control for android (termux) (#3890) feat: Added scroll state support for chat-session-list navigation (#4360) docs: typo fix (#4376) blog: goose janitor (#4131) ...
…tensions-on-resume * upstream/main: (60 commits) [cookbook recipe] Update Wording (block#4438) feat: show enabled extensions at top of extensions page (block#4423) test recipe (block#4436) Extensions loading indicator on desktop launch (block#4412) removing trailing slash (block#4433) [recipe cookbook] test recipe (block#4431) [recipe cookbook] switching to SHA (block#4429) [recipe cookbook] Update url build (block#4427) [Recipe Cookbook] test recipe flow (block#4426) [Recipe cookbook] Addressing GitHub api format issue (block#4424) feat: integrate tool call icons with status indicators and daisy chaining (block#4279) new recipe to lint-check my code (block#4416) removing a leftover syntax error (block#4415) Iand/updating recipe validation workflow (block#4413) Iand/updating recipe validation workflow (block#4410) Fix (Ollama provider): Unsupported operation: streaming not implemented (block#4303) change databricks default to claude sonnet 4 (block#4405) Iand/updating recipe validation workflow (block#4406) Add metrics for recipe metadata in scheduler, UI, and CLI (block#4399) Iand/updating recipe validation workflow (block#4403) ...
Pull Request Description