Fix (Ollama provider): Unsupported operation: streaming not implemented #4303

Jovonni · 2025-08-23T03:01:19Z

I'm not entirely sure if this is the right way to fix this issue, but here's what I ran into when using the goose desktop app installed from the site (v1.6.0):

implements streaming capability for ollama chat completions by:

adding stream method to ollamaprovider
using openai-compatible streaming format with stream=true
handling streamed responses line by line with proper error handling
including usage metrics in streamed responses
maintaining compatibility with existing chat/auto modes

note

this also occurs for all of my local ollama models
not sure if this also closes Feature Request: Implement Streaming for Ollama Models #3527

got-root · 2025-08-25T14:19:48Z

Looks like this may fix this one: #4308

DOsinga

thanks!

DOsinga · 2025-08-25T21:16:15Z

crates/goose/src/providers/ollama.rs

+        let config = crate::config::Config::global();
+        let goose_mode = config.get_param("GOOSE_MODE").unwrap_or("auto".to_string());
+        let filtered_tools = if goose_mode == "chat" { &[] } else { tools };
+


this seems unexpected. by the time we get here, we should have already have filtered the tools. do we really need this?

yeah I don't think so, not sure where that came from

michaelneale · 2025-08-27T01:09:06Z

thanks @Jovonni - that works once I patched it up: #4364 - if you want, you can pull that change in to this branch and I can approve/merge, or we can shift over to there, has your commits.

can you also sign the DCO: https://github.com/block/goose/pull/4303/checks?check_run_id=48963447829 so we can get past that

you can get cherry-pick b70930d86fd8b0c141fbf4bfcbd08c4e6de5b73a and and git cherry-pick ba63988c6a3a1844e359dd58119271d8dbe4a78a (or something like that) and push here - and should be good to go once you sign the DCO.

Nice first contrib, this feels a lot nicer with ollama now it can stream.

Jovonni · 2025-08-27T18:53:57Z

just signed dco @michaelneale

e9e8a46

sorry for the delay, have been heads down on my side.

Jovonni · 2025-08-27T19:08:33Z

@michaelneale I also just cherry picked your work (from #4364) as you mentioned above. Glad to hear this was useful!! 🚀 🫡

Signed-off-by: jovonni <[email protected]>

DOsinga · 2025-08-27T19:34:13Z

crates/goose/src/providers/ollama.rs

+                yield (message, usage);
+            }
+        }))
+    }


left this comment in the other PR too - this looks very similar to the openai implementation. can we extract this and reuse?

@DOsinga yeah good idea - I am not familiar with the pattern on how to reuse parts of another provider, can ollama just be openai provider with some customisation? what is another examplar to follow (this is an older provider so may have some jank/special cases)

michaelneale · 2025-08-27T23:46:01Z

@Jovonni if you get a chance to consider the comment above - if there is a way we can re-use the openai streaming would be nice, I may get a chance later today or tomorrow to look, but if not, we can probably merge this soon

* main: new recipe to lint-check my code (#4416) removing a leftover syntax error (#4415) Iand/updating recipe validation workflow (#4413) Iand/updating recipe validation workflow (#4410) Fix (Ollama provider): Unsupported operation: streaming not implemented (#4303) change databricks default to claude sonnet 4 (#4405) Iand/updating recipe validation workflow (#4406) Add metrics for recipe metadata in scheduler, UI, and CLI (#4399) Iand/updating recipe validation workflow (#4403) making small updates to recipe validation workflow (#4401) Automate OpenRouter API Key Distribution for External Recipe Contributors (#3198) Enhance `convert_path_with_tilde_expansion` to handle Windows (#4390) make sure all cookbook recipes have a title and version, but no id (#4395) Nest TODO State in session data (#4361) Fast model falls back to regular (#4375) Update windows instructions (#4333)

* main: (40 commits) new recipe to lint-check my code (#4416) removing a leftover syntax error (#4415) Iand/updating recipe validation workflow (#4413) Iand/updating recipe validation workflow (#4410) Fix (Ollama provider): Unsupported operation: streaming not implemented (#4303) change databricks default to claude sonnet 4 (#4405) Iand/updating recipe validation workflow (#4406) Add metrics for recipe metadata in scheduler, UI, and CLI (#4399) Iand/updating recipe validation workflow (#4403) making small updates to recipe validation workflow (#4401) Automate OpenRouter API Key Distribution for External Recipe Contributors (#3198) Enhance `convert_path_with_tilde_expansion` to handle Windows (#4390) make sure all cookbook recipes have a title and version, but no id (#4395) Nest TODO State in session data (#4361) Fast model falls back to regular (#4375) Update windows instructions (#4333) feat: linux computer control for android (termux) (#3890) feat: Added scroll state support for chat-session-list navigation (#4360) docs: typo fix (#4376) blog: goose janitor (#4131) ...

…tensions-on-resume * upstream/main: (60 commits) [cookbook recipe] Update Wording (block#4438) feat: show enabled extensions at top of extensions page (block#4423) test recipe (block#4436) Extensions loading indicator on desktop launch (block#4412) removing trailing slash (block#4433) [recipe cookbook] test recipe (block#4431) [recipe cookbook] switching to SHA (block#4429) [recipe cookbook] Update url build (block#4427) [Recipe Cookbook] test recipe flow (block#4426) [Recipe cookbook] Addressing GitHub api format issue (block#4424) feat: integrate tool call icons with status indicators and daisy chaining (block#4279) new recipe to lint-check my code (block#4416) removing a leftover syntax error (block#4415) Iand/updating recipe validation workflow (block#4413) Iand/updating recipe validation workflow (block#4410) Fix (Ollama provider): Unsupported operation: streaming not implemented (block#4303) change databricks default to claude sonnet 4 (block#4405) Iand/updating recipe validation workflow (block#4406) Add metrics for recipe metadata in scheduler, UI, and CLI (block#4399) Iand/updating recipe validation workflow (block#4403) ...

…ed (#4303) Signed-off-by: jovonni <[email protected]> Co-authored-by: Michael Neale <[email protected]>

DOsinga approved these changes Aug 25, 2025

View reviewed changes

michaelneale self-assigned this Aug 26, 2025

This was referenced Aug 27, 2025

Unsupported operation: streaming not implemented when listing files #4308

Closed

fix: ollama streaming patch #4364

Closed

Jovonni force-pushed the main branch from f3be61c to e9e8a46 Compare August 27, 2025 18:28

Jovonni and others added 2 commits August 27, 2025 15:13

stream for ollama

10dfe06

Signed-off-by: jovonni <[email protected]>

streaming works, removed tool check unneeded

31ec341

Signed-off-by: jovonni <[email protected]>

Jovonni force-pushed the main branch from 882185c to 31ec341 Compare August 27, 2025 19:13

DOsinga reviewed Aug 27, 2025

View reviewed changes

michaelneale merged commit 3fda5c2 into block:main Aug 28, 2025
10 checks passed

thisispete pushed a commit that referenced this pull request Aug 30, 2025

Fix (Ollama provider): Unsupported operation: streaming not implement…

cd4e3dc

…ed (#4303) Signed-off-by: jovonni <[email protected]> Co-authored-by: Michael Neale <[email protected]>

This was referenced Sep 9, 2025

chore(release): release version 1.8.0 #4572

Closed

release/1.8.0 #4577

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix (Ollama provider): Unsupported operation: streaming not implemented #4303

Fix (Ollama provider): Unsupported operation: streaming not implemented #4303

Uh oh!

Jovonni commented Aug 23, 2025

Uh oh!

got-root commented Aug 25, 2025

Uh oh!

DOsinga left a comment

Uh oh!

DOsinga Aug 25, 2025

Uh oh!

michaelneale Aug 27, 2025

Uh oh!

michaelneale commented Aug 27, 2025 •

edited

Loading

Uh oh!

Jovonni commented Aug 27, 2025 •

edited

Loading

Uh oh!

Jovonni commented Aug 27, 2025 •

edited

Loading

Uh oh!

DOsinga Aug 27, 2025

Uh oh!

michaelneale Aug 27, 2025

Uh oh!

michaelneale commented Aug 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fix (Ollama provider): Unsupported operation: streaming not implemented #4303

Fix (Ollama provider): Unsupported operation: streaming not implemented #4303

Uh oh!

Conversation

Jovonni commented Aug 23, 2025

note

Uh oh!

got-root commented Aug 25, 2025

Uh oh!

DOsinga left a comment

Choose a reason for hiding this comment

Uh oh!

DOsinga Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

michaelneale Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

michaelneale commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jovonni commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jovonni commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DOsinga Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

michaelneale Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

michaelneale commented Aug 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

michaelneale commented Aug 27, 2025 •

edited

Loading

Jovonni commented Aug 27, 2025 •

edited

Loading

Jovonni commented Aug 27, 2025 •

edited

Loading