feat: integrate tool call icons with status indicators and daisy chaining #4279

spencrmartin · 2025-08-22T14:50:06Z

🔗 Tool Call Chaining
Consecutive tool calls are now visually grouped into chains
Reduces visual clutter by combining related tool executions
Smart chain detection that works during streaming
Preserves individual tool call functionality for non-chained calls

🎨 Tool Call Icons & Status Indicators
13 new custom icons for different tool types (Terminal, FileEdit, Globe, Camera, etc.)
Dynamic icon mapping based on tool names and functions
Status indicators showing tool execution state
Enhanced visual hierarchy for better UX

🧠 Preserved Core Functionality
Chain of Thought (CoT) with `` blocks maintained
GooseResponseForm integration preserved (currently disabled but available)
Metadata handling and parameter usage restored
Tool confirmations and error handling intact

🔧 Technical Changes
New Components
ToolCallChain.tsx - Handles rendering of chained tool calls
ToolCallStatusIndicator.tsx - Visual status indicators for tools
13 new icon components in icons/toolcalls/

Enhanced Components
GooseMessage.tsx - Integrated chaining logic while preserving CoT
ToolCallWithResponse.tsx - Enhanced with status indicators

New Utilities
toolCallChaining.ts - Chain detection and management logic
toolIconMapping.tsx - Dynamic icon assignment system

Original prework PR #4248

- Add 17 custom tool call icon components (Terminal, FileEdit, Globe, etc.) - Create comprehensive tool-to-icon mapping system - Implement status indicator overlay system (success/error/loading/pending) - Replace old green dot status with integrated icon+status display - Remove redundant LoaderCircle and Dot components from tool calls - Maintain all existing functionality (tooltips, expansion, etc.) Visual improvements: - Each tool call now shows specific icon (11x11px matching design system) - Status indicators: green (success), red (error), yellow pulsing (loading), gray (pending) - Cleaner layout with single status indicator per tool - Better visual hierarchy and user experience Files added: - ui/desktop/src/components/icons/toolcalls/ (17 icon components) - ui/desktop/src/utils/toolIconMapping.tsx (mapping logic) - ui/desktop/src/components/ToolCallStatusIndicator.tsx (status system) Files modified: - ui/desktop/src/components/ToolCallWithResponse.tsx (integration)

Co-authored-by: dianed-square <73617011+dianed-square@users.noreply.github.com> Co-authored-by: Zane <75694352+zanesq@users.noreply.github.com>

spencrmartin · 2025-08-22T18:40:39Z

Followed up with @chaitanyarahalkar around Chain-Of-Thought code block

it is only served if you are using local models with something like Ollama. Those models emit their cot in the tags which gets wrapped in this UI

for context. Moving to ready for review

michaelneale · 2025-08-26T01:34:24Z

this looks much nicer - not reviewed the code but love the functionality

michaelneale · 2025-08-26T02:01:16Z

ui/desktop/src/components/GooseMessage.tsx

    const cotRaw = match[1].trim();
-    const visible = text.replace(match[0], '').trim();
-    return { visibleText: visible, cotText: cotRaw.length > 0 ? cotRaw : null };
+    const visibleText = text.replace(regex, '').trim();


is this change part of this, a little lost as to what the functional change is

No function change

Why is it needed though?

Vibes - will revert

Ahhh I see regex was used within the chain logic and kept consistent @zanesq

michaelneale · 2025-08-26T02:02:37Z

ui/desktop/src/components/GooseMessage.tsx


-  // Extract image paths from the visible part of the message (exclude CoT)
-  const imagePaths = extractImagePaths(textWithoutCot);
+  // Extract image paths from the message content


is this doing same as before but unrelated/stylistic changes?

I guess needed as below uses visibleText as what was textWithoutCot?

bit of a simplified variable as opposed to continuing the train of textWithoutX textWithoutY rabbit hole.

michaelneale · 2025-08-27T00:05:33Z

nice - LGTM - didn't get a chance to try it yet though

zanesq

Tested and LGTM just some cleanup needed before merging

zanesq · 2025-08-28T18:18:51Z

ui/desktop/src/components/GooseMessage.tsx.backup

Can remove this backup file

zanesq · 2025-08-28T18:19:25Z

ui/desktop/src/components/GooseMessage.tsx

    const cotRaw = match[1].trim();
-    const visible = text.replace(match[0], '').trim();
-    return { visibleText: visible, cotText: cotRaw.length > 0 ? cotRaw : null };
+    const visibleText = text.replace(regex, '').trim();


Why is it needed though?

zanesq · 2025-08-28T18:24:47Z

ui/desktop/src/components/GooseMessage.tsx.backup

+  // Track which tool confirmations we've already handled to prevent infinite loops
+  const handledToolConfirmations = useRef<Set<string>>(new Set());
+
+  // Extract text content from the message


Can remove info comments like this if the code is self explanatory

Cleaned up unnecessary comments that just repeat what the code clearly shows: - Removed obvious helper function comments - Removed JSDoc blocks that just restate function names - Removed inline comments explaining self-evident logic - Kept only comments that explain non-obvious business logic Code is now cleaner and follows the principle of minimal, meaningful comments.

zanesq

LGTM! Only bit of ui feedback is there is less space under the text and the tool call in the agent response. Not sure if that was intentional or not but looks a bit tight to me.

Before:

After:

taylorkmho · 2025-08-28T23:10:39Z

Great feedback @zanesq! Jumping in to support @spencrmartin here, made some adjustments so tool calls and their supplemental copy are spaced more consistently.

michaelneale

nice

…tensions-on-resume * upstream/main: (60 commits) [cookbook recipe] Update Wording (block#4438) feat: show enabled extensions at top of extensions page (block#4423) test recipe (block#4436) Extensions loading indicator on desktop launch (block#4412) removing trailing slash (block#4433) [recipe cookbook] test recipe (block#4431) [recipe cookbook] switching to SHA (block#4429) [recipe cookbook] Update url build (block#4427) [Recipe Cookbook] test recipe flow (block#4426) [Recipe cookbook] Addressing GitHub api format issue (block#4424) feat: integrate tool call icons with status indicators and daisy chaining (block#4279) new recipe to lint-check my code (block#4416) removing a leftover syntax error (block#4415) Iand/updating recipe validation workflow (block#4413) Iand/updating recipe validation workflow (block#4410) Fix (Ollama provider): Unsupported operation: streaming not implemented (block#4303) change databricks default to claude sonnet 4 (block#4405) Iand/updating recipe validation workflow (block#4406) Add metrics for recipe metadata in scheduler, UI, and CLI (block#4399) Iand/updating recipe validation workflow (block#4403) ...

…ning (#4279) Co-authored-by: dianed-square <73617011+dianed-square@users.noreply.github.com> Co-authored-by: Zane <75694352+zanesq@users.noreply.github.com> Co-authored-by: Taylor Ho <taylorkmho@gmail.com>

* main: chore: move list recipes and archive recipe to goose server (#4422) deleting a recipe and testing workflow (#4451) adding a new recipe (#4449) docs: autovisualiser extension (#4380) trying to restore functionality for api-key sending after merging a recipe (#4446) restoring a deleted recipe (#4445) testing recipe removal (#4443) updating our 3 workflows to only operate if the PR is adding/editing a recipe (#4441) [cookbook recipe] Update Wording (#4438) feat: show enabled extensions at top of extensions page (#4423) test recipe (#4436) Extensions loading indicator on desktop launch (#4412) removing trailing slash (#4433) [recipe cookbook] test recipe (#4431) [recipe cookbook] switching to SHA (#4429) [recipe cookbook] Update url build (#4427) [Recipe Cookbook] test recipe flow (#4426) [Recipe cookbook] Addressing GitHub api format issue (#4424) feat: integrate tool call icons with status indicators and daisy chaining (#4279)

spencrmartin and others added 4 commits August 22, 2025 10:43

feat: implement tool call chaining for consecutive tool calls (#4253)

0b47c91

Fix/lint cleanup GitHub updater (#4259)

928705f

Co-authored-by: dianed-square <73617011+dianed-square@users.noreply.github.com> Co-authored-by: Zane <75694352+zanesq@users.noreply.github.com>

Fix/lint errors clean from main (#4262)

f78e139

Co-authored-by: dianed-square <73617011+dianed-square@users.noreply.github.com> Co-authored-by: Zane <75694352+zanesq@users.noreply.github.com>

spencrmartin changed the base branch from spence/toolcalls to main August 22, 2025 14:51

spencrmartin changed the title ~~Pr 4248 rebased~~ feat: integrate tool call icons with status indicators and daisy chaining Aug 22, 2025

fix: remove ml-2 margin from tool call labels for better alignment

50391b8

spencrmartin marked this pull request as ready for review August 22, 2025 18:40

spencrmartin requested review from aharvard, alexhancock and zanesq August 22, 2025 18:40

michaelneale assigned michaelneale, spencrmartin and zanesq Aug 26, 2025

michaelneale reviewed Aug 26, 2025

View reviewed changes

zanesq approved these changes Aug 28, 2025

View reviewed changes

spencrmartin added 2 commits August 28, 2025 14:32

chore: remove backup file GooseMessage.tsx.backup

f64f008

spencrmartin force-pushed the pr-4248-rebased branch from b2a9aac to f64f008 Compare August 28, 2025 18:37

fix: cleanup

99390ea

spencrmartin requested a review from zanesq August 28, 2025 20:42

zanesq approved these changes Aug 28, 2025

View reviewed changes

fix: better spacing between tool calls

1e52f7e

michaelneale approved these changes Aug 28, 2025

View reviewed changes

spencrmartin merged commit 69c29a0 into main Aug 29, 2025
11 checks passed

spencrmartin deleted the pr-4248-rebased branch August 29, 2025 12:39

This was referenced Sep 9, 2025

chore(release): release version 1.8.0 #4572

Closed

release/1.8.0 #4577

Merged

feat: integrate tool call icons with status indicators and daisy chaining #4279

feat: integrate tool call icons with status indicators and daisy chaining #4279

Uh oh!

Conversation

spencrmartin commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spencrmartin commented Aug 22, 2025

Uh oh!

michaelneale commented Aug 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michaelneale commented Aug 27, 2025

Uh oh!

zanesq left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zanesq left a comment

Choose a reason for hiding this comment

Uh oh!

taylorkmho commented Aug 28, 2025

Uh oh!

michaelneale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

spencrmartin commented Aug 22, 2025 •

edited

Loading