feat: integrate tool call icons with status indicators #4248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 17 custom tool call icon components (Terminal, FileEdit, Globe, etc.) - Create comprehensive tool-to-icon mapping system - Implement status indicator overlay system (success/error/loading/pending) - Replace old green dot status with integrated icon+status display - Remove redundant LoaderCircle and Dot components from tool calls - Maintain all existing functionality (tooltips, expansion, etc.) Visual improvements: - Each tool call now shows specific icon (11x11px matching design system) - Status indicators: green (success), red (error), yellow pulsing (loading), gray (pending) - Cleaner layout with single status indicator per tool - Better visual hierarchy and user experience Files added: - ui/desktop/src/components/icons/toolcalls/ (17 icon components) - ui/desktop/src/utils/toolIconMapping.tsx (mapping logic) - ui/desktop/src/components/ToolCallStatusIndicator.tsx (status system) Files modified: - ui/desktop/src/components/ToolCallWithResponse.tsx (integration)
Collaborator
Author
|
Co-authored-by: dianed-square <73617011+dianed-square@users.noreply.github.com> Co-authored-by: Zane <75694352+zanesq@users.noreply.github.com>
Contributor
|
Co-authored-by: dianed-square <73617011+dianed-square@users.noreply.github.com> Co-authored-by: Zane <75694352+zanesq@users.noreply.github.com>
Collaborator
Author
|
Sorry for the ping @block/goose-devrel I think it got caught in a rebase delint I was doing |
Collaborator
|
@spencrmartin, I noticed some diffs for files under |
aharvard
reviewed
Aug 22, 2025
| const toolLabel = ( | ||
| <span className={cn('ml-2', extensionTooltip && 'cursor-pointer hover:opacity-80')}> | ||
| {getToolLabelContent()} | ||
| <span className={cn('ml-2 flex items-center gap-2', extensionTooltip && 'cursor-pointer hover:opacity-80')}> |
Collaborator
There was a problem hiding this comment.
nit: I think we can remove ml-2. I edited the last one in the screenshot in dev tools and it feels a bit better. whatcha think?
Collaborator
Author
There was a problem hiding this comment.
Yea that's fire, was thinking there a pass on spacing that should be done ty!
aharvard
force-pushed
the
spence/toolcalls
branch
from
ffdac01 to
76e1323
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual improvements:
Files added:
Files modified: