Skip to content

Conversation

@zanesq
Copy link
Collaborator

@zanesq zanesq commented Aug 12, 2025

Loading recipes from a deeplink when the app is closed was launching an extra window with home behind it. Changed to hook in earlier in the process to load the recipe directly. Also fixed where new chat from home wasn't clearing the loaded recipe.

fixes #3972

zanesq added 5 commits August 12, 2025 09:23
…ndow

* 'main' of github.com:block/goose:
  sanitize message content on deserialization (#3966)
  Move summarize button inside of context view (#4015)
  blog: post on lead/worker model (#3994)
  Actually send cancellation to MCP servers (#3865)
  fix: enable 'goose://' handler for debian systems (#3952)
  fit: default ollama port (#4001)
  Remove cognitive complexity clippy lint (#4010)
  feat: add @-mention file reference expansion to .goosehints (#3873)
  feat(cli): Add --name/-n to session remove and --id/-i alias for session export (#3941)
  Docs: provider and model run options (#4013)
  To-Do Tools (#3902)
  ci: correctly match doc only changes (#4009)
  Remove PR trigger for Linux build workflow (#4008)
  docs: update release docs with an additional step needed + adjust list formatting (#4005)
}
});

// Clean up temporary files
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed some local debug code that wasn't needed

@zanesq zanesq requested review from DOsinga and alexhancock August 13, 2025 17:33
title: 'New Chat',
messages: [], // Clear messages for fresh start
messageHistoryIndex: 0,
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be/use a constant seeing that we have 'New Chat' already 4 times

const messageFromHub = location.state?.initialMessage;
const resetChat = location.state?.resetChat;

// If we have a resetChat flag from Hub, clear any existing recipe config
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow the logic here. in what scenario is this going to be triggered? there was a recipe, the user went to the hub ...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment to help but yeah basically if they decide to start a new chat from home/hub after loading a recipe for whatever reason it should clear the current recipe and start a new chat. Basically anytime a chat is started from hub/home it should be a fresh chat regardless of the scenario.

Copy link
Collaborator

@DOsinga DOsinga Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's probably the best we can do at this point, yeah. I guess right now if you restart a session that was started by a recipe, this doesn't actually have the recipe stuff in it anymore? /cc @lifeizhou-ap

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah its always worked like that where the recipe details are lost when resuming a session, we'd need to add the recipe to the session metadata if we wanted to do that.

@zanesq zanesq merged commit 68dd328 into main Aug 13, 2025
11 checks passed
@zanesq zanesq deleted the zane/recipe-new-window branch August 13, 2025 21:52
jsibbison-square added a commit that referenced this pull request Aug 14, 2025
…ol-visibility

* origin/main: (43 commits)
  docs: Blog - How I Used Goose to Rebuild My Website (#4076)
  docs: custom context file names (#4077)
  Blog: How Pulse MCP Used Goose to Automate Their Newsletter (#4075)
  Load recipe deeplinks in single window when app is closed (#4048)
  docs: make accurate the comments with links to unsigned builds of the app (#4070)
  cleanup memory in chat (#4073)
  CLI: improve model selection ux (#4071)
  speed up loading extensions by loading in parallel (#4054)
  fix(build): feed electronforge the icon explicitly for linux (#4045)
  Docs: Troubleshooting tip - Nodejs path on windows (#4065)
  fix: flag out uncompilable bit in windows (#4068)
  ci: fix docs-only filter to properly skip tests for documentation changes (#4066)
  fix: ctrl-C interruption in the CLI (#4057)
  docs: mcp-ui support (#4049)
  fix: delete dialog layout (#4037)
  ci: fix markdown file pattern to skip builds for all .md files (#4061)
  docs: add window title (#4059)
  blog: cleaning up some posts (#4050)
  fix: this should be a debug message not a warn (#4024)
  Better provider logging (#4052)
  ...
michaelneale added a commit that referenced this pull request Aug 15, 2025
* main: (21 commits)
  docs: fix experimental warning (#4102)
  fix not being able to add spaces to activity message area (#4055)
  remove and cleanup unused code (#4074)
  docs: Add missing references to smart_approve mode. (#4094)
  quick typo fix pulse blog (#4095)
  fix: update dictation settings handling and improve user feedback (#4093)
  chore: add info tooltip to share session button (#4038)
  Reroute routes (#4088)
  fix(cli): fix compiling issue on windows system by adding a missing param (#4019)
  fix: hide console window for stdio extensions on Windows (#4085)
  Do not fetch pricing information if GOOSE_CLI_SHOW_COST is false (#3901)
  blog: fixing links (#4089)
  Token counting reliability + summarization integration. (#3721)
  Skip ci builds for docs (#4087)
  blog: agent coordination patterns (#4086)
  docs: Blog - How I Used Goose to Rebuild My Website (#4076)
  docs: custom context file names (#4077)
  Blog: How Pulse MCP Used Goose to Automate Their Newsletter (#4075)
  Load recipe deeplinks in single window when app is closed (#4048)
  docs: make accurate the comments with links to unsigned builds of the app (#4070)
  ...
ayax79 pushed a commit to ayax79/goose that referenced this pull request Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: blank window being created when app is closed and launched from a recipe deeplink

3 participants