-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Reroute routes #4088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Reroute routes #4088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move hardcoded prompts from router_tool_selector.rs and permission_judge.rs
into reusable .md template files using the MiniJinja template system.
Changes:
- Add router_tool_selector.md template with {{tools}} and {{query}} variables
- Add permission_judge.md template for read-only operation detection
- Update router_tool_selector.rs to use render_global_file()
- Update permission_judge.rs to use render_global_file() with fallback
- Add proper error handling for template rendering failures
- All existing tests continue to pass
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
alexhancock
approved these changes
Aug 14, 2025
katzdave
added a commit
that referenced
this pull request
Aug 14, 2025
…-messaging * 'main' of github.com:block/goose: chore: add info tooltip to share session button (#4038) Reroute routes (#4088) fix(cli): fix compiling issue on windows system by adding a missing param (#4019) fix: hide console window for stdio extensions on Windows (#4085) Do not fetch pricing information if GOOSE_CLI_SHOW_COST is false (#3901) blog: fixing links (#4089)
michaelneale
added a commit
that referenced
this pull request
Aug 15, 2025
* main: (21 commits) docs: fix experimental warning (#4102) fix not being able to add spaces to activity message area (#4055) remove and cleanup unused code (#4074) docs: Add missing references to smart_approve mode. (#4094) quick typo fix pulse blog (#4095) fix: update dictation settings handling and improve user feedback (#4093) chore: add info tooltip to share session button (#4038) Reroute routes (#4088) fix(cli): fix compiling issue on windows system by adding a missing param (#4019) fix: hide console window for stdio extensions on Windows (#4085) Do not fetch pricing information if GOOSE_CLI_SHOW_COST is false (#3901) blog: fixing links (#4089) Token counting reliability + summarization integration. (#3721) Skip ci builds for docs (#4087) blog: agent coordination patterns (#4086) docs: Blog - How I Used Goose to Rebuild My Website (#4076) docs: custom context file names (#4077) Blog: How Pulse MCP Used Goose to Automate Their Newsletter (#4075) Load recipe deeplinks in single window when app is closed (#4048) docs: make accurate the comments with links to unsigned builds of the app (#4070) ...
jsibbison-square
added a commit
that referenced
this pull request
Aug 18, 2025
…ol-visibility * origin/main: (26 commits) feat: adds cursor-agent as a cli provider (#4101) chore: remove vector search tool selection strategy (#3933) docs: add streamable_http install links (#4130) feat: iterating on summarize oneshot prompt (#4113) feat(mcp): Persist OAuth credentials to keyring (#4007) Sanitize Tags Unicode Block at prompt level (#4047) Fixing typos (#4114) chore(release): release version 1.4.0 (#4069) E2E tests working again (#4103) chore: Delete ARCHITECTURE.md (#4108) Add Youtube short to Kiwi MCP tutorial (#4107) docs: fix experimental warning (#4102) fix not being able to add spaces to activity message area (#4055) remove and cleanup unused code (#4074) docs: Add missing references to smart_approve mode. (#4094) quick typo fix pulse blog (#4095) fix: update dictation settings handling and improve user feedback (#4093) chore: add info tooltip to share session button (#4038) Reroute routes (#4088) fix(cli): fix compiling issue on windows system by adding a missing param (#4019) ...
This was referenced Aug 18, 2025
ayax79
pushed a commit
to ayax79/goose
that referenced
this pull request
Aug 21, 2025
Co-authored-by: Douwe Osinga <douwe@squareup.com> Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Jack Wright <jack.wright@nike.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing some agent routes to be real routes, dropping some other code