Remove cognitive complexity clippy lint #4010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
thoughts @lifeizhou-ap @DOsinga ? |
lifeizhou-ap
approved these changes
Aug 11, 2025
Collaborator
Hi @jamadeo thanks for the doc reference! That makes sense. |
zanesq
added a commit
that referenced
this pull request
Aug 12, 2025
…ndow * 'main' of github.com:block/goose: sanitize message content on deserialization (#3966) Move summarize button inside of context view (#4015) blog: post on lead/worker model (#3994) Actually send cancellation to MCP servers (#3865) fix: enable 'goose://' handler for debian systems (#3952) fit: default ollama port (#4001) Remove cognitive complexity clippy lint (#4010) feat: add @-mention file reference expansion to .goosehints (#3873) feat(cli): Add --name/-n to session remove and --id/-i alias for session export (#3941) Docs: provider and model run options (#4013) To-Do Tools (#3902) ci: correctly match doc only changes (#4009) Remove PR trigger for Linux build workflow (#4008) docs: update release docs with an additional step needed + adjust list formatting (#4005)
katzdave
added a commit
that referenced
this pull request
Aug 12, 2025
* 'main' of github.com:block/goose: Move summarize button inside of context view (#4015) blog: post on lead/worker model (#3994) Actually send cancellation to MCP servers (#3865) fix: enable 'goose://' handler for debian systems (#3952) fit: default ollama port (#4001) Remove cognitive complexity clippy lint (#4010) feat: add @-mention file reference expansion to .goosehints (#3873) feat(cli): Add --name/-n to session remove and --id/-i alias for session export (#3941) Docs: provider and model run options (#4013) To-Do Tools (#3902) ci: correctly match doc only changes (#4009) Remove PR trigger for Linux build workflow (#4008)
ayax79
pushed a commit
to ayax79/goose
that referenced
this pull request
Aug 21, 2025
Signed-off-by: Jack Wright <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from https://rust-lang.github.io/rust-clippy/master/index.html#cognitive_complexity
Open to opinions on this but the fact that clippy themselves feel it's a bad measure doesn't seem great. I came to this because a violation for it here:
goose/crates/goose/src/oauth/mod.rs
Line 33 in a64a816
When I looked into splitting this up, most options truly seemed to make it more complicated, not less.