fix(cli): fix compiling issue on windows system by adding a missing param #4019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryZhous
changed the title
Collaborator
|
I am totally confused - how come it builds in CI on a windows machine? |
Contributor
Author
@michaelneale here's the context https://github.com/block/goose/actions/runs/15350197323, it only ran the CI build for macOS when the |
jamadeo
approved these changes
Aug 14, 2025
Collaborator
|
Thanks @GaryZhous good catch. @michaelneale we build on Windows for the app but I don't think we ever run any unit tests on windows in the CI process (which makes one wonder how this test was running to begin with...) |
katzdave
added a commit
that referenced
this pull request
Aug 14, 2025
…-messaging * 'main' of github.com:block/goose: chore: add info tooltip to share session button (#4038) Reroute routes (#4088) fix(cli): fix compiling issue on windows system by adding a missing param (#4019) fix: hide console window for stdio extensions on Windows (#4085) Do not fetch pricing information if GOOSE_CLI_SHOW_COST is false (#3901) blog: fixing links (#4089)
michaelneale
added a commit
that referenced
this pull request
Aug 15, 2025
* main: (21 commits) docs: fix experimental warning (#4102) fix not being able to add spaces to activity message area (#4055) remove and cleanup unused code (#4074) docs: Add missing references to smart_approve mode. (#4094) quick typo fix pulse blog (#4095) fix: update dictation settings handling and improve user feedback (#4093) chore: add info tooltip to share session button (#4038) Reroute routes (#4088) fix(cli): fix compiling issue on windows system by adding a missing param (#4019) fix: hide console window for stdio extensions on Windows (#4085) Do not fetch pricing information if GOOSE_CLI_SHOW_COST is false (#3901) blog: fixing links (#4089) Token counting reliability + summarization integration. (#3721) Skip ci builds for docs (#4087) blog: agent coordination patterns (#4086) docs: Blog - How I Used Goose to Rebuild My Website (#4076) docs: custom context file names (#4077) Blog: How Pulse MCP Used Goose to Automate Their Newsletter (#4075) Load recipe deeplinks in single window when app is closed (#4048) docs: make accurate the comments with links to unsigned builds of the app (#4070) ...
jsibbison-square
added a commit
that referenced
this pull request
Aug 18, 2025
…ol-visibility * origin/main: (26 commits) feat: adds cursor-agent as a cli provider (#4101) chore: remove vector search tool selection strategy (#3933) docs: add streamable_http install links (#4130) feat: iterating on summarize oneshot prompt (#4113) feat(mcp): Persist OAuth credentials to keyring (#4007) Sanitize Tags Unicode Block at prompt level (#4047) Fixing typos (#4114) chore(release): release version 1.4.0 (#4069) E2E tests working again (#4103) chore: Delete ARCHITECTURE.md (#4108) Add Youtube short to Kiwi MCP tutorial (#4107) docs: fix experimental warning (#4102) fix not being able to add spaces to activity message area (#4055) remove and cleanup unused code (#4074) docs: Add missing references to smart_approve mode. (#4094) quick typo fix pulse blog (#4095) fix: update dictation settings handling and improve user feedback (#4093) chore: add info tooltip to share session button (#4038) Reroute routes (#4088) fix(cli): fix compiling issue on windows system by adding a missing param (#4019) ...
This was referenced Aug 18, 2025
ayax79
pushed a commit
to ayax79/goose
that referenced
this pull request
Aug 21, 2025
…aram (block#4019) Signed-off-by: Jack Wright <jack.wright@nike.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows machine the code is not able to compile due to a missing param to the
call_toolfunction at the unit test session incrates/goose-mcp/src/developer/mod.rs, designed for windows under the conditional configuration check#[cfg(windows)](which is also the reason why the code can compile for linux machines). This pull request introduces a minor fix to the test code by adding the missingdummy_sender()param to thecall_toolfunction.before
after