fix(build): feed electronforge the icon explicitly for linux #4045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Cochard <[email protected]>
Collaborator
Collaborator
|
thanks @eyelight that is a great catch |
Contributor
Author
|
Wasn't aware of #4058 taking a look |
DOsinga
approved these changes
Aug 13, 2025
katzdave
added a commit
that referenced
this pull request
Aug 13, 2025
* 'main' of github.com:block/goose: fix(build): feed electronforge the icon explicitly for linux (#4045) Docs: Troubleshooting tip - Nodejs path on windows (#4065) fix: flag out uncompilable bit in windows (#4068) ci: fix docs-only filter to properly skip tests for documentation changes (#4066) fix: ctrl-C interruption in the CLI (#4057)
jsibbison-square
added a commit
that referenced
this pull request
Aug 14, 2025
…ol-visibility * origin/main: (43 commits) docs: Blog - How I Used Goose to Rebuild My Website (#4076) docs: custom context file names (#4077) Blog: How Pulse MCP Used Goose to Automate Their Newsletter (#4075) Load recipe deeplinks in single window when app is closed (#4048) docs: make accurate the comments with links to unsigned builds of the app (#4070) cleanup memory in chat (#4073) CLI: improve model selection ux (#4071) speed up loading extensions by loading in parallel (#4054) fix(build): feed electronforge the icon explicitly for linux (#4045) Docs: Troubleshooting tip - Nodejs path on windows (#4065) fix: flag out uncompilable bit in windows (#4068) ci: fix docs-only filter to properly skip tests for documentation changes (#4066) fix: ctrl-C interruption in the CLI (#4057) docs: mcp-ui support (#4049) fix: delete dialog layout (#4037) ci: fix markdown file pattern to skip builds for all .md files (#4061) docs: add window title (#4059) blog: cleaning up some posts (#4050) fix: this should be a debug message not a warn (#4024) Better provider logging (#4052) ...
This was referenced Aug 18, 2025
ayax79
pushed a commit
to ayax79/goose
that referenced
this pull request
Aug 21, 2025
) Signed-off-by: Jason Cochard <[email protected]> Signed-off-by: Jack Wright <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron forge has not been packaging the icon on rpm & deb builds, resulting in the electron icon getting distributed.
I removed the conditional logic in the config, and explicitly set the icon path in each linux maker, leaving the *.ico (windows) as the default.
To confirm after
npm run make, assuming you build on x64, this is how to open the packaged logo — before this PR it will be electron, goose after:Deb:
Rpm: