Skip to content

fix(ui): enable selection of zero-config providers in desktop GUI #3378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelneale merged 5 commits into from
Jul 21, 2025
Merged

fix(ui): enable selection of zero-config providers in desktop GUI #3378

michaelneale merged 5 commits into from
Jul 21, 2025

Conversation

@kwsantiago
Copy link
Contributor

@kwsantiago kwsantiago commented Jul 12, 2025 •
edited
Loading

Fixes #3360 #3386

Summary

Enables gemini-cli and claude-code providers in desktop GUI with multi-model support.

Changes

  • GUI Integration: Zero-config provider selection with auto-discovery
  • Multi-Model Support:
    • Claude: sonnet, opus, claude-3-5-sonnet-latest (default)
    • Gemini: gemini-2.5-pro
  • Environment Variables: GEMINI_CLI_COMMAND, CLAUDE_CODE_COMMAND for CLI customization

Testing

  • All models tested and verified working
  • Provider tests pass
  • Build succeeds

@cbruyndoncx
Copy link
Contributor

cbruyndoncx commented Jul 12, 2025

These CLI providers should have the command environment variables defined in the GUI i think.
Claude has CLAUDE_CODE_COMMAND , i would expect gemini to have similar GEMINI_CLI_COMMAND that can be tweaked / finetuned depending on the OS used.

@kwsantiago
Copy link
Contributor Author

kwsantiago commented Jul 12, 2025 •
edited
Loading

@cbruyndoncx good point! thanks for pointing out. My latest commit addresses that.

@kwsantiago kwsantiago mentioned this pull request Jul 14, 2025
Closed
@DOsinga DOsinga requested a review from michaelneale July 16, 2025 10:10
@michaelneale
Copy link
Collaborator

michaelneale commented Jul 17, 2025

nice @kwsantiago - I had a tenative trivial fix #3396 - but I think your change sounds better, would you be interested in re-applying this to the new GUI and new main branch and pushing again?

@michaelneale michaelneale added p2 Priority 2 - Medium waiting labels Jul 17, 2025
@michaelneale
Copy link
Collaborator

michaelneale commented Jul 17, 2025

this will fix #3360

@kwsantiago if you don't mind - #3386 - could be fixed to pass in allow edits to the claude code call:

claude --permission-mode acceptEdits -p --verbose --output-format json "list files in this directory"

for example: ideally would follow the goose mode selection if possible - would you be interested in adding that in?

@kwsantiago
Copy link
Contributor Author

kwsantiago commented Jul 17, 2025 •
edited
Loading

@michaelneale I re-applied this to the new GUI and new main branch (3317225), and included a fix for #3386 (e8cd6d4)

Please let me know if anything else is needed here.

@michaelneale
Copy link
Collaborator

michaelneale commented Jul 18, 2025

@kwsantiago if you can sign the DCO failing thing (click on it and it will tell you what to do) would be great

@michaelneale michaelneale mentioned this pull request Jul 18, 2025
Closed
@michaelneale
Copy link
Collaborator

michaelneale commented Jul 18, 2025

also need to run fmt and clippy - if you don't get to, I can update/push to your branch come next week (I have closed my PR as I think this is the right way)

@kwsantiago kwsantiago force-pushed the kwsantiago/gui-select-providers branch 2 times, most recently from 119d136 to 3c9e452 Compare July 19, 2025 02:16
@kwsantiago kwsantiago force-pushed the kwsantiago/gui-select-providers branch from 3c9e452 to 82977b3 Compare July 19, 2025 02:20
@kwsantiago
Copy link
Contributor Author

kwsantiago commented Jul 19, 2025

@michaelneale I fixed the DCO check and ran cargo fmt + clippy.

Please don't hesitate to reach out if anything else is needed here before we close this out. Thanks!

@michaelneale
Copy link
Collaborator

michaelneale commented Jul 20, 2025

thanks - taking a look now

michaelneale
michaelneale approved these changes Jul 20, 2025
View reviewed changes
Copy link
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once build passes, this seems ok. tagging @zanesq in case anything in here which he needs to be aware of

@michaelneale
Copy link
Collaborator

michaelneale commented Jul 21, 2025

@kwsantiago and thanks so much for pushing through this - it is a good one to have.

@kwsantiago
Copy link
Contributor Author

kwsantiago commented Jul 21, 2025

My pleasure @michaelneale , be assured, I will be back with more contributions to this awesome project! Love what you guys are doing here and want to help out as much as I can.

@michaelneale michaelneale mentioned this pull request Jul 21, 2025
Closed
@michaelneale michaelneale merged commit cfa99b3 into block:main Jul 21, 2025
17 of 20 checks passed
michaelneale added a commit that referenced this pull request Jul 21, 2025
@michaelneale
Merge branch 'main' into micn/install-with-openrouter
0bd7230 
* main:
  Extension Library Improvements (#3541)
  fix(ui): enable selection of zero-config providers in desktop GUI (#3378)
  refactor: Renames recipe route to recipes to be consistent (#3540)
  Blog: Orchestrating 6 Subagents to Build a Collaborative API Playground (#3528)
  Catch json errors a little better (#3437)
  Rust debug (#3510)
  refactor: Centralise deeplink encode and decode into server (#3489)
  feat: deprecate jetbrains extension in favor of public one (#2589)
  feat: Add LiteLLM provider with automatic prompt caching support (#3380)
  docs: update desktop instructions for managing sessions (#3522)
  docs: update desktop instructions for session recipes (#3521)
  Replace mcp_core::content types with rmcp::model types (#3500)
  docs: update desktop instructions for tool perms (#3518)
  docs: update desktop instructions for tool router (#3519)
  Alexhancock/reapply 3491 (#3515)
  docs: update mcp install instructions for desktop (#3504)
  Docs: Access settings in new UI (#3514)
  feat: switch from mcp_core::Role to rmcp::model::Role (#3488)
  Revert "fix the output not being visible issue (#3491)" (#3511)
  fix: Load and Use recipes in new window (#3501)
lifeizhou-ap added a commit that referenced this pull request Jul 22, 2025
@lifeizhou-ap
Merge branch 'main' into lifei/fix-error-message-when-ctrlc
6f4bf54 
* main: (32 commits)
  fix: use sequential when sub recipe task is 1. (#3573)
  fix: track message id to keep like with like (#3572)
  Replace mcp_core::prompt with rmcp::model types (#3561)
  feat (ui): close recipe modals with esc key (#3568)
  feat: recipes can retry with success criteria (#3474)
  Env var to set Ollama request timeout (#3516)
  Updating docs to match new UI (#3552)
  Improve Claude Code provider error message for missing CLI (#3363)
  feat: Work around Gemini API tool call quirks (#3328)
  feat(ui): Source CashSans-Bold and improve overall text rendering (#3091)
  refactor: Use openapi for recipe endpoint types and in frontend (#3548)
  Fix Google Analytics error for local dev (#3544)
  Extension Library Improvements (#3541)
  fix(ui): enable selection of zero-config providers in desktop GUI (#3378)
  refactor: Renames recipe route to recipes to be consistent (#3540)
  Blog: Orchestrating 6 Subagents to Build a Collaborative API Playground (#3528)
  Catch json errors a little better (#3437)
  Rust debug (#3510)
  refactor: Centralise deeplink encode and decode into server (#3489)
  feat: deprecate jetbrains extension in favor of public one (#2589)
  ...
@kwsantiago kwsantiago deleted the kwsantiago/gui-select-providers branch July 24, 2025 18:16
@michaelneale michaelneale mentioned this pull request Jul 27, 2025
Closed
atarantino pushed a commit to atarantino/goose that referenced this pull request Aug 5, 2025
@kwsantiago
fix(ui): enable selection of zero-config providers in desktop GUI (bl…
4b23b40 
…ock#3378)

Signed-off-by: Kyle Santiago <[email protected]>
Signed-off-by: Adam Tarantino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelneale michaelneale michaelneale approved these changes

Assignees

@michaelneale michaelneale

Labels

p2 Priority 2 - Medium waiting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

desktop GUI won't let you select gemini-cli or code providers

3 participants

@kwsantiago @cbruyndoncx @michaelneale