Skip to content

Conversation

@alexhancock
Copy link
Collaborator

Switch from mcp_core::Role to rmcp::model::Role

@alexhancock alexhancock requested a review from jamadeo July 17, 2025 21:04
Copy link
Collaborator

@jamadeo jamadeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent

Base automatically changed from alexhancock/rmcp-dep to main July 18, 2025 02:18
@alexhancock alexhancock force-pushed the alexhancock/rmcp-role branch 2 times, most recently from c2807a4 to b6503e1 Compare July 18, 2025 02:34
@alexhancock
Copy link
Collaborator Author

There is a small issue I think related to the changes that affect openapi spec generation which cause user messages not to show up properly. Will fix tomorrow before merge.

@alexhancock alexhancock force-pushed the alexhancock/rmcp-role branch 2 times, most recently from 2a10ff4 to 5aef1aa Compare July 18, 2025 15:30
@alexhancock alexhancock force-pushed the alexhancock/rmcp-role branch from 5aef1aa to 355ac32 Compare July 18, 2025 15:34
@alexhancock alexhancock merged commit 76da3a9 into main Jul 18, 2025
8 checks passed
@alexhancock alexhancock deleted the alexhancock/rmcp-role branch July 18, 2025 16:30
jsibbison-square added a commit that referenced this pull request Jul 20, 2025
…ntral-deeplinks

* origin/main: (22 commits)
  feat: deprecate jetbrains extension in favor of public one (#2589)
  feat: Add LiteLLM provider with automatic prompt caching support (#3380)
  docs: update desktop instructions for managing sessions (#3522)
  docs: update desktop instructions for session recipes (#3521)
  Replace mcp_core::content types with rmcp::model types (#3500)
  docs: update desktop instructions for tool perms (#3518)
  docs: update desktop instructions for tool router (#3519)
  Alexhancock/reapply 3491 (#3515)
  docs: update mcp install instructions for desktop (#3504)
  Docs: Access settings in new UI (#3514)
  feat: switch from mcp_core::Role to rmcp::model::Role (#3488)
  Revert "fix the output not being visible issue (#3491)" (#3511)
  fix: Load and Use recipes in new window (#3501)
  fix: working dir was not being set correctly  (#3477)
  Fix launching session in new window (#3497)
  Fix tool call allow still showing initial state in chat after navigating back (#3498)
  feat: add rmcp as a workspace dep (#3483)
  feat: consolidate subagent execution for dynamic tasks (#3444)
  fix token alert indicator/popovers hiding and showing (#3492)
  Fix llm errors not propagating to the ui and auto summarize not starting (#3490)
  ...
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
michaelneale added a commit that referenced this pull request Jul 21, 2025
* main:
  Extension Library Improvements (#3541)
  fix(ui): enable selection of zero-config providers in desktop GUI (#3378)
  refactor: Renames recipe route to recipes to be consistent (#3540)
  Blog: Orchestrating 6 Subagents to Build a Collaborative API Playground (#3528)
  Catch json errors a little better (#3437)
  Rust debug (#3510)
  refactor: Centralise deeplink encode and decode into server (#3489)
  feat: deprecate jetbrains extension in favor of public one (#2589)
  feat: Add LiteLLM provider with automatic prompt caching support (#3380)
  docs: update desktop instructions for managing sessions (#3522)
  docs: update desktop instructions for session recipes (#3521)
  Replace mcp_core::content types with rmcp::model types (#3500)
  docs: update desktop instructions for tool perms (#3518)
  docs: update desktop instructions for tool router (#3519)
  Alexhancock/reapply 3491 (#3515)
  docs: update mcp install instructions for desktop (#3504)
  Docs: Access settings in new UI (#3514)
  feat: switch from mcp_core::Role to rmcp::model::Role (#3488)
  Revert "fix the output not being visible issue (#3491)" (#3511)
  fix: Load and Use recipes in new window (#3501)
@jamadeo jamadeo mentioned this pull request Jul 22, 2025
4 tasks
atarantino pushed a commit to atarantino/goose that referenced this pull request Aug 5, 2025
Signed-off-by: Adam Tarantino <tarantino.adam@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants