refactor: Use openapi for recipe endpoint types and in frontend #3548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsibbison-square
force-pushed
the
jsibbison-20250721-openapi-recipes
branch
from
c3491b9 to
f14cdc2
Compare
jsibbison-square
changed the title
DOsinga
approved these changes
Jul 21, 2025
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
thanks for doing this. this is so much better
| } | ||
|
|
||
| if (!recipe.instructions && !recipe.prompt) { | ||
| throw new Error('Recipe must have either instructions or prompt'); |
|
|
||
| // Add common optional fields | ||
| if (ext.env_keys && ext.env_keys.length > 0) { | ||
| if ('env_keys' in ext && ext.env_keys && ext.env_keys.length > 0) { |
Collaborator
There was a problem hiding this comment.
if (ext?.env_keys?.length) {
Contributor
Author
There was a problem hiding this comment.
types seem to be very unhappy with that approach for reasons that make no sense to me. :(
| // Convert toolCall to match API expectations | ||
| ...(content.type === 'toolRequest' && 'toolCall' in content | ||
| ? { | ||
| toolCall: content.toolCall as unknown as { [key: string]: unknown }, |
Contributor
There was a problem hiding this comment.
Possibly a runtime risk with this conversion. Is there a way to determine the correct type?
lifeizhou-ap
added a commit
that referenced
this pull request
Jul 22, 2025
* main: (32 commits) fix: use sequential when sub recipe task is 1. (#3573) fix: track message id to keep like with like (#3572) Replace mcp_core::prompt with rmcp::model types (#3561) feat (ui): close recipe modals with esc key (#3568) feat: recipes can retry with success criteria (#3474) Env var to set Ollama request timeout (#3516) Updating docs to match new UI (#3552) Improve Claude Code provider error message for missing CLI (#3363) feat: Work around Gemini API tool call quirks (#3328) feat(ui): Source CashSans-Bold and improve overall text rendering (#3091) refactor: Use openapi for recipe endpoint types and in frontend (#3548) Fix Google Analytics error for local dev (#3544) Extension Library Improvements (#3541) fix(ui): enable selection of zero-config providers in desktop GUI (#3378) refactor: Renames recipe route to recipes to be consistent (#3540) Blog: Orchestrating 6 Subagents to Build a Collaborative API Playground (#3528) Catch json errors a little better (#3437) Rust debug (#3510) refactor: Centralise deeplink encode and decode into server (#3489) feat: deprecate jetbrains extension in favor of public one (#2589) ...
michaelneale
added a commit
that referenced
this pull request
Jul 22, 2025
* main: fix: use sequential when sub recipe task is 1. (#3573) fix: track message id to keep like with like (#3572) Replace mcp_core::prompt with rmcp::model types (#3561) feat (ui): close recipe modals with esc key (#3568) feat: recipes can retry with success criteria (#3474) Env var to set Ollama request timeout (#3516) Updating docs to match new UI (#3552) Improve Claude Code provider error message for missing CLI (#3363) feat: Work around Gemini API tool call quirks (#3328) feat(ui): Source CashSans-Bold and improve overall text rendering (#3091) refactor: Use openapi for recipe endpoint types and in frontend (#3548) Fix Google Analytics error for local dev (#3544)
atarantino
pushed a commit
to atarantino/goose
that referenced
this pull request
Aug 5, 2025
…k#3548) Signed-off-by: Adam Tarantino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request from #3489 (comment)
This PR is primarily focused on converting the /recipes endpoints to use openapi schema. This includes converting the frontend types to use the same types as the the api interface. Unfortunately I couldn't go all the way in converting in one go due to how the frontend has bundled a bunch of extra config into recipes (particularly for schedules) and the PR was starting to get to big. So this PR converts the api and some frontend types but TODOs are left for more required refactoring.
Manually tested all the recipe interactions.