feat: Work around Gemini API tool call quirks #3328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necaris
force-pushed
the
work-around-gemini-api-tool-call-quirks
branch
5 times, most recently
from
e54fa63 to
3a3edf0
Compare
necaris
changed the title
Collaborator
|
this looks good - but who has gemini access to validate - would be good to get a second check but tools and gemini is a known problem, so thanks @necaris |
necaris
force-pushed
the
work-around-gemini-api-tool-call-quirks
branch
3 times, most recently
from
f0dc741 to
d191fda
Compare
DOsinga
approved these changes
Jul 16, 2025
necaris
force-pushed
the
work-around-gemini-api-tool-call-quirks
branch
2 times, most recently
from
66afea6 to
bba842e
Compare
Collaborator
|
can you check on the linter failure so we can get this in? |
necaris
force-pushed
the
work-around-gemini-api-tool-call-quirks
branch
from
bba842e to
8428b98
Compare
Contributor
Author
|
Fixed and rebased, thanks @DOsinga for the nudge! |
Collaborator
|
ugh, I am sorry, fails on fmt |
Signed-off-by: Rami Chowdhury <[email protected]>
necaris
force-pushed
the
work-around-gemini-api-tool-call-quirks
branch
from
8428b98 to
513c9c9
Compare
Contributor
Author
|
Sorry, was out of town over the weekend, looks like it's green now after rebase and fix! |
lifeizhou-ap
added a commit
that referenced
this pull request
Jul 22, 2025
* main: (32 commits) fix: use sequential when sub recipe task is 1. (#3573) fix: track message id to keep like with like (#3572) Replace mcp_core::prompt with rmcp::model types (#3561) feat (ui): close recipe modals with esc key (#3568) feat: recipes can retry with success criteria (#3474) Env var to set Ollama request timeout (#3516) Updating docs to match new UI (#3552) Improve Claude Code provider error message for missing CLI (#3363) feat: Work around Gemini API tool call quirks (#3328) feat(ui): Source CashSans-Bold and improve overall text rendering (#3091) refactor: Use openapi for recipe endpoint types and in frontend (#3548) Fix Google Analytics error for local dev (#3544) Extension Library Improvements (#3541) fix(ui): enable selection of zero-config providers in desktop GUI (#3378) refactor: Renames recipe route to recipes to be consistent (#3540) Blog: Orchestrating 6 Subagents to Build a Collaborative API Playground (#3528) Catch json errors a little better (#3437) Rust debug (#3510) refactor: Centralise deeplink encode and decode into server (#3489) feat: deprecate jetbrains extension in favor of public one (#2589) ...
michaelneale
added a commit
that referenced
this pull request
Jul 22, 2025
* main: fix: use sequential when sub recipe task is 1. (#3573) fix: track message id to keep like with like (#3572) Replace mcp_core::prompt with rmcp::model types (#3561) feat (ui): close recipe modals with esc key (#3568) feat: recipes can retry with success criteria (#3474) Env var to set Ollama request timeout (#3516) Updating docs to match new UI (#3552) Improve Claude Code provider error message for missing CLI (#3363) feat: Work around Gemini API tool call quirks (#3328) feat(ui): Source CashSans-Bold and improve overall text rendering (#3091) refactor: Use openapi for recipe endpoint types and in frontend (#3548) Fix Google Analytics error for local dev (#3544)
atarantino
pushed a commit
to atarantino/goose
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Rami Chowdhury <[email protected]> Signed-off-by: Adam Tarantino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further refine the tool call parameters to work around the Google APIs' limited JSON schema support, using the Gemini CLI function as inspiration along with empirical testing with Gemini and the GitHub MCP server.