Use command line to run sub agent and sub recipe (in sequence or parallel) #3190

lifeizhou-ap · 2025-07-01T11:56:55Z

This PR is using goose command line to run task in subagent or sub-recipe.

What

Change to sub-recipe tool to only create sub recipe task instead of run sub-recipes.
Create sub_agent__execute_task tool to run a single task or multiple task in parallel
Task can be 2 types
- Sub recipe task. This task is created by sub recipe create task tool function and the task has attributes:
  - name (recipe name)
  - recipe_path (recipe file path)
  - command_parameters (param name and value pairs to be passed to the goose run recipe command line)
    This task is executed as goose run --recipe recipe_file --params name=value
- Sub agent task. This task is created by the main agent and has attributes. At the moment it only has text_instruction, I think later on it will have more attributes similar to recipe. I would like to discuss the use cases especially the model, tools (maybe some smart way to work out the tool and model based on the task?)
  - text_instruction
sub_agent__execute_task tool
- it uses goose run --recipe recipe_file --params name=value to run sub-recipe task
- it uses goose run --text text_instruction to run sub-agent task
- if it executes multiple tasks in parallel, it will create a worker pool and task queue to execute the tasks
TODO (won't be implemented in the PR)
- max turn
- error handling
- maybe some special logic for sub agent such as exclude some specific tools like platform tools.

Note

This PR defines the interfaces for the sub agent and sub recipe execution. The implementation of execute_task by Goose cli will be changed. We will use something like subagent.run(task) with a thread instead of a process.
Currently I use this sub agent execution tool name as sub_recipe... and with the description only for sub recipe. In this case we still can keep the same feature behaviour. When the subagent.run(task) is ready, we can rename the sub agent execution tool name back to sub_agent... and add the sub agent in the description

lifeizhou-ap · 2025-07-02T02:06:54Z

crates/goose/src/agents/sub_agent_execution_tool/tasks.rs

+async fn execute_task(task: Task) -> Result<Value, String> {
+    println!("=======Executing task: {:?}", task);
+
+    let mut command = if task.task_type == "sub_recipe" {


later on we could swap the implementation from use cmd to something sub_agent.run(task)

wendytang · 2025-07-02T20:41:09Z

crates/goose/src/agents/recipe_tools/sub_recipe_tools.rs

+    let input_schema = get_input_schema(sub_recipe).unwrap();
+    Tool::new(
+        format!("{}_{}", SUB_RECIPE_TASK_TOOL_NAME_PREFIX, sub_recipe.name),
+        "Before running this sub recipe, you should first create a task with this tool and then pass the task to the task executor".to_string(),


shall we add the recipe description into the tool description?

Hi @wendytang This is a good idea!

However, I will hold on this change because at this point, the subrecipe does not have the content of the sub recipe file, so it does not know the subrecipe description. Parsing sub recipe file logic is currently in the goose-cli, we are going to move it into the goose package or parsing it before running sub-agent, and then we can get the description.

At the moment, without the sub recipe description in the tool description, it works fine. But definitely we will add this in when the parsing recipe file logic moves to goose package

lifeizhou-ap · 2025-07-03T06:05:12Z

crates/goose/src/agents/sub_agent_execution_tool/sub_agent_execute_task_tool.rs

+
+use crate::agents::{sub_agent_execution_tool::lib::execute_tasks, tool_execution::ToolCallResult};
+
+pub const SUB_AGENT_EXECUTE_TASK_TOOL_NAME: &str = "sub_recipe__execute_task";


At the moment, only name with sub_recipe so that it does not conflict with the alpha feature. Later on, sub agent should be executed with this tool. so it will be renamed to sub_agent,,,

could we rename SUB_AGENT_EXECUTE_TASK_TOOL_NAME to SUB_RECIPE_EXECUTE_TASK_TOOL_NAME?

lifeizhou-ap · 2025-07-03T06:05:33Z

crates/goose/src/agents/sub_agent_execution_tool/sub_agent_execute_task_tool.rs

+pub fn create_sub_agent_execute_task_tool() -> Tool {
+    Tool::new(
+        SUB_AGENT_EXECUTE_TASK_TOOL_NAME,
+        "Only use this tool when you want to execute sub recipe task. **DO NOT** use this tool when you want to execute sub agent task.   


"DO NOT use this tool when you want to execute sub agent task. " => same reason as above

This reverts commit 17e04e5.

wendytang · 2025-07-04T00:11:19Z

crates/goose/src/agents/sub_agent_execution_tool/sub_agent_execute_task_tool.rs

+        SUB_AGENT_EXECUTE_TASK_TOOL_NAME,
+        "Only use this tool when you want to execute sub recipe task. **DO NOT** use this tool when you want to execute sub agent task.   
+        If the tasks are not specified to be executed in parallel, you should use this tool to run each task immediately by passing a single task to the tool for each run.
+        If you want to execute tasks in parallel, you should pass a list of tasks to the tool.",


I would add an example in the description

wendytang · 2025-07-04T00:14:04Z

crates/goose/src/agents/sub_agent_execution_tool/workers.rs

+#[cfg(test)]
+mod tests {
+    use super::*;
+    use crate::agents::sub_agent_execution_tool::types::Task;


Could we rename all the vars and files from sub_agent_execution_tool to sub_recipe_execution_tool?

shall we leave this PR as it is, and I'll address this in the following PRs based on the progress? I remember we agreed in our meeting that this tool will execute both sub-agent and sub recipe

I feel we are going to run the sub-agent/sub recipe as spawn thread soon instead of starting a goose cli process.

* main: feat(goose-cli): theme persistence & selection (#1693) chore(release): release version 1.0.32 (#3248) Add fuzzy file search functionality (#3240) update styling of user messages (#3247) Add support for escape key to dismiss settings menu (#3225) fix: Refactor string truncation logic into reusable utility function to avoid panic (#2818) (#2819) fix: Prevent modal from closing on text select. (#3127) fix: Add back lazy_static (#3243) chore: remove unused dependencies (#3049) feat: Add close button (X) to toast notifications (#3197) Adds json schema validation to goose recipe validate cli (#3234)

* update-to-v1.0.35: (57 commits) chore(release): release version 1.0.35 (block#3292) docs: enhanced code editing topic (block#3287) fix cu (block#3291) feat: Add environment variables to override model context limits (block#3260) chore(release): release version 1.0.34 (block#3285) fix(devcontainer): install protoc to fix build (block#3267) Enabling npx command to install on Windows Desktop (block#3283) Fix: Allow native Cmd+Up/Down cursor movement when user has typed text (block#3246) chore(release): release version 1.0.33 (block#3284) fix Windows Env Vars (block#3282) feat: bedrock image content support (block#3266) Add support in goose configure for streaming http mcp tools (block#3256) docs: add Alby MCP tutorial (block#3217) refactor(tests): make logging test in goose-cli less flaky on macos (block#3273) feat: cli can work with gui generated recipes (block#3254) Goose projects docs (block#3272) feat: add support for 'cu' command in extension installation (block#3261) Docs: Add cloudinary mcp tutorial (block#3268) fix: Enable agent to see instruction to use final output tool when it wasn't called (block#3253) Use command line to run sub agent and sub recipe (in sequence or parallel) (block#3190) ...

…llel) (#3190)

…llel) (block#3190) Signed-off-by: Adam Tarantino <[email protected]>

…llel) (block#3190) Signed-off-by: Soroosh <[email protected]>

…llel) (block#3190) Signed-off-by: Kyle Santiago <[email protected]>

…llel) (block#3190)

lifeizhou-ap added 5 commits July 1, 2025 14:09

parallel execution

8320bf9

fixed task schema

8f9392b

run subrecipe

e63485b

print output lively

bab0b98

run single task

daed8a6

lifeizhou-ap commented Jul 2, 2025

View reviewed changes

wendytang reviewed Jul 2, 2025

View reviewed changes

lifeizhou-ap added 5 commits July 3, 2025 11:47

fmt

9d2b4b6

merge main

d5a45a9

merge conflicts

614c43d

fixed format

a7cab6e

use the same output pattern as previous sub recipe implementation

9b5414e

lifeizhou-ap commented Jul 3, 2025

View reviewed changes

lifeizhou-ap marked this pull request as ready for review July 3, 2025 06:06

lifeizhou-ap added 2 commits July 3, 2025 20:33

moved the stateless functions to session utils module

17e04e5

Revert "moved the stateless functions to session utils module"

684ba42

This reverts commit 17e04e5.

wendytang reviewed Jul 4, 2025

View reviewed changes

lifeizhou-ap added 4 commits July 4, 2025 11:12

renamed to sub-recipe-execute-tool

0dc0b44

cleaned tool description

dbb6dbb

added extra property execution mode

197d3d1

wendytang approved these changes Jul 4, 2025

View reviewed changes

lifeizhou-ap merged commit 2e9a2a5 into main Jul 4, 2025
11 of 12 checks passed

lifeizhou-ap deleted the lifei/try-parallel branch July 4, 2025 03:13

chaitanyarahalkar mentioned this pull request Jul 5, 2025

Macos-only Sandboxing chaitanyarahalkar/goose#9

Open

lily-de mentioned this pull request Jul 7, 2025

chore(release): release version 1.0.34 #3285

Merged

ahau-square pushed a commit that referenced this pull request Jul 11, 2025

Use command line to run sub agent and sub recipe (in sequence or para…

f8b2337

…llel) (#3190)

atarantino pushed a commit to atarantino/goose that referenced this pull request Jul 14, 2025

Use command line to run sub agent and sub recipe (in sequence or para…

f15046f

…llel) (block#3190) Signed-off-by: Adam Tarantino <[email protected]>

s-soroosh pushed a commit to s-soroosh/goose that referenced this pull request Jul 18, 2025

Use command line to run sub agent and sub recipe (in sequence or para…

7039ea4

…llel) (block#3190) Signed-off-by: Soroosh <[email protected]>

kwsantiago pushed a commit to kwsantiago/goose that referenced this pull request Jul 19, 2025

Use command line to run sub agent and sub recipe (in sequence or para…

d1ba5b3

…llel) (block#3190) Signed-off-by: Kyle Santiago <[email protected]>

cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025

Use command line to run sub agent and sub recipe (in sequence or para…

2ddefda

…llel) (block#3190)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use command line to run sub agent and sub recipe (in sequence or parallel) #3190

Use command line to run sub agent and sub recipe (in sequence or parallel) #3190

Uh oh!

lifeizhou-ap commented Jul 1, 2025 •

edited

Loading

Uh oh!

lifeizhou-ap Jul 2, 2025

Uh oh!

wendytang Jul 2, 2025

Uh oh!

lifeizhou-ap Jul 3, 2025 •

edited

Loading

Uh oh!

lifeizhou-ap Jul 3, 2025 •

edited

Loading

Uh oh!

wendytang Jul 4, 2025 •

edited

Loading

Uh oh!

lifeizhou-ap Jul 3, 2025 •

edited

Loading

Uh oh!

wendytang Jul 4, 2025

Uh oh!

wendytang Jul 4, 2025

Uh oh!

lifeizhou-ap Jul 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		use crate::agents::{sub_agent_execution_tool::lib::execute_tasks, tool_execution::ToolCallResult};

		pub const SUB_AGENT_EXECUTE_TASK_TOOL_NAME: &str = "sub_recipe__execute_task";

Use command line to run sub agent and sub recipe (in sequence or parallel) #3190

Use command line to run sub agent and sub recipe (in sequence or parallel) #3190

Uh oh!

Conversation

lifeizhou-ap commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lifeizhou-ap Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

wendytang Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

lifeizhou-ap Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lifeizhou-ap Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wendytang Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lifeizhou-ap Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wendytang Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

wendytang Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

lifeizhou-ap Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lifeizhou-ap commented Jul 1, 2025 •

edited

Loading

lifeizhou-ap Jul 3, 2025 •

edited

Loading

lifeizhou-ap Jul 3, 2025 •

edited

Loading

wendytang Jul 4, 2025 •

edited

Loading

lifeizhou-ap Jul 3, 2025 •

edited

Loading

lifeizhou-ap Jul 4, 2025 •

edited

Loading