fix: Refactor string truncation logic into reusable utility function to avoid panic (#2818) #2819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toyamagu-2021
changed the title
cgwalters
approved these changes
Jun 7, 2025
Contributor
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
I'm not a maintainer here, just doing a drive by review since I recently submitted a different PR.
Comment on lines
+15
to
+20
| if s.chars().count() <= max_chars { | ||
| s.to_string() | ||
| } else { | ||
| let truncated: String = s.chars().take(max_chars.saturating_sub(3)).collect(); | ||
| format!("{}...", truncated) | ||
| } |
Contributor
There was a problem hiding this comment.
Totally fine as is, just a note this walks the string twice. Hopefully we aren't passing large file data here anyways.
Contributor
There was a problem hiding this comment.
I also came across https://doc.rust-lang.org/std/primitive.str.html#method.floor_char_boundary which is exactly what we want here, but yeah still experimental.
toyamagu-2021
changed the title
toyamagu-2021
changed the title
Extract repeated string truncation code from project.rs and session.rs into a new utils module with safe_truncate function. Also fix trailing whitespace in configure.rs. Signed-off-by: toyamagu2021 <[email protected]>
jamadeo
approved these changes
Jul 3, 2025
Signed-off-by: toyamagu2021 <[email protected]>
Contributor
Author
|
@jamadeo Sorry, I've fixed lint error. |
Signed-off-by: toyamagu2021 <[email protected]>
Contributor
Author
|
I've forgotten picking up #3243 🙏 ➜ ./bin/cargo clippy
Checking goose-cli v1.0.31 (/Users/tomoki-yamaguchi/github.com/toyamagu-2021/goose/crates/goose-cli)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.57s |
jamadeo
approved these changes
Jul 3, 2025
Collaborator
jamadeo
left a comment
jamadeo
left a comment
There was a problem hiding this comment.
Thanks @toyamagu-2021, looks great.
lifeizhou-ap
added a commit
that referenced
this pull request
Jul 4, 2025
* main: feat(goose-cli): theme persistence & selection (#1693) chore(release): release version 1.0.32 (#3248) Add fuzzy file search functionality (#3240) update styling of user messages (#3247) Add support for escape key to dismiss settings menu (#3225) fix: Refactor string truncation logic into reusable utility function to avoid panic (#2818) (#2819) fix: Prevent modal from closing on text select. (#3127) fix: Add back lazy_static (#3243) chore: remove unused dependencies (#3049) feat: Add close button (X) to toast notifications (#3197) Adds json schema validation to goose recipe validate cli (#3234)
atarantino
pushed a commit
to atarantino/goose
that referenced
this pull request
Jul 14, 2025
…to avoid panic (block#2818) (block#2819) Signed-off-by: toyamagu2021 <[email protected]> Signed-off-by: Adam Tarantino <[email protected]>
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
…to avoid panic (block#2818) (block#2819) Signed-off-by: toyamagu2021 <[email protected]> Signed-off-by: Soroosh <[email protected]>
kwsantiago
pushed a commit
to kwsantiago/goose
that referenced
this pull request
Jul 19, 2025
…to avoid panic (block#2818) (block#2819) Signed-off-by: toyamagu2021 <[email protected]> Signed-off-by: Kyle Santiago <[email protected]>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
…to avoid panic (block#2818) (block#2819) Signed-off-by: toyamagu2021 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2818
Motivation
Extract repeated string truncation code from project.rs and session.rs into a new utils module with safe_truncate function.
Also fix trailing
whitespace in configure.rs.
Verification
goose psworks well.Signed-off-by: toyamagu2021 [email protected]