fix: Prevent modal from closing on text select. #3127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamadeo
approved these changes
Jul 3, 2025
Collaborator
|
thank you @adamackerman, good fix |
lifeizhou-ap
added a commit
that referenced
this pull request
Jul 4, 2025
* main: feat(goose-cli): theme persistence & selection (#1693) chore(release): release version 1.0.32 (#3248) Add fuzzy file search functionality (#3240) update styling of user messages (#3247) Add support for escape key to dismiss settings menu (#3225) fix: Refactor string truncation logic into reusable utility function to avoid panic (#2818) (#2819) fix: Prevent modal from closing on text select. (#3127) fix: Add back lazy_static (#3243) chore: remove unused dependencies (#3049) feat: Add close button (X) to toast notifications (#3197) Adds json schema validation to goose recipe validate cli (#3234)
atarantino
pushed a commit
to atarantino/goose
that referenced
this pull request
Jul 14, 2025
Signed-off-by: Adam Tarantino <[email protected]>
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
Signed-off-by: Soroosh <[email protected]>
kwsantiago
pushed a commit
to kwsantiago/goose
that referenced
this pull request
Jul 19, 2025
Signed-off-by: Kyle Santiago <[email protected]>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a small UI issue where an open modal closes when selecting text for editing. To illustrate, here is the current behavior for when you select text and move your cursor off the open modal
Screen.Recording.2025-06-27.at.3.25.07.PM.mov
The modal gets closed even though I'm just trying to select text to edit the value. I don't think the modal should close in this scenario. This fix adds a check to see if text is currently selected to prevent closing the modal. Here is the new behavior
Screen.Recording.2025-06-27.at.3.23.58.PM.mov