Skip to content

fix Windows Env Vars #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kvadratni merged 1 commit into from
Jul 7, 2025
Merged

fix Windows Env Vars #3282

Kvadratni merged 1 commit into from
Jul 7, 2025

Conversation

@Kvadratni
Copy link
Contributor

@Kvadratni Kvadratni commented Jul 7, 2025 •
edited by angiejones
Loading

fixes #3276

This pull request refines the logic for persisting the Goose bin directory to the user's PATH environment variable in the persistPathForUser function within winShims.ts. The changes improve safety and usability by ensuring the user PATH is used exclusively, respecting the setx 1024-character limit, and providing detailed feedback to the user.

Enhancements to PATH management:

  • Updated the function to exclusively use the user PATH instead of system PATH, ensuring no overwrites occur and respecting the setx command's 1024-character limit.
  • Added checks to prevent exceeding the PATH length limit and provided warnings and suggestions for resolving issues if the limit is reached.
  • Improved feedback messages to inform users about the current and new PATH lengths, as well as actions taken (e.g., adding or reordering the Goose bin directory).

@Kvadratni Kvadratni mentioned this pull request Jul 7, 2025
Closed
@Kvadratni Kvadratni marked this pull request as ready for review July 7, 2025 18:59
@angiejones angiejones changed the title fix https://github.com/block/goose/issues/3276 fix Windows Env Vars Jul 7, 2025
@Kvadratni Kvadratni merged commit e700bdb into main Jul 7, 2025
14 of 16 checks passed
@Kvadratni Kvadratni deleted the mnovich/windows-env-issue branch July 7, 2025 19:51
@lily-de lily-de mentioned this pull request Jul 7, 2025
Merged
zanesq added a commit that referenced this pull request Jul 8, 2025
@zanesq
Merge branch 'main' of github.com:block/goose into nk/vis-update
26f5833 
* 'main' of github.com:block/goose:
  feat: Add environment variables to override model context limits (#3260)
  chore(release): release version 1.0.34 (#3285)
  fix(devcontainer): install protoc to fix build (#3267)
  Enabling npx command to install on Windows Desktop (#3283)
  Fix: Allow native Cmd+Up/Down cursor movement when user has typed text (#3246)
  chore(release): release version 1.0.33 (#3284)
  fix Windows Env Vars (#3282)

# Conflicts:
#	ui/desktop/src/components/ChatInput.tsx
dianed-square added a commit to dianed-square/goose that referenced this pull request Jul 8, 2025
@dianed-square
Update to v1.0.35 from upstream
dc86929 
* update-to-v1.0.35: (57 commits)
  chore(release): release version 1.0.35 (block#3292)
  docs: enhanced code editing topic (block#3287)
  fix cu (block#3291)
  feat: Add environment variables to override model context limits (block#3260)
  chore(release): release version 1.0.34 (block#3285)
  fix(devcontainer): install protoc to fix build (block#3267)
  Enabling npx command to install on Windows Desktop (block#3283)
  Fix: Allow native Cmd+Up/Down cursor movement when user has typed text (block#3246)
  chore(release): release version 1.0.33 (block#3284)
  fix Windows Env Vars (block#3282)
  feat: bedrock image content support (block#3266)
  Add support in goose configure for streaming http mcp tools (block#3256)
  docs: add Alby MCP tutorial (block#3217)
  refactor(tests): make logging test in goose-cli less flaky on macos (block#3273)
  feat: cli can work with gui generated recipes (block#3254)
  Goose projects docs (block#3272)
  feat: add support for 'cu' command in extension installation (block#3261)
  Docs: Add cloudinary mcp tutorial (block#3268)
  fix: Enable agent to see instruction to use final output tool when it wasn't called (block#3253)
  Use command line to run sub agent and sub recipe (in sequence or parallel) (block#3190)
  ...
lifeizhou-ap added a commit that referenced this pull request Jul 9, 2025
@lifeizhou-ap
Merge branch 'main' into lifei/run-sub-recipe-multiple-times
c984764 
* main: (23 commits)
  docs: VS Code MCP video (#3307)
  docs: fixed broken link (#3306)
  Add YouTube video to Netlify MCP documentation (#3302)
  docs: add sub-recipes topic (#3241)
  docs: move topics to tutorials section (#3297)
  site analytics (#3293)
  chore(release): release version 1.0.35 (#3292)
  docs: enhanced code editing topic (#3287)
  fix cu (#3291)
  feat: Add environment variables to override model context limits (#3260)
  chore(release): release version 1.0.34 (#3285)
  fix(devcontainer): install protoc to fix build (#3267)
  Enabling npx command to install on Windows Desktop (#3283)
  Fix: Allow native Cmd+Up/Down cursor movement when user has typed text (#3246)
  chore(release): release version 1.0.33 (#3284)
  fix Windows Env Vars (#3282)
  feat: bedrock image content support (#3266)
  Add support in goose configure for streaming http mcp tools (#3256)
  docs: add Alby MCP tutorial (#3217)
  refactor(tests): make logging test in goose-cli less flaky on macos (#3273)
  ...
michaelneale added a commit that referenced this pull request Jul 9, 2025
@michaelneale
Merge branch 'main' into jackamadeo/provider-streaming
85be28e 
* main: (23 commits)
  docs: VS Code MCP video (#3307)
  docs: fixed broken link (#3306)
  Add YouTube video to Netlify MCP documentation (#3302)
  docs: add sub-recipes topic (#3241)
  docs: move topics to tutorials section (#3297)
  site analytics (#3293)
  chore(release): release version 1.0.35 (#3292)
  docs: enhanced code editing topic (#3287)
  fix cu (#3291)
  feat: Add environment variables to override model context limits (#3260)
  chore(release): release version 1.0.34 (#3285)
  fix(devcontainer): install protoc to fix build (#3267)
  Enabling npx command to install on Windows Desktop (#3283)
  Fix: Allow native Cmd+Up/Down cursor movement when user has typed text (#3246)
  chore(release): release version 1.0.33 (#3284)
  fix Windows Env Vars (#3282)
  feat: bedrock image content support (#3266)
  Add support in goose configure for streaming http mcp tools (#3256)
  docs: add Alby MCP tutorial (#3217)
  refactor(tests): make logging test in goose-cli less flaky on macos (#3273)
  ...
GaryZhous pushed a commit to GaryZhous/goose that referenced this pull request Jul 9, 2025
@Kvadratni @GaryZhous
fix Windows Env Vars (block#3282)
8ae1244
ahau-square pushed a commit that referenced this pull request Jul 11, 2025
@Kvadratni
fix Windows Env Vars (#3282)
512d511
atarantino pushed a commit to atarantino/goose that referenced this pull request Jul 14, 2025
@Kvadratni @atarantino
fix Windows Env Vars (block#3282)
c194925 
Signed-off-by: Adam Tarantino <[email protected]>
s-soroosh pushed a commit to s-soroosh/goose that referenced this pull request Jul 18, 2025
@Kvadratni @s-soroosh
fix Windows Env Vars (block#3282)
1ce93bc 
Signed-off-by: Soroosh <[email protected]>
kwsantiago pushed a commit to kwsantiago/goose that referenced this pull request Jul 19, 2025
@Kvadratni @kwsantiago
fix Windows Env Vars (block#3282)
db6af92 
Signed-off-by: Kyle Santiago <[email protected]>
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
@Kvadratni
fix Windows Env Vars (block#3282)
9e9c3ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lily-de lily-de lily-de approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@Kvadratni @lily-de