fix: Don't break from consuming subprocess output in shell tool until both streams are done #2771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamadeo
changed the title
jamadeo
changed the title
…-truncate' into jackamadeo/fix-tool-truncate
michaelneale
added a commit
that referenced
this pull request
Jun 5, 2025
* main: (82 commits) feat: lead/worker model (#2719) fix: pass ref in pr comment workflow (#2777) feat: goose web for local terminal alternative (#2718) chore: run CI on merge_group (#2786) fix: Don't break from consuming subprocess output in shell tool until both streams are done (#2771) Add retries w/ exponential backoff for databricks provider (#2764) Fix paths in google drive mcp documentation (#2775) testing windows build (#2770) docs: Add Context7 YouTube Video (#2779) cli(command): Add `export` command to CLI for markdown export of sessions (#2533) fix(copilot): gh copilot auth token conflicts w/ gh mcp env var (#2743) feat(providers): Add support for Gemini 2.5 Flash Preview and Pro Preview models (#2780) fix: pr comment build cli workflow (#2774) hotfix: don't always run prompt (#2773) Lifei/test workflow (#2772) chore: use hermit to install node, rust and protoc (#2766) Feat: Refined the documentation for Goose (#2751) mcp(developer): add fallback on .gitignore if no .gooseignore is present (#2661) cli(ux): Show active context length in CLI (#2315) cli(config): Add GOOSE_CONTEXT_STRATEGY setting (#2666) ...
lifeizhou-ap
added a commit
that referenced
this pull request
Jun 5, 2025
* main: feat: lead/worker model (#2719) fix: pass ref in pr comment workflow (#2777) feat: goose web for local terminal alternative (#2718) chore: run CI on merge_group (#2786) fix: Don't break from consuming subprocess output in shell tool until both streams are done (#2771) Add retries w/ exponential backoff for databricks provider (#2764) Fix paths in google drive mcp documentation (#2775) testing windows build (#2770) docs: Add Context7 YouTube Video (#2779) cli(command): Add `export` command to CLI for markdown export of sessions (#2533) fix(copilot): gh copilot auth token conflicts w/ gh mcp env var (#2743) feat(providers): Add support for Gemini 2.5 Flash Preview and Pro Preview models (#2780)
iandouglas
pushed a commit
that referenced
this pull request
Jun 5, 2025
… both streams are done (#2771) Co-authored-by: Max Novich <[email protected]>
Contributor
|
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
… both streams are done (block#2771) Co-authored-by: Max Novich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we might break out of the output processing loop before everything is written. I can't reproduce this on my mac but I'm guessing other platforms might behave differently here.
This is an attempt at fixing #2767 in which the output is incomplete on a Windows+WSL setup.
This also includes a better clean-up of the spinner when we print the tool output, which had led to some confusion about where this was actually failing before.