mcp(developer): add fallback on .gitignore if no .gooseignore is present #2661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salman1993
approved these changes
May 28, 2025
Contributor
Author
|
Should be good to go, @angiejones? |
katzdave
added a commit
to katzdave/goose
that referenced
this pull request
Jun 3, 2025
* upstream/main: Feat: Refined the documentation for Goose (block#2751) mcp(developer): add fallback on .gitignore if no .gooseignore is present (block#2661) cli(ux): Show active context length in CLI (block#2315) cli(config): Add GOOSE_CONTEXT_STRATEGY setting (block#2666) fix: new models have different messages for context length exceeded (block#2763)
lifeizhou-ap
added a commit
that referenced
this pull request
Jun 4, 2025
* main: fix: pr comment build cli workflow (#2774) hotfix: don't always run prompt (#2773) Lifei/test workflow (#2772) chore: use hermit to install node, rust and protoc (#2766) Feat: Refined the documentation for Goose (#2751) mcp(developer): add fallback on .gitignore if no .gooseignore is present (#2661) cli(ux): Show active context length in CLI (#2315) cli(config): Add GOOSE_CONTEXT_STRATEGY setting (#2666) fix: new models have different messages for context length exceeded (#2763) fix: increase limit for direct to disk for performance (#2762) Revert "chore: use hermit in goose" (#2759) alexhancock/remove-settings-v1 (#2744) blog: Democratizing Detection Engineering at Block with Goose and Panther MCP (#2746)
michaelneale
added a commit
that referenced
this pull request
Jun 5, 2025
* main: (82 commits) feat: lead/worker model (#2719) fix: pass ref in pr comment workflow (#2777) feat: goose web for local terminal alternative (#2718) chore: run CI on merge_group (#2786) fix: Don't break from consuming subprocess output in shell tool until both streams are done (#2771) Add retries w/ exponential backoff for databricks provider (#2764) Fix paths in google drive mcp documentation (#2775) testing windows build (#2770) docs: Add Context7 YouTube Video (#2779) cli(command): Add `export` command to CLI for markdown export of sessions (#2533) fix(copilot): gh copilot auth token conflicts w/ gh mcp env var (#2743) feat(providers): Add support for Gemini 2.5 Flash Preview and Pro Preview models (#2780) fix: pr comment build cli workflow (#2774) hotfix: don't always run prompt (#2773) Lifei/test workflow (#2772) chore: use hermit to install node, rust and protoc (#2766) Feat: Refined the documentation for Goose (#2751) mcp(developer): add fallback on .gitignore if no .gooseignore is present (#2661) cli(ux): Show active context length in CLI (#2315) cli(config): Add GOOSE_CONTEXT_STRATEGY setting (#2666) ...
iandouglas
pushed a commit
that referenced
this pull request
Jun 5, 2025
Collaborator
|
@dbraduan we might need to revert this, there are cases where people don't want to automatically have goose ignore git ignored files. wdyt? From a user below: Seems to me like those are different ignores with different purposes. This has been causing some annoyances for me, it seems cumbersome to create a blank local .gooseignore just to get it to not ignore anything. This is a kind of an anti-pattern for data workflows. I frequently work in a git repo and have .csv files gitignored because I don't want to be saving full datasets to the git history. Goose now can't interact with those. It also seems like even if I define a blank .gooseignore in the same directory, it still ignores everything from the .gitignore. |
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that our .gitignore wasn't really respected, and saw goose has a bit different approach to determining it's .gooseignore.
Adding a fallback to .gitignore before fallback to default 3 patterns.
This is a bit of a breaking change for people who used this MCP without previously having
.gooseignore, but it's commonly used in other Agents:Alternatively, happy to hide this behavior under a config setting.