Skip to content

Conversation

@bkvarda
Copy link
Contributor

@bkvarda bkvarda commented Jun 3, 2025

Adds retries w/ exponential backoff and configurable settings for Databricks provider for common transient errors

Example

 2025-06-03T04:07:40.714284Z  WARN goose::providers::databricks: Rate limit exceeded (attempt 1/6): Some(Object {"error_code": String("REQUEST_LIMIT_EXCEEDED"), "message": String("REQUEST_LIMIT_EXCEEDED: Exceeded workspace rate limit for databricks-claude-3-7-sonnet. Please use a provisioned throughput Foundation Model APIs endpoint for a higher rate limit.")}). Retrying after backoff...
    at crates/goose/src/providers/databricks.rs:370

  2025-06-03T04:07:41.585127Z  WARN goose::providers::databricks: Rate limit exceeded (attempt 2/6): Some(Object {"error_code": String("REQUEST_LIMIT_EXCEEDED"), "message": String("REQUEST_LIMIT_EXCEEDED: Exceeded workspace rate limit for databricks-claude-3-7-sonnet. Please use a provisioned throughput Foundation Model APIs endpoint for a higher rate limit.")}). Retrying after backoff...

@bkvarda bkvarda changed the title Add exponential backoff for databricks provider Add retries w/ exponential backoff for databricks provider Jun 3, 2025
@michaelneale
Copy link
Collaborator

thanks @bkvarda - need some rust format/clippy checks to run - but this looks ok to me - I can fix it up if it is ok to push to your branch to update things? I think can consoldate it with #2763 change perhaps (which just ads some more messages).
But appreciate this, I hit this a lot!

@bkvarda
Copy link
Contributor Author

bkvarda commented Jun 3, 2025

@michaelneale hopefully i fixed the clippy/cargo fmt issues.

@angiejones angiejones requested a review from michaelneale June 3, 2025 20:49
Copy link
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to me from what I can tell

@baxen baxen merged commit a1ebd2f into block:main Jun 4, 2025
6 checks passed
michaelneale added a commit that referenced this pull request Jun 5, 2025
* main: (82 commits)
  feat: lead/worker model (#2719)
  fix: pass ref in pr comment workflow (#2777)
  feat: goose web for local terminal alternative (#2718)
  chore: run CI on merge_group (#2786)
  fix: Don't break from consuming subprocess output in shell tool until both streams are done (#2771)
  Add retries w/ exponential backoff for databricks provider (#2764)
  Fix paths in google drive mcp documentation (#2775)
  testing windows build (#2770)
  docs: Add Context7 YouTube Video (#2779)
  cli(command): Add `export` command to CLI for markdown export of sessions (#2533)
  fix(copilot): gh copilot auth token conflicts w/ gh mcp env var (#2743)
  feat(providers): Add support for Gemini 2.5 Flash Preview and Pro Preview models (#2780)
  fix: pr comment build cli workflow (#2774)
  hotfix: don't always run prompt (#2773)
  Lifei/test workflow (#2772)
  chore: use hermit to install node, rust and protoc (#2766)
  Feat: Refined the documentation for Goose (#2751)
  mcp(developer): add fallback on .gitignore if no .gooseignore is present (#2661)
  cli(ux): Show active context length in CLI (#2315)
  cli(config): Add GOOSE_CONTEXT_STRATEGY setting (#2666)
  ...
lifeizhou-ap added a commit that referenced this pull request Jun 5, 2025
* main:
  feat: lead/worker model (#2719)
  fix: pass ref in pr comment workflow (#2777)
  feat: goose web for local terminal alternative (#2718)
  chore: run CI on merge_group (#2786)
  fix: Don't break from consuming subprocess output in shell tool until both streams are done (#2771)
  Add retries w/ exponential backoff for databricks provider (#2764)
  Fix paths in google drive mcp documentation (#2775)
  testing windows build (#2770)
  docs: Add Context7 YouTube Video (#2779)
  cli(command): Add `export` command to CLI for markdown export of sessions (#2533)
  fix(copilot): gh copilot auth token conflicts w/ gh mcp env var (#2743)
  feat(providers): Add support for Gemini 2.5 Flash Preview and Pro Preview models (#2780)
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants