Revert "chore: use hermit in goose" #2759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelneale
approved these changes
Jun 2, 2025
michaelneale
added a commit
that referenced
this pull request
Jun 3, 2025
- Add pr_number input parameter to build-cli.yml workflow - Fetch PR details and checkout correct branch/commit when building from PR comments - Maintain backward compatibility for non-PR builds (releases, canary) - Fixes issue where .build-cli command used main branch instead of PR branch This resolves the root cause that led to PR #2759 revert of Hermit integration. The build-cli workflow now properly uses the PR's branch code when triggered from PR comments, enabling safe re-introduction of Hermit toolchain management.
lifeizhou-ap
added a commit
that referenced
this pull request
Jun 3, 2025
This reverts commit e563546.
lifeizhou-ap
added a commit
that referenced
this pull request
Jun 4, 2025
* main: fix: pr comment build cli workflow (#2774) hotfix: don't always run prompt (#2773) Lifei/test workflow (#2772) chore: use hermit to install node, rust and protoc (#2766) Feat: Refined the documentation for Goose (#2751) mcp(developer): add fallback on .gitignore if no .gooseignore is present (#2661) cli(ux): Show active context length in CLI (#2315) cli(config): Add GOOSE_CONTEXT_STRATEGY setting (#2666) fix: new models have different messages for context length exceeded (#2763) fix: increase limit for direct to disk for performance (#2762) Revert "chore: use hermit in goose" (#2759) alexhancock/remove-settings-v1 (#2744) blog: Democratizing Detection Engineering at Block with Goose and Panther MCP (#2746)
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2754
Build cli failed. I have tested in the branch, but it failed when i merged to main. There is a bug to run build-cli in branch, it does not use the latest version of the branch, it uses the main branch code.
Revert this PR now, will fix the issue soon