Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Student and Institution: PIR: Program Name and Program Description from student request not displayed for institution or for student (View Application) #3789

Closed
4 tasks
astridSABC opened this issue Oct 11, 2024 · 2 comments
Closed
4 tasks

BUG: Student and Institution: PIR: Program Name and Program Description from student request not displayed for institution or for student (View Application) #3789

astridSABC opened this issue Oct 11, 2024 · 2 comments
Assignees
@sh16011993 @Joshua-Lakusta
Labels
Ad-hoc Bug Something isn't working Institution Institution Features Student Student Features
Milestone
Post Part-Time Pr...

Comments

@astridSABC
Copy link
Collaborator

astridSABC commented Oct 11, 2024 •
edited by sh16011993
Loading

Describe the Bug
The PIR (Programs) program name and program description created by the student are not displayed in the Student View Application or in the Institution PIR view for the request.

The institution won't know what program that the student is requesting.

Expected Behaviour

Student View Application
Program name that you entered is displayed
Program description that you entered is displayed
Start date and end dates that you entered are displayed
TBD: Select your study dates section is not displayed as this is a program request

image.png

Institution view
Program name that the student entered is displayed
Program description that the student entered is displayed
Start date and end dates that the student entered are displayed

Actual Behaviour

Student view:
Program name that the student entered is not displayed. ‘Enter the name of your program’ is displayed
Program description field is blank
Start date and end dates are displayed
Select your study dates and field is not displayed/disabled

image.png

Institution view:
Program name that the student entered is not displayed
Program description that the student entered is not displayed

image.png

Steps To Reproduce

Precondition:
BC Public institution (designated)
Student account with verified SIN

  1. Login to student portal
  2. Click “Start Application” button
  3. Select program year "(2024 – 2025 – My first…)" in the program year dropdown list
  4. Click “Start Application” button
  5. Select an institution from the select your institution dropdown list
  6. Select "Part time" for capacity
  7. Select “Your program is not listed” checkbox
  8. Enter any valid name in the program name field (required field): e.g. B Sc Ocean Science
  9. Enter any valid information in the program description field (required field): e.g. test this
  10. Enter any valid date in the “Start date” calendar widget (e.g. Sept. 4, 2024)
  11. Enter any valid date in the “End date” calendar widget (e.g. Dec. 20, 2024)
  12. Take a screenshot of the program that you entered or note the contents of the fields above (steps 8-12)
  13. Continue with generic information for the rest of the application
  14. Confirm submission
  15. Submit application
  16. Application needs to be “In Progress” status
  17. Click “Financial Aid Application” link
  18. Click “View application” from Application actions dropdown list
  19. Click “Program” tab
  20. Scroll to the Program selection section
  21. Note the program information that was entered for the program info request previously above


  22. Login to the institution portal
  23. Select location to view the Program Info Request
  24. Select “Program Info Requests”
  25. Click “View” button beside the student that has created a Program info request for a program
  26. Note the screen

Technical

  • Ensure PIRs are tested using two scenarios.
    • PIR when the program is not provided.
    • PIR when the offering is not provided.
  • E2E to test the PIR to get information for the two scanrios above.
@astridSABC astridSABC added Ad-hoc Bug Something isn't working Institution Institution Features Student Student Features Business Items under Business Consideration labels Oct 11, 2024
@CarlyCotton
Copy link
Collaborator

CarlyCotton commented Oct 21, 2024 •
edited
Loading

--

@Joshua-Lakusta Joshua-Lakusta added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Oct 22, 2024
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Oct 22, 2024
@sh16011993 sh16011993 self-assigned this Nov 12, 2024
@CarlyCotton
Copy link
Collaborator

@sh16011993 Just reproduced in test

Student App:
image.png

PIR View:
image.png

sh16011993 added a commit that referenced this issue Nov 15, 2024
@sh16011993
#3789 - PIR: Program Name and Program Description Bug
5cbc82b
github-merge-queue bot pushed a commit that referenced this issue Nov 15, 2024
@sh16011993
#3789 - PIR: Program Name and Program Description Bug (#3944)
35838a8 
**As a part of this PR, the bug for the PIR where the Program Name and
the Program Description are not showing up once the application is
submitted is fixed.**

**Fix:** The bug was happening because both the fields (Name and
Description) were having a conditional set as below:

```
"conditional": {
  "show": true,
  "when": "programnotListed",
  "eq": "true"
},
```

Removed the above piece of code for both the program name and program
description for all the program years.

The problem is that `programnotListed` never has the value `true`. It is
a `Select Boxes Component` rather than the `Checkbox Component` which
gets the value `programnotListed`. We do not need to rely on this
component because both the components `Program Name` and `Program
Description` are wrapped inside a container component that has a
conditional setup on it.

Tested the above for the below scenarios:

**1.  Program is not listed**

<img width="1025" alt="image"
src="https://github.com/user-attachments/assets/4e14f404-af5e-4306-b970-b7859cbce5a6">


-------------------------------------------------------------------------------------------------------------

**2.  Study is not listed**

<img width="944" alt="image"
src="https://github.com/user-attachments/assets/926615d5-6e12-4acb-888e-152be523c166">
github-merge-queue bot pushed a commit that referenced this issue Nov 19, 2024
@dheepak-aot
#3789 - Update the form IO conditions based on form data (#3964)
6002f6e 
## Updated the condition to render the program name and program
description

- [x] Updated the condition to render the program name and program
description fields only when a program is not selected in the student
application(One of the PIR situation).
- [x] The input which says `Your program is not listed` is a `select
box` and not check box. So we can use only custom condition to evaluate
its output at it will be in an object form like this.
```json
 "myProgramNotListed": {
      "programnotListed": false
    }
```


![image](https://github.com/user-attachments/assets/f3d55d2a-4455-4bed-883d-b5d78e0c1cc8)

**Formio condition updated to :**

![image](https://github.com/user-attachments/assets/305385c3-30ac-4434-b5d2-c5d9a9c74227)


## Updated the read only selected program and offering display

- [x] Updated the read only selected program and selected offering
display only when the respective value is present.

Currently it is displaying as blank in PIR situations.


![image](https://github.com/user-attachments/assets/00e42823-5e4c-4f67-a0aa-5d5864e7a478)


![image](https://github.com/user-attachments/assets/d5fa0abc-c7ab-4e00-b5a1-96dc189299b2)
github-merge-queue bot pushed a commit that referenced this issue Nov 20, 2024
@dheepak-aot
#3789 - Fix program description on Institution PIR Page (#3967)
3eec04e 
## Issue description and fix

Issue: When a program is selected in a student application but study
period is not selected and submitted for PIR review, the Institution PIR
page was displaying the `program name` in the `program description`
section.

- [x] Fix: The formIO was neither receiving nor displaying a program
description that was coming from the original program. Hence the API was
enhanced and FormIO was updated to receive the program description
variable.


![image](https://github.com/user-attachments/assets/a9e9843a-c18e-4de8-b1a7-3b3373380cde)


![image](https://github.com/user-attachments/assets/5f1944df-5340-4ef7-b471-ab89cf3dd625)
@ninosamson ninosamson reopened this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sh16011993 sh16011993

@Joshua-Lakusta Joshua-Lakusta

Labels
Ad-hoc Bug Something isn't working Institution Institution Features Student Student Features
Projects
None yet
Milestone
Post Part-Time Primera Importante Mucho
Development

No branches or pull requests
6 participants
@sh16011993 @ninosamson @andrewsignori-aot @Joshua-Lakusta @CarlyCotton @astridSABC