#3789 - Fix program description on Institution PIR Page #3967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
guru-aot
reviewed
Nov 20, 2024
| @@ -522,6 +522,7 @@ export class ApplicationService extends RecordDataModelService<Application> { | |||
| "user.lastName", | |||
| "pirProgram.id", | |||
| "pirProgram.name", | |||
| "pirProgram.description", | |||
guru-aot
reviewed
Nov 20, 2024
| @@ -627,7 +629,7 @@ | |||
| "value": "" | |||
| } | |||
| ], | |||
| "content": "<!--studentCustomProgramDescription value is from the application dynamic data(text field) \nand studentSelectedProgram is from the program drop down-->\n{{ data.studentCustomProgramDescription ?? data.studentSelectedProgram }}", | |||
| "content": "<!--studentCustomProgramDescription value is from the application dynamic data(text field) \nand studentSelectedProgram is from the program drop down-->\n{{ data.studentCustomProgramDescription ?? data.studentSelectedProgramDescription }}", | |||
guru-aot
approved these changes
Nov 20, 2024
andrewsignori-aot
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description and fix
Issue: When a program is selected in a student application but study period is not selected and submitted for PIR review, the Institution PIR page was displaying the
program namein theprogram descriptionsection.