Skip to content

Commit 35838a8

Browse files
authored
#3789 - PIR: Program Name and Program Description Bug (#3944)
**As a part of this PR, the bug for the PIR where the Program Name and the Program Description are not showing up once the application is submitted is fixed.** **Fix:** The bug was happening because both the fields (Name and Description) were having a conditional set as below: ``` "conditional": { "show": true, "when": "programnotListed", "eq": "true" }, ``` Removed the above piece of code for both the program name and program description for all the program years. The problem is that `programnotListed` never has the value `true`. It is a `Select Boxes Component` rather than the `Checkbox Component` which gets the value `programnotListed`. We do not need to rely on this component because both the components `Program Name` and `Program Description` are wrapped inside a container component that has a conditional setup on it. Tested the above for the below scenarios: **1. Program is not listed** <img width="1025" alt="image" src="https://github.com/user-attachments/assets/4e14f404-af5e-4306-b970-b7859cbce5a6"> ------------------------------------------------------------------------------------------------------------- **2. Study is not listed** <img width="944" alt="image" src="https://github.com/user-attachments/assets/926615d5-6e12-4acb-888e-152be523c166">
1 parent cfd1a7e commit 35838a8

File tree

3 files changed

+0
-30
lines changed

3 files changed

+0
-30
lines changed

sources/packages/forms/src/form-definitions/sfaa2022-23.json

-10
Original file line numberDiff line numberDiff line change
@@ -2093,11 +2093,6 @@
20932093
"pattern": ""
20942094
},
20952095
"key": "programName",
2096-
"conditional": {
2097-
"show": true,
2098-
"when": "programnotListed",
2099-
"eq": "true"
2100-
},
21012096
"type": "textfield",
21022097
"input": true,
21032098
"prefix": "",
@@ -2174,11 +2169,6 @@
21742169
"maxWords": ""
21752170
},
21762171
"key": "programDescription",
2177-
"conditional": {
2178-
"show": true,
2179-
"when": "programnotListed",
2180-
"eq": "true"
2181-
},
21822172
"type": "textarea",
21832173
"input": true,
21842174
"prefix": "",

sources/packages/forms/src/form-definitions/sfaa2023-24.json

-10
Original file line numberDiff line numberDiff line change
@@ -2093,11 +2093,6 @@
20932093
"pattern": ""
20942094
},
20952095
"key": "programName",
2096-
"conditional": {
2097-
"show": true,
2098-
"when": "programnotListed",
2099-
"eq": "true"
2100-
},
21012096
"type": "textfield",
21022097
"input": true,
21032098
"prefix": "",
@@ -2174,11 +2169,6 @@
21742169
"maxWords": ""
21752170
},
21762171
"key": "programDescription",
2177-
"conditional": {
2178-
"show": true,
2179-
"when": "programnotListed",
2180-
"eq": "true"
2181-
},
21822172
"type": "textarea",
21832173
"input": true,
21842174
"prefix": "",

sources/packages/forms/src/form-definitions/sfaa2024-25.json

-10
Original file line numberDiff line numberDiff line change
@@ -2093,11 +2093,6 @@
20932093
"pattern": ""
20942094
},
20952095
"key": "programName",
2096-
"conditional": {
2097-
"show": true,
2098-
"when": "programnotListed",
2099-
"eq": "true"
2100-
},
21012096
"type": "textfield",
21022097
"input": true,
21032098
"prefix": "",
@@ -2174,11 +2169,6 @@
21742169
"maxWords": ""
21752170
},
21762171
"key": "programDescription",
2177-
"conditional": {
2178-
"show": true,
2179-
"when": "programnotListed",
2180-
"eq": "true"
2181-
},
21822172
"type": "textarea",
21832173
"input": true,
21842174
"prefix": "",

0 commit comments

Comments
 (0)