Skip to content

Commit

Permalink
#3789 - PIR: Program Name and Program Description Bug (#3944)
Browse files Browse the repository at this point in the history 
**As a part of this PR, the bug for the PIR where the Program Name and
the Program Description are not showing up once the application is
submitted is fixed.**

**Fix:** The bug was happening because both the fields (Name and
Description) were having a conditional set as below:

```
"conditional": {
  "show": true,
  "when": "programnotListed",
  "eq": "true"
},
```

Removed the above piece of code for both the program name and program
description for all the program years.

The problem is that `programnotListed` never has the value `true`. It is
a `Select Boxes Component` rather than the `Checkbox Component` which
gets the value `programnotListed`. We do not need to rely on this
component because both the components `Program Name` and `Program
Description` are wrapped inside a container component that has a
conditional setup on it.

Tested the above for the below scenarios:

**1.  Program is not listed**

<img width="1025" alt="image"
src="https://github.com/user-attachments/assets/4e14f404-af5e-4306-b970-b7859cbce5a6">


-------------------------------------------------------------------------------------------------------------

**2.  Study is not listed**

<img width="944" alt="image"
src="https://github.com/user-attachments/assets/926615d5-6e12-4acb-888e-152be523c166">
  • Loading branch information
@sh16011993
sh16011993 authored Nov 15, 2024
1 parent cfd1a7e commit 35838a8
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 30 deletions.
10 changes: 0 additions & 10 deletions sources/packages/forms/src/form-definitions/sfaa2022-23.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2093,11 +2093,6 @@
"pattern": ""
},
"key": "programName",
"conditional": {
"show": true,
"when": "programnotListed",
"eq": "true"
},
"type": "textfield",
"input": true,
"prefix": "",
Expand Down Expand Up @@ -2174,11 +2169,6 @@
"maxWords": ""
},
"key": "programDescription",
"conditional": {
"show": true,
"when": "programnotListed",
"eq": "true"
},
"type": "textarea",
"input": true,
"prefix": "",
Expand Down
10 changes: 0 additions & 10 deletions sources/packages/forms/src/form-definitions/sfaa2023-24.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2093,11 +2093,6 @@
"pattern": ""
},
"key": "programName",
"conditional": {
"show": true,
"when": "programnotListed",
"eq": "true"
},
"type": "textfield",
"input": true,
"prefix": "",
Expand Down Expand Up @@ -2174,11 +2169,6 @@
"maxWords": ""
},
"key": "programDescription",
"conditional": {
"show": true,
"when": "programnotListed",
"eq": "true"
},
"type": "textarea",
"input": true,
"prefix": "",
Expand Down
10 changes: 0 additions & 10 deletions sources/packages/forms/src/form-definitions/sfaa2024-25.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2093,11 +2093,6 @@
"pattern": ""
},
"key": "programName",
"conditional": {
"show": true,
"when": "programnotListed",
"eq": "true"
},
"type": "textfield",
"input": true,
"prefix": "",
Expand Down Expand Up @@ -2174,11 +2169,6 @@
"maxWords": ""
},
"key": "programDescription",
"conditional": {
"show": true,
"when": "programnotListed",
"eq": "true"
},
"type": "textarea",
"input": true,
"prefix": "",
Expand Down

0 comments on commit 35838a8

Please sign in to comment.