Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3789 - PIR: Program Name and Program Description Bug #3944

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

sh16011993
Copy link
Collaborator

@sh16011993 sh16011993 commented Nov 15, 2024

As a part of this PR, the bug for the PIR where the Program Name and the Program Description are not showing up once the application is submitted is fixed.

Fix: The bug was happening because both the fields (Name and Description) were having a conditional set as below:

"conditional": {
  "show": true,
  "when": "programnotListed",
  "eq": "true"
},

Removed the above piece of code for both the program name and program description for all the program years.

The problem is that programnotListed never has the value true. It is a Select Boxes Component rather than the Checkbox Component which gets the value programnotListed. We do not need to rely on this component because both the components Program Name and Program Description are wrapped inside a container component that has a conditional setup on it.

Tested the above for the below scenarios:

1. Program is not listed

image

2. Study is not listed

image

@sh16011993 sh16011993 self-assigned this Nov 15, 2024
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.19% ( 3720 / 16761 )
Methods: 10.28% ( 214 / 2081 )
Lines: 25.54% ( 3228 / 12638 )
Branches: 13.61% ( 278 / 2042 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.91% ( 5777 / 8634 )
Methods: 64.65% ( 715 / 1106 )
Lines: 70.85% ( 4537 / 6404 )
Branches: 46.71% ( 525 / 1124 )

@sh16011993 sh16011993 added the Form.io Form IO definitions changed. label Nov 15, 2024
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.92% ( 1243 / 1430 )
Methods: 88.57% ( 124 / 140 )
Lines: 87.77% ( 1055 / 1202 )
Branches: 72.73% ( 64 / 88 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good 👍
Please ensure the demo will show both PIRs displaying the values 😉

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @sh16011993

@sh16011993 sh16011993 added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 35838a8 Nov 15, 2024
20 checks passed
@sh16011993 sh16011993 deleted the 3789_PIR_program_name_program_description_bug branch November 15, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Form.io Form IO definitions changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants