-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3789 - PIR: Program Name and Program Description Bug #3944
#3789 - PIR: Program Name and Program Description Bug #3944
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, looks good 👍
Please ensure the demo will show both PIRs displaying the values 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work @sh16011993
As a part of this PR, the bug for the PIR where the Program Name and the Program Description are not showing up once the application is submitted is fixed.
Fix: The bug was happening because both the fields (Name and Description) were having a conditional set as below:
Removed the above piece of code for both the program name and program description for all the program years.
The problem is that
programnotListed
never has the valuetrue
. It is aSelect Boxes Component
rather than theCheckbox Component
which gets the valueprogramnotListed
. We do not need to rely on this component because both the componentsProgram Name
andProgram Description
are wrapped inside a container component that has a conditional setup on it.Tested the above for the below scenarios:
1. Program is not listed
2. Study is not listed