Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3789 - Update the form IO conditions based on form data #3964

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

dheepak-aot
Copy link
Collaborator

@dheepak-aot dheepak-aot commented Nov 19, 2024

Updated the condition to render the program name and program description

  • Updated the condition to render the program name and program description fields only when a program is not selected in the student application(One of the PIR situation).
  • The input which says Your program is not listed is a select box and not check box. So we can use only custom condition to evaluate its output at it will be in an object form like this.
 "myProgramNotListed": {
      "programnotListed": false
    }

image

Formio condition updated to :
image

Updated the read only selected program and offering display

  • Updated the read only selected program and selected offering display only when the respective value is present.

Currently it is displaying as blank in PIR situations.

image

image

@dheepak-aot dheepak-aot added the Form.io Form IO definitions changed. label Nov 19, 2024
@dheepak-aot dheepak-aot self-assigned this Nov 19, 2024
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.1% ( 3718 / 16821 )
Methods: 10.19% ( 214 / 2100 )
Lines: 25.44% ( 3226 / 12680 )
Branches: 13.62% ( 278 / 2041 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.93% ( 1244 / 1431 )
Methods: 88.57% ( 124 / 140 )
Lines: 87.78% ( 1056 / 1203 )
Branches: 72.73% ( 64 / 88 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.96% ( 5773 / 8621 )
Methods: 64.8% ( 718 / 1108 )
Lines: 70.89% ( 4530 / 6390 )
Branches: 46.75% ( 525 / 1123 )

"when": null,
"eq": ""
},
"customConditional": "show = data.myProgramNotListed ? data.myProgramNotListed.programnotListed : false;",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the data.myProgramNotListed.programnotListed be converted to bool as

show = data.myProgramNotListed ? !!data.myProgramNotListed.programnotListed : false;

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data.myProgramNotListed.programnotListed is a boolean itself. Still do we require a conversion?

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juts a minor question, not a blocker hence approving it.

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work @dheepak-aot

@dheepak-aot dheepak-aot added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit 6002f6e Nov 19, 2024
20 checks passed
@dheepak-aot dheepak-aot deleted the fix/#3789-pir-no-program-listed branch November 19, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Form.io Form IO definitions changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants