-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3789 - Update the form IO conditions based on form data #3964
Conversation
Quality Gate passedIssues Measures |
"when": null, | ||
"eq": "" | ||
}, | ||
"customConditional": "show = data.myProgramNotListed ? data.myProgramNotListed.programnotListed : false;", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the data.myProgramNotListed.programnotListed
be converted to bool as
show = data.myProgramNotListed ? !!data.myProgramNotListed.programnotListed : false;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data.myProgramNotListed.programnotListed is a boolean itself. Still do we require a conversion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Juts a minor question, not a blocker hence approving it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nice work @dheepak-aot
Updated the condition to render the program name and program description
Your program is not listed
is aselect box
and not check box. So we can use only custom condition to evaluate its output at it will be in an object form like this.Formio condition updated to :
Updated the read only selected program and offering display
Currently it is displaying as blank in PIR situations.