Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request an Offering Change - Student View Request #1978

Closed
13 of 15 tasks
andrewsignori-aot opened this issue May 30, 2023 · 0 comments · Fixed by #2282
Closed
13 of 15 tasks

Request an Offering Change - Student View Request #1978

andrewsignori-aot opened this issue May 30, 2023 · 0 comments · Fixed by #2282
Assignees
@sh16011993
Labels
Student Student Features User Story
Milestone
2.0 Part-Time Stu...

Comments

@andrewsignori-aot
Copy link
Collaborator

andrewsignori-aot commented May 30, 2023 •
edited by sh16011993
Loading

Figma

Scenario

  • Student logs in and is prompted to "allow" or "decline" the change (on the app tracker)
  • If student allows, student prompted with SABC declaration (same declaration within app)
  • If student declines, request does not move forward to ministry

Acceptance Criteria

  • Add the view request link in requests and history assessment table which redirects to view request page.
  • On view request page, add a tab for "Requested change" and "Active application details" (note content).
  • Status icon needs to reflect the feature status.
  • Text under the Application Details and Request Details headings only need to be displayed when "In progress with student." They can be omitted after student approves or declines.
  • Reuse components used in the last tickets (Request an Offering Change - Submit/View UI #1954).
  • DO NOT show program costs to the students. [as per discussion with @JasonCTang , confirmed by business]
  • Display modal with SABC declaration when clicked in "Approve"
  • Approve modal must include the declaration for the student to sign again.
  • Need a migration to add the declaration field to the table.
  • Display modal with "Are you sure?" message when clicked in "Decline"
  • Add toast message for "allow" and "decline" -- "Your decision has been submitted successfully"
  • If the Ministry approves the change, the "Active application details" tab will be renamed to "Previous application details" in the view request page.
  • Redirect back to application tracker after submitting.
  • Remove buttons when student submitted a decision.
  • Create E2E test

Questions

  • Shouldn't it show some notes from the ministry to student/ministry explaining why the request was declined? Wouldn't the students call SABC to learn more about the decision? This does not need to be answered for this ticket to proceed right now

Related tickets
This was referenced Jun 6, 2023
Closed
Closed
Closed
Closed
Closed
@sh16011993 sh16011993 self-assigned this Jul 27, 2023
sh16011993 added a commit that referenced this issue Aug 16, 2023
@sh16011993
#1978 - Request an Offering Change: Student View Request
8707332
sh16011993 added a commit that referenced this issue Aug 31, 2023
@sh16011993
#1978 - Request an Offering Change: Student View Request (#2196)
231107b 
## **As a part of this PR, the follow tasks were completed:**

- [x] Added a view request link in requests and history assessment table
which redirects to view request page.
- [x] Added the logic to the "Review changes" button to redirect to the
view request page.
- [x] On the view request page, added tabs for "Requested change" and
"Active application details".
- [x] Added migration scripts to add `student_consent` column in the
`application_offering_change_requests` relation in the database.
- [x] Created modal with SABC declaration when "Allow change" is
clicked.
- [x] Created modal to decline the application offering change request
when "Decline change" is clicked.
- [x] Created migration scripts to add the declaration attribute to the
application offering change request entity.
- [x] Added toast message for "allow" and "decline" scenarios -- "Your
decision has been submitted successfully".
- [x] Renamed the "Active application details" tab to "Previous
application details" in the view request page when the ministry approves
the application offering change request.
- [x] Enabled the route redirection back to the application tracker
after the student submits the application offering change request.
- [x] Removed the "Decline change" and "Allow change" buttons when
student submits the application offering change request decision.
- [x] The logic for the below scenarios was adjusted:
1. Text under the "Application Details" and "Request Details" headings
is only displayed when the application offering change request is "In
progress with student."
        2. Program costs are not shown for the students.
        3. Status next to the student name reflects the feature status.

# **Screenshots**

### View Request Link in the Requests and History Tables
<img width="1918" alt="image"
src="https://github.com/bcgov/SIMS/assets/7859295/f9ee51f9-ac00-4877-b3c5-3540ed7b670e">

### "Requested change" tab
<img width="1917" alt="image"
src="https://github.com/bcgov/SIMS/assets/7859295/e1910580-d2fa-4b09-af3d-9a49fe7b75ed">

### "Active application details" tab
<img width="1917" alt="image"
src="https://github.com/bcgov/SIMS/assets/7859295/0bf67b82-13c1-4785-b85b-b6db234db69f">

### Decline Application Offering Change Request Modal
<img width="1916" alt="image"
src="https://github.com/bcgov/SIMS/assets/7859295/2587e3c9-e3c2-450c-8fc0-88836cee5e3c">

### Approve Application Offering Change Request Modal
<img width="1914" alt="image"
src="https://github.com/bcgov/SIMS/assets/7859295/67fce378-90d5-441d-a3d3-833c848e9e97">

### Application Offering Change Request in progress with SABC
<img width="1916" alt="image"
src="https://github.com/bcgov/SIMS/assets/7859295/4ea29b39-8e9e-4d12-bde6-d3641b7c49cc">

### Application Offering Change Request Approved by SABC
<img width="1914" alt="image"
src="https://github.com/bcgov/SIMS/assets/7859295/60ccff31-e20a-4e54-9189-7077facc8605">

### Validation Error in the Approve Application Modal Dialog when the
student consent is not given
<img width="1917" alt="image"
src="https://github.com/bcgov/SIMS/assets/7859295/a43c60d0-7929-424f-8a1b-fffb3b51768a">

### **Note:**
As per discussion with the team, I have not created a common component
for the two tabs: "Requested details" and "Active application details".

##
**Next PR:**
- [ ]  **e2e tests**
sh16011993 added a commit that referenced this issue Aug 31, 2023
@sh16011993
#1978 - Request an Offering Change: Student View Request - e2e tests …
ba537ab 
…(Part 2)
sh16011993 added a commit that referenced this issue Sep 7, 2023
@sh16011993
#1978 - Request an Offering Change: Student View Request - e2e tests …
9050fef 
…(Part 2) (#2240)

As a part of this PR, the following task was completed

- [x] The below test cases were written for the controller
`ApplicationOfferingChangeRequestStudentsController` and controller
`EducationProgramOfferingStudentsController` endpoints:

- `getApplicationOfferingChangeRequest`
√ Should return the application offering change request details when
provided with the application offering change request id.
√ Should throw a HttpStatus Not Found (404) when the application
offering change request is not associated with the authenticated
student.

- `getApplicationOfferingChangeRequestStatus`
√ Should return the application offering change request status when
provided with the application offering change request id.
√ Should throw a HttpStatus Not Found (404) when the application
offering status change request is not associated with the authenticated
student.

- `updateApplicationOfferingChangeRequest`
√ Should update the application offering change request status for the
provided application offering change request id.
√ Should throw a HttpStatus Not Found (404) error when an application
offering change update is requested for an application not in completed
state.
√ Should throw a HttpStatus Not Found (404) error when an application
offering change is not associated with the authenticated student.
√ Should throw a HttpStatus Not Found (404) error when an application
offering change is not in a valid status to be updated.
√ Should throw a HttpStatus Unprocessable Entity (422) error when an
invalid application offering change request is made.
√ Should throw a HttpStatus Unprocessable Entity (422) error when
student consent is not provided.

- `getOfferingSummaryDetails`
√ Should get the offering simplified details, not including the
validations, approvals and extensive data when the provided purpose is
application-offering-change.
√ Should throw the Not Found (404) exception when the student is not
authorized for the provided offering.
√ Should throw the Not Found (404) exception when the offering summary
purpose is not provided.
sh16011993 added a commit that referenced this issue Sep 8, 2023
@sh16011993
#1978 - Request Offering Change - Student Portal (Patch fix)
21e08d9 
The following two scenarios are fixed:
1) Approve application offering change request through the application offering change request dialog.
2)  Text under the Application Details and Request Details headings is only displayed when "In progress with student." They are omitted after the student approves or declines.
@sh16011993 sh16011993 linked a pull request Sep 8, 2023 that will close this issue
#1978 - Request Offering Change - Student View Request (Bug fix) #2282
Merged
sh16011993 added a commit that referenced this issue Sep 8, 2023
@sh16011993
#1978 - Request Offering Change - Student View Request (Bug fix) (#2282)
28fe367 
The following two scenarios are fixed:

- **Problem:** Application Offering Change Request Status was not sent
in payload.
**Fix:** Application Offering Change Request Status is being set to
`InProgressWithSABC` in the payload.

- **Problem:** Text under the Application Details and Request Details
headings was only omitted when the application offering change request
was approved by the ministry.
**Fix** As per the requirement, text under the Application Details and
Request Details headings is only displayed when "In progress with
student." They are omitted after the student approves or declines.
@sh16011993 sh16011993 reopened this Sep 8, 2023
@michesmith michesmith added this to the 2.0 Part-Time Students MVP milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sh16011993 sh16011993

Labels
Student Student Features User Story
Projects
None yet
Milestone
2.0 Part-Time Students MVP
Development

Successfully merging a pull request may close this issue.

#1978 - Request Offering Change - Student View Request (Bug fix) bcgov/SIMS
4 participants
@sh16011993 @andrewsignori-aot @JasonCTang @michesmith