Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1978 - Request Offering Change - Student View Request (Bug fix) #2282

Merged

Conversation

sh16011993
Copy link
Collaborator

@sh16011993 sh16011993 commented Sep 8, 2023

The following two scenarios are fixed:

  • Problem: Application Offering Change Request Status was not sent in payload.
    Fix: Application Offering Change Request Status is being set to InProgressWithSABC in the payload.

  • Problem: Text under the Application Details and Request Details headings was only omitted when the application offering change request was approved by the ministry.
    Fix As per the requirement, text under the Application Details and Request Details headings is only displayed when "In progress with student." They are omitted after the student approves or declines.

The following two scenarios are fixed:
1) Approve application offering change request through the application offering change request dialog.
2)  Text under the Application Details and Request Details headings is only displayed when "In progress with student." They are omitted after the student approves or declines.
@sh16011993 sh16011993 self-assigned this Sep 8, 2023
@sh16011993 sh16011993 linked an issue Sep 8, 2023 that may be closed by this pull request
15 tasks
const cancel = () => {
approveApplicationOfferingChangeRequest.value.reset();
formModel.studentConsent = false;
approveApplicationOfferingChangeRequestModal.value.studentConsent = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the reset above not taking care of it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my understanding, the reset is not working on the checkbox component. I tried by removing the line 74 but in that case the reset fails.

const cancel = () => {
approveApplicationOfferingChangeRequest.value.reset();
formModel.studentConsent = false;
approveApplicationOfferingChangeRequestModal.value.studentConsent = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you double-check if the line 73 reset is working and if we need this reset?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. The reset was redundant. Removed it 👍

@@ -80,17 +80,17 @@ export default defineComponent({
Location: changeRequest.value.locationName,
} as Record<string, string>),
);
const changeRequestNotApproved = computed(() => {
const changeRequestInProgressWithStudent = computed(() => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my clarification because I was not part of previous reviews, I can see on Figma that these texts are not displayed for "Approved" status. Why are we showing them only for InProgressWithStudent? Are they not supposed to be hidden only for Approved ones?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the story AC, the requirement is that the "Text under the Application Details and Request Details headings only need to be displayed when "In progress with student." They can be omitted after student approves or declines."

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, minor comments only.

@sh16011993 sh16011993 added Bug Something isn't working and removed task-patch-fix labels Sep 8, 2023
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please have a look on the model reset mentioned by other devs comments

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor comment

@@ -86,7 +82,7 @@ export default defineComponent({
}
approveApplicationOfferingChangeRequestModal.value.applicationOfferingChangeRequestStatus =
ApplicationOfferingChangeRequestStatus.InProgressWithSABC;
const payload = { ...formModel };
const payload = { ...approveApplicationOfferingChangeRequestModal.value };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

const cancel = () => {
approveApplicationOfferingChangeRequest.value.reset();
formModel.studentConsent = false;
approveApplicationOfferingChangeRequestModal.value.studentConsent = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a point, to mention, but not a blocker. do we need a model for just one property coming from form ? As the code is part of previous PR not stressing it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used a model to keep it in sync with how we are doing it in other places.

@dheepak-aot
Copy link
Collaborator

Just a minor comment.

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good 👍

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Approving as my comment is not a blocker.

@sh16011993 sh16011993 changed the title #1978 - Request Offering Change - Student View Request (Patch fix) #1978 - Request Offering Change - Student View Request (Bug fix) Sep 8, 2023
@@ -69,12 +69,8 @@ export default defineComponent({
{} as StudentApplicationOfferingChangeRequestAPIInDTO,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other modals, we use reactive for form data objects

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes and nice catch 👍

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.63% ( 2183 / 12383 )
Methods: 8.05% ( 126 / 1565 )
Lines: 20.46% ( 1919 / 9380 )
Branches: 9.6% ( 138 / 1438 )

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 46.73% ( 300 / 642 )
Methods: 40% ( 32 / 80 )
Lines: 51.02% ( 251 / 492 )
Branches: 24.29% ( 17 / 70 )

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 72.5% ( 406 / 560 )
Methods: 63.38% ( 45 / 71 )
Lines: 74.53% ( 357 / 479 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 54.26% ( 4004 / 7379 )
Methods: 51.15% ( 488 / 954 )
Lines: 59.12% ( 3254 / 5504 )
Branches: 28.45% ( 262 / 921 )

@sh16011993 sh16011993 merged commit 28fe367 into main Sep 8, 2023
@sh16011993 sh16011993 deleted the 1978_request_offering_change_student_view_request_patch_fix branch September 8, 2023 21:12
@sh16011993 sh16011993 temporarily deployed to DEV September 8, 2023 21:21 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV September 8, 2023 21:22 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV September 8, 2023 21:22 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV September 8, 2023 21:22 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV September 8, 2023 21:22 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV September 8, 2023 21:24 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV September 8, 2023 21:24 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request an Offering Change - Student View Request
6 participants