#1978 - Request Offering Change - Student View Request (Bug fix) #2282
Conversation
The following two scenarios are fixed: 1) Approve application offering change request through the application offering change request dialog. 2) Text under the Application Details and Request Details headings is only displayed when "In progress with student." They are omitted after the student approves or declines.
sh16011993
requested review from
andrepestana-aot,
andrewsignori-aot,
dheepak-aot,
guru-aot,
ann-aot and
JasonCTang
and removed request for
JasonCTang
| const cancel = () => { | ||
| approveApplicationOfferingChangeRequest.value.reset(); | ||
| formModel.studentConsent = false; | ||
| approveApplicationOfferingChangeRequestModal.value.studentConsent = false; |
There was a problem hiding this comment.
Is the reset above not taking care of it?
There was a problem hiding this comment.
In my understanding, the reset is not working on the checkbox component. I tried by removing the line 74 but in that case the reset fails.
| const cancel = () => { | ||
| approveApplicationOfferingChangeRequest.value.reset(); | ||
| formModel.studentConsent = false; | ||
| approveApplicationOfferingChangeRequestModal.value.studentConsent = false; |
There was a problem hiding this comment.
can you double-check if the line 73 reset is working and if we need this reset?
There was a problem hiding this comment.
Correct. The reset was redundant. Removed it 👍
| @@ -80,17 +80,17 @@ export default defineComponent({ | |||
| Location: changeRequest.value.locationName, | |||
| } as Record<string, string>), | |||
| ); | |||
| const changeRequestNotApproved = computed(() => { | |||
| const changeRequestInProgressWithStudent = computed(() => { | |||
There was a problem hiding this comment.
Just for my clarification because I was not part of previous reviews, I can see on Figma that these texts are not displayed for "Approved" status. Why are we showing them only for InProgressWithStudent? Are they not supposed to be hidden only for Approved ones?
There was a problem hiding this comment.
In the story AC, the requirement is that the "Text under the Application Details and Request Details headings only need to be displayed when "In progress with student." They can be omitted after student approves or declines."
| @@ -86,7 +82,7 @@ export default defineComponent({ | |||
| } | |||
| approveApplicationOfferingChangeRequestModal.value.applicationOfferingChangeRequestStatus = | |||
| ApplicationOfferingChangeRequestStatus.InProgressWithSABC; | |||
| const payload = { ...formModel }; | |||
| const payload = { ...approveApplicationOfferingChangeRequestModal.value }; | |||
| const cancel = () => { | ||
| approveApplicationOfferingChangeRequest.value.reset(); | ||
| formModel.studentConsent = false; | ||
| approveApplicationOfferingChangeRequestModal.value.studentConsent = false; |
There was a problem hiding this comment.
I have a point, to mention, but not a blocker. do we need a model for just one property coming from form ? As the code is part of previous PR not stressing it.
There was a problem hiding this comment.
I used a model to keep it in sync with how we are doing it in other places.
|
Just a minor comment. |
sh16011993
changed the title
| @@ -69,12 +69,8 @@ export default defineComponent({ | |||
| {} as StudentApplicationOfferingChangeRequestAPIInDTO, | |||
There was a problem hiding this comment.
In other modals, we use reactive for form data objects
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
sh16011993
deleted the
1978_request_offering_change_student_view_request_patch_fix
branch
The following two scenarios are fixed:
Problem: Application Offering Change Request Status was not sent in payload.
Fix: Application Offering Change Request Status is being set to
InProgressWithSABCin the payload.Problem: Text under the Application Details and Request Details headings was only omitted when the application offering change request was approved by the ministry.
Fix As per the requirement, text under the Application Details and Request Details headings is only displayed when "In progress with student." They are omitted after the student approves or declines.