Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1978 - Request an Offering Change: Student View Request #2196

Merged
merged 33 commits into from
Aug 31, 2023
Merged

#1978 - Request an Offering Change: Student View Request #2196

merged 33 commits into from
Aug 31, 2023

Conversation

sh16011993
Copy link
Collaborator

@sh16011993 sh16011993 commented Aug 16, 2023 •
edited
Loading

As a part of this PR, the follow tasks were completed:

  • Added a view request link in requests and history assessment table which redirects to view request page.
  • Added the logic to the "Review changes" button to redirect to the view request page.
  • On the view request page, added tabs for "Requested change" and "Active application details".
  • Added migration scripts to add student_consent column in the application_offering_change_requests relation in the database.
  • Created modal with SABC declaration when "Allow change" is clicked.
  • Created modal to decline the application offering change request when "Decline change" is clicked.
  • Created migration scripts to add the declaration attribute to the application offering change request entity.
  • Added toast message for "allow" and "decline" scenarios -- "Your decision has been submitted successfully".
  • Renamed the "Active application details" tab to "Previous application details" in the view request page when the ministry approves the application offering change request.
  • Enabled the route redirection back to the application tracker after the student submits the application offering change request.
  • Removed the "Decline change" and "Allow change" buttons when student submits the application offering change request decision.
  • The logic for the below scenarios was adjusted:
    1. Text under the "Application Details" and "Request Details" headings is only displayed when the application offering change request is "In progress with student."
    2. Program costs are not shown for the students.
    3. Status next to the student name reflects the feature status.

Screenshots

View Request Link in the Requests and History Tables

image

"Requested change" tab

image

"Active application details" tab

image

Decline Application Offering Change Request Modal

image

Approve Application Offering Change Request Modal

image

Application Offering Change Request in progress with SABC

image

Application Offering Change Request Approved by SABC

image

Validation Error in the Approve Application Modal Dialog when the student consent is not given

image

Note:

As per discussion with the team, I have not created a common component for the two tabs: "Requested details" and "Active application details".

Next PR:

  • e2e tests

@sh16011993 sh16011993 self-assigned this Aug 16, 2023
@sh16011993 sh16011993 added Web Portal SIMS-Api SIMS-Api DB DB migration involved labels Aug 16, 2023
dheepak-aot
dheepak-aot reviewed Aug 31, 2023
View reviewed changes
...ers/application-offering-change-request/models/application-offering-change-request.models.ts Outdated
@@ -0,0 +1,6 @@
import { ApplicationOfferingChangeRequestStatus } from "@sims/sims-db";

export interface StudentApplicationOfferingChangeRequest {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need it?

@dheepak-aot
Copy link
Collaborator

Thanks for doing the changes. Added few more comments..

ann-aot
ann-aot reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 added some minor comments

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.97% ( 2174 / 12100 )
Methods: 8.18% ( 126 / 1541 )
Lines: 20.84% ( 1910 / 9166 )
Branches: 9.91% ( 138 / 1393 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 48.99% ( 268 / 547 )
Methods: 40.51% ( 32 / 79 )
Lines: 54.34% ( 219 / 403 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 72.5% ( 406 / 560 )
Methods: 63.38% ( 45 / 71 )
Lines: 74.53% ( 357 / 479 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 53.27% ( 3931 / 7379 )
Methods: 49.48% ( 472 / 954 )
Lines: 58.32% ( 3210 / 5504 )
Branches: 27.04% ( 249 / 921 )

dheepak-aot
dheepak-aot approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes. 👍

andrepestana-aot
andrepestana-aot approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ann-aot
ann-aot approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes 👍

@sh16011993 sh16011993 merged commit 231107b into main Aug 31, 2023
@sh16011993 sh16011993 temporarily deployed to DEV August 31, 2023 21:43 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV August 31, 2023 21:56 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV August 31, 2023 21:56 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV August 31, 2023 21:56 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV August 31, 2023 21:56 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV August 31, 2023 22:01 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV August 31, 2023 22:01 — with GitHub Actions Inactive
@sh16011993 sh16011993 deleted the 1978_request_offering_change_student_view_request branch August 31, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guru-aot guru-aot guru-aot left review comments

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@sh16011993 sh16011993

Labels
DB DB migration involved SIMS-Api SIMS-Api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sh16011993 @dheepak-aot @guru-aot @ann-aot @andrepestana-aot @JasonCTang