#1978 - Request an Offering Change: Student View Request - e2e tests (Part 2) #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh16011993
requested review from
dheepak-aot,
andrewsignori-aot,
guru-aot,
ann-aot,
andrepestana-aot and
JasonCTang
ann-aot
reviewed
Aug 31, 2023
...-offering-change-request.students.controller.getApplicationOfferingChangeRequest.e2e-spec.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
Aug 31, 2023
...-offering-change-request.students.controller.getApplicationOfferingChangeRequest.e2e-spec.ts
Show resolved
Hide resolved
ann-aot
reviewed
Aug 31, 2023
...-offering-change-request.students.controller.getApplicationOfferingChangeRequest.e2e-spec.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
Aug 31, 2023
...-offering-change-request.students.controller.getApplicationOfferingChangeRequest.e2e-spec.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
Aug 31, 2023
...ing-change-request.students.controller.getApplicationOfferingChangeRequestStatus.e2e-spec.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
Sep 1, 2023
...fering-change-request.students.controller.updateApplicationOfferingChangeRequest.e2e-spec.ts
Show resolved
Hide resolved
ann-aot
reviewed
Sep 1, 2023
|
@sh16011993 didn't we include e2e test for the offering controller that we added? |
...fering-change-request.students.controller.updateApplicationOfferingChangeRequest.e2e-spec.ts
Show resolved
Hide resolved
...fering-change-request.students.controller.updateApplicationOfferingChangeRequest.e2e-spec.ts
Outdated
Show resolved
Hide resolved
I missed it @dheepak-aot . Thanks for pointing it out. I will add it. |
dheepak-aot
reviewed
Sep 5, 2023
| @@ -115,7 +115,7 @@ export class ApplicationOfferingChangeRequestStudentsController extends BaseCont | |||
| description: | |||
| "Invalid application offering change status or student consent not provided", | |||
| }) | |||
| async updateApplicationOfferingChangeRequestStatus( | |||
| async updateApplicationOfferingChangeRequest( | |||
| let applicationRepo: Repository<Application>; | ||
| let assessmentRepo: Repository<StudentAssessment>; | ||
|
|
||
| const deliveryMethod = (offering: EducationProgramOffering) => { |
There was a problem hiding this comment.
I believe that usually, we keep the helper method at the end of the file. If it is something to be reused outside this file it an be moved to a different file/util.
andrewsignori-aot
approved these changes
Sep 7, 2023
guru-aot
approved these changes
Sep 7, 2023
ann-aot
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
LGTM @sh16011993 . thanks for doing the changes and fixing the memory issue in the PR
| await app?.close(); | ||
| }); | ||
|
|
||
| const deliveryMethod = (offering: EducationProgramOffering) => { |
There was a problem hiding this comment.
can be simplified:
andrepestana-aot
approved these changes
Sep 7, 2023
dheepak-aot
reviewed
Sep 7, 2023
Comment on lines
48
to
62
| const savedUser = await db.user.save(createFakeUser()); | ||
| const fakeOffering = createFakeEducationProgramOffering({ | ||
| auditUser: savedUser, | ||
| }); | ||
| const offering = await db.educationProgramOffering.save(fakeOffering); | ||
| const fakeApplication = createFakeApplication({ student }); | ||
| const application = await applicationRepo.save(fakeApplication); | ||
| const fakeAssessment = createFakeStudentAssessment({ | ||
| auditUser: savedUser, | ||
| application, | ||
| offering, | ||
| }); | ||
| fakeApplication.currentAssessment = fakeAssessment; | ||
| await applicationRepo.save(fakeApplication); | ||
| await assessmentRepo.save(fakeAssessment); |
There was a problem hiding this comment.
We could have used the saveFakeApplication with student and it would have replaced all the code here right?
I am not going to call it a blocker but to keep in mind for upcoming e2es.
There was a problem hiding this comment.
I have made the changes @dheepak-aot . Thanks for pointing it out. 👍
dheepak-aot
reviewed
Sep 7, 2023
|
|
||
| it("Should throw the Not Found (404) exception when the offering summary purpose is not provided.", async () => { | ||
| // Arrange | ||
| const savedUser = await db.user.save(createFakeUser()); |
There was a problem hiding this comment.
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
approved these changes
Sep 7, 2023
sh16011993
deleted the
1978_request_offering_change_student_view_request_e2e_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of this PR, the following task was completed
The below test cases were written for the controller
ApplicationOfferingChangeRequestStudentsControllerand controllerEducationProgramOfferingStudentsControllerendpoints:getApplicationOfferingChangeRequest√ Should return the application offering change request details when provided with the application offering change request id.
√ Should throw a HttpStatus Not Found (404) when the application offering change request is not associated with the authenticated student.
getApplicationOfferingChangeRequestStatus√ Should return the application offering change request status when provided with the application offering change request id.
√ Should throw a HttpStatus Not Found (404) when the application offering status change request is not associated with the authenticated student.
updateApplicationOfferingChangeRequest√ Should update the application offering change request status for the provided application offering change request id.
√ Should throw a HttpStatus Not Found (404) error when an application offering change update is requested for an application not in completed state.
√ Should throw a HttpStatus Not Found (404) error when an application offering change is not associated with the authenticated student.
√ Should throw a HttpStatus Not Found (404) error when an application offering change is not in a valid status to be updated.
√ Should throw a HttpStatus Unprocessable Entity (422) error when an invalid application offering change request is made.
√ Should throw a HttpStatus Unprocessable Entity (422) error when student consent is not provided.
getOfferingSummaryDetails√ Should get the offering simplified details, not including the validations, approvals and extensive data when the provided purpose is application-offering-change.
√ Should throw the Not Found (404) exception when the student is not authorized for the provided offering.
√ Should throw the Not Found (404) exception when the offering summary purpose is not provided.
Note
Increased memory heap size to 12288 MB to fix the "heap limit allocation failed - JavaScript heap out of memory" error.