Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request an Offering Change - Submit/View UI #1954

Closed
6 tasks done
andrewsignori-aot opened this issue May 19, 2023 · 1 comment
Closed
6 tasks done

Request an Offering Change - Submit/View UI #1954

andrewsignori-aot opened this issue May 19, 2023 · 1 comment
Assignees
@andrewsignori-aot
Labels
Institution Institution Features User Story
Milestone
2.0 Part-Time Stu...

Comments

@andrewsignori-aot
Copy link
Collaborator

andrewsignori-aot commented May 19, 2023 •
edited
Loading

Figma

Acceptance Criteria

  • View as a common component to be used for submit/view and also the subcomponent to display the read-only data (to be also consumed by the student).
  • Create common vue component for the program and offering program details. This is similar to the existing PIR Form.io form and will replace the PIR form in the future;
  • Only allow a request to change can be submitted for applications in "Available to Change" (If two users start filling in the request for change form at the same time and try to submit, only the first submission will be accepted. The subsequent one will fail as long as the first one is stil in progress.)
  • Request should be created with status "In progress with student";
  • Validations:
    • All fields are mandatory;
  • Show notes from SABC input only when declined or approved by Ministry staff.
This was referenced Jun 6, 2023
Closed
Closed
Closed
Closed
Closed
@andrewsignori-aot andrewsignori-aot self-assigned this Jul 4, 2023
andrewsignori-aot added a commit that referenced this issue Jul 13, 2023
@andrewsignori-aot
#1954 - Request an Offering Change - Submit/View UI (Part 1) (#2105)
8192320 
- Added a new endpoint to submit the request.
- Added new endpoint to get the request details submitted:
`@Get(":applicationOfferingChangeRequestId")`
- Reused methods to load programs and offerings from PIR.
- Created a component to display an offering summary to be used for the
student offering change and with the potential to be used for scholastic
standings and COE approvals.
- Created a component to submit the requested change and visualize it.
- Method `getEligibleApplications` was reused to also retrieve the
"change request"/"application details" to allow the submission. In this
way, the same query constraints are used to load the summary list and
also to get more details for the same item that will be submitted. New
endpoint added as `@Get("available/application/:applicationId")`.

### Fixes and UI refactors
- Fixed query for available applications that was showing the
application available to report a change when there was one already in
progress and also completed.
- Removed extra space from `detail-header` after the label. Instead of
showing `label : value` it will now show `label: value`.
- Replace the "vertical divider" in `detail-header` with a pipe ("|") as
per Figma.
- Fixed the `body-header` `#status-chip` that was being displayed in the
second line.
@andrewsignori-aot andrewsignori-aot mentioned this issue Jul 14, 2023
Closed
5 tasks
@andrewsignori-aot
Copy link
Collaborator Author

PIR validation acceptance criteria and E2E tests moved to #2116.
@JasonCTang FYI

@michesmith michesmith added this to the 2.3 Student Start and Manage Financial Aid Application milestone Mar 12, 2024
@michesmith michesmith added this to the 2.0 Part-Time Students MVP milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewsignori-aot andrewsignori-aot

Labels
Institution Institution Features User Story
Projects
None yet
Milestone
2.0 Part-Time Students MVP
Development

No branches or pull requests
3 participants
@andrewsignori-aot @JasonCTang @michesmith