Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalise for release 6.1 #520

Merged
merged 29 commits into from
Aug 24, 2023
Merged

Finalise for release 6.1 #520

merged 29 commits into from
Aug 24, 2023

Conversation

teddychao
Copy link
Contributor

@teddychao teddychao commented Aug 18, 2023

General

  • Minimum version of MATLAB
  • Entering PsPM
    • Entering PsPM is now hybrid based on the version of MATLAB, namely through AppDesigner or Guide. PsPM will be entered through AppDesigner when supported and through Guide for older versions of MATLAB. To call PsPM, users should still use the command pspm in the Command Window of MATLAB, where the appropriate way of entering PsPM will be recognised automatically.
    • Users can still use their preferred way to enter PsPM. To enter PsPM through AppDesigner, please type pspm_appdesigner. To enter PsPM through Guide, which is the classic entrance, please type pspm_guide.
    • The AppDesigner version of PsPM UI is newly introduced by MATLAB and the encouraged way for launching PsPM, and it has no functionality difference than the Guide version of PsPM UI.
    • Both AppDesigner and Guide are designed and tested for Windows, macOS (either Intel or Apple Silicon) and Linux. Issues of opening PsPM through either of the two UI systems are encouraged to be reported to PsPM developing group at GitHub.
  • Introducing pspm_options (Streamline options input between functions #385, Option values for pspm_dcm, pspm_dcm_inv and pspm_get_rf #426, The initial values of channel for some functions #430)
    • A new function pspm_options is introduced to PsPM for controlling the default and acceptable values of the struct options used by most PsPM functions. The default values of the fields in the struct options for various functions can be directly checked by searching in pspm_options.
    • The default values in pspm_options have been checked and tested for PsPM. If preferred values are different from defaults, users can specify them when calling the corresponding PsPM functions, and the corresponding functions and pspm_options will always respect the users' specification with the highest priority. However, the user's specification needs to satisfy the condition set in pspm_options, and invalid values may be reported as errors.
  • UI Improvements (Fix pspm_display and heart beat detection #488)
    • The UI for the following features has been improved and tested
      • Launchpad (AppDesigner)
      • Launchpad (Guide)
      • Batch editor
      • Display data
      • Contrast manager
  • Help text

Bug Fixes

Improvements

Minor Adjustments

Reference document

  • New document PsPM Reference for checking the default values and restrictions of options fields (Manual updates #432).

User-interface improvement

Launchpad, AppDesigner

Mac
Mac
Windows
Windows

Launchpad, Guide

Mac
image
Windows
image

Batch Editor

Mac
image
Windows
image

Display

Mac
image
Windows
image

Contrast Manager

Mac
image
Windows
image

@teddychao teddychao linked an issue Aug 18, 2023 that may be closed by this pull request
@dominikbach
Copy link
Contributor

dominikbach commented Aug 18, 2023

some last fixes in pull request 522

@teddychao teddychao self-assigned this Aug 20, 2023
@teddychao teddychao added the In Progress Currently being worked on label Aug 20, 2023
@teddychao teddychao marked this pull request as ready for review August 22, 2023 15:46
@teddychao teddychao added Completed & Waiting for Review Completed and waiting for review and removed In Progress Currently being worked on labels Aug 22, 2023
@teddychao teddychao added this to the v6.1 milestone Aug 22, 2023
@teddychao
Copy link
Contributor Author

Hi @uzaygokay I noticed pspm_display was not working very well when you visualise the PPG data. Please check this version if you are interested to see if it gets improved data and metadata display. Thanks

@teddychao teddychao merged commit ccbf3c8 into develop Aug 24, 2023
1 check passed
@teddychao teddychao deleted the 448-release-pspm-version-61 branch August 24, 2023 03:01
@teddychao teddychao removed the Completed & Waiting for Review Completed and waiting for review label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release PsPM version 6.1
2 participants