Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different use of the keyword lr for eyes observed or signals #479

Closed
teddychao opened this issue Apr 3, 2023 · 1 comment
Closed

Different use of the keyword lr for eyes observed or signals #479

teddychao opened this issue Apr 3, 2023 · 1 comment
Assignees
@teddychao
Milestone
v6.1

Comments

@teddychao
Copy link
Contributor

Summary

Some code annotations, or potentially code as well, are using the keyword lr instead of c to refer to the combined left and right channels. This is not expected as we need to keep such keywords consistent. Please check the functions such as pspm_gaze_pp and make sure they have been consistent to the latest version keyword c.
@teddychao teddychao self-assigned this Apr 3, 2023
@teddychao teddychao added the Improvement A minor improvement to the project label Apr 3, 2023
@teddychao teddychao added this to the v6.1 milestone Apr 3, 2023
@teddychao teddychao changed the title Legacy use of the keyword lr Different use of the keyword lr for eyes observed or signals Apr 24, 2023
@teddychao
Copy link
Contributor Author

This issue has been recently fixed by introducing eye markers in settings. Please see #510

@teddychao teddychao added Solved and removed Improvement A minor improvement to the project labels Aug 20, 2023
@teddychao teddychao mentioned this issue Aug 21, 2023
Merged
@teddychao teddychao removed the Solved label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teddychao teddychao

Labels
None yet
Projects
None yet
Milestone
v6.1
Development

No branches or pull requests
1 participant
@teddychao