Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pspm_dcm incorrectly assign first value of dcm.stats to be always NaN #504

Closed
teddychao opened this issue Jul 24, 2023 · 3 comments
Closed
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@teddychao
Copy link
Contributor

Summary

Users have reported that pspm_dcm incorrectly assign first value of dcm.stats to be always NaN in the latest develop branch at the moment. This is suspected caused by the incorrect calculation of proc_subsessions in pspm_dcm, but relevant processing in pspm_dcm_inv may be also relevant. This is a critical issue and should be resolved asap.

@teddychao teddychao self-assigned this Jul 24, 2023
@teddychao teddychao added this to the v6.1 milestone Jul 24, 2023
@dominikbach
Copy link
Contributor

The underlying cause is that trials statistics are excluded when there is any NaN data between trial start and trial end (around line 565). This should be changed - users would normally expect that when the NaN data are below the subsession threshold then the trial statistics are reported. This is an improvement, rather than a bug.

@dominikbach dominikbach modified the milestones: v6.1, v6.2 Aug 14, 2023
@dominikbach dominikbach added the Improvement A minor improvement to the project label Aug 14, 2023
@dominikbach
Copy link
Contributor

dominikbach commented Aug 18, 2023

Actually, the problem the user reported is down to an indexing issue - it also happens with no missing data; so it's a bug. changed milestone to 6.1 accordingly.

@dominikbach dominikbach modified the milestones: v6.2, v6.1 Aug 18, 2023
@dominikbach dominikbach assigned dominikbach and unassigned teddychao Aug 18, 2023
@dominikbach dominikbach added Bug Something isn't working and removed Improvement A minor improvement to the project labels Aug 18, 2023
@teddychao teddychao modified the milestones: v6.1, v6.2 Aug 20, 2023
@dominikbach
Copy link
Contributor

Has been fixed in 6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants