Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pspm_glm produce no results when facing many short missing epochs #338

Closed
teddychao opened this issue Dec 13, 2021 · 1 comment · Fixed by #339 or #464
Closed

pspm_glm produce no results when facing many short missing epochs #338

teddychao opened this issue Dec 13, 2021 · 1 comment · Fixed by #339 or #464
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@teddychao
Copy link
Contributor

Summary

pspm_glm provides statistics for processed signals and missing epochs. When facing many small pieces of missing epochs, pspm_glm removes all the presenting data and produces no results.

Steps to Reproduce

  1. Build a missing_epochs file that contains many small pieces of missing epochs.
  2. Process data and missing_epochs with pspm_glm.

Expected Results

Statistics are provided for non missing epoch data.

Actual Results

Statistics are not provided as all data are treated as missing epochs and removed.

(Optional) Possible Cause and Solutions

Potentially, the different sampling rate leads to a downsampling step that makes missing epochs cover all the data unexpectedly.

Technical Info

  • PsPM version: 5.1.2
  • MATLAB version: 2021b
@teddychao teddychao self-assigned this Dec 13, 2021
@teddychao teddychao added the Bug Something isn't working label Dec 13, 2021
@teddychao teddychao added this to the v5.1.2 milestone Dec 13, 2021
@teddychao
Copy link
Contributor Author

The current solution is:

  1. Track the sampling rates used in pspm_glm.
  2. Propose a warning when the filtered data after removing missing epochs is less than 90%.
  3. Use the information of step 1 to explain the warning of step 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant