Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pspm_interp1 needs to consider data without valid values #500

Closed
teddychao opened this issue Jul 7, 2023 · 0 comments · Fixed by #501
Closed

pspm_interp1 needs to consider data without valid values #500

teddychao opened this issue Jul 7, 2023 · 0 comments · Fixed by #501
Assignees
Milestone

Comments

@teddychao
Copy link
Contributor

Feature Description

pspm_interp1, standing for first order interpolation, performs interpolation for PsPM data based on the valid non-NaNs, which is based on the assumption that PsPM data always contain at least 1 valid non-NaN. However, this is not guaranteed in our test datasets. It is possible that no valid values are detected and users will need some messages about what data should be skipped as interpolation isn't possible. To do this, it is necessary to add data checking in pspm_intep1.

@teddychao teddychao added the Improvement A minor improvement to the project label Jul 7, 2023
@teddychao teddychao self-assigned this Jul 7, 2023
@teddychao teddychao added this to the v6.1 milestone Jul 7, 2023
@teddychao teddychao linked a pull request Jul 7, 2023 that will close this issue
@teddychao teddychao added Solved and removed Improvement A minor improvement to the project labels Aug 20, 2023
@teddychao teddychao removed the Solved label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant