Skip to content

Conversation

@azure-sdk
Copy link
Owner

@azure-sdk azure-sdk commented Mar 11, 2024

Create to sync Azure/azure-rest-api-specs#28192

Please install the package by npm install https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/28192/azure-sdk-for-js/@azure_arm-appcontainers/azure-arm-appcontainers-3.0.0-beta.1.tgz

hectorhdzg and others added 9 commits March 8, 2024 10:02
…ents (Azure#28823)

### Packages impacted by this PR
@azure/monitor-opentelemetry
### Packages impacted by this PR

@azure/identity

### Issues associated with this PR

Nightly test failures

### Describe the problem that is addressed by this PR

Our nightly tests started failing with a `TypeError: Descriptor for
property generatePluginConfiguration is non-configurable and non-writable` error.

I'm far from an expert here, but I believe the error is due to ESModules
being immutable, whereas CJS Modules are mutable.

Wrapping the stubbable / mockable object is a reasonable workaround to
keep tests green regardless of whether they get run as ESM or CJS

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?

Deleting the tests is an option, or an integration test. Neither seem to
fit the bill here. Once we have credentials migrated over we may be able to
delete some of the unit tests and rely on recorded tests to test the various
scenarios. But we are not there yet.
… Package (Azure#28827)

### Packages impacted by this PR
@azure/monitor-opentelemetry

### Describe the problem that is addressed by this PR
Package should be updated to the latest version and tests updated
appropriately.

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x] Added a changelog (if necessary)
### Packages impacted by this PR

@azure/core-client

### Issues associated with this PR

N/A, follow up on Azure#28631 

### Describe the problem that is addressed by this PR

If you are exporting both CommonJS and ESM forms of a package, then it
is possible for both versions to be loaded at
run-time. However, the CommonJS build is a different module from the ESM
build, and thus a different thing from the
point of view of the JavaScript interpreter in Node.js.

https://github.com/isaacs/tshy/blob/main/README.md#dual-package-hazards

tshy handles this by building programs into separate folders and treats
"dual module hazards" as a fact of life.

One of the hazards of dual-modules is shared module-global state.

In core-clientwe have a module-global operationRequestMap that is used
for deserializing. In order to ensure it works in this dual-package world we 
must use one of multiple-recommended workarounds.

In this case, the tshy documentation provides a solution to this with a
well-documented path forward. This is what is implemented here.

Please refer to
https://github.com/isaacs/tshy/blob/main/README.md#module-local-state
for added context

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?

The obvious alternative is to just not do anything since tests have not
been failing; however, that
seems risky. While _this_ particular issue has not come up in tests, a
similar one came up for core-tracing.

I am open to just _not_ doing anything of course - I love not adding
code so just give me a reason!
…8840)

### Packages impacted by this PR
@azure/monitor-opentelemetry-exporter
### Packages impacted by this PR

- @azure/dev-tool

### Issues associated with this PR


### Describe the problem that is addressed by this PR

Reverts back to the original for the testing ts-node for JS and TS.

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_

- Azure#28801

### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
@github-actions github-actions bot added the Mgmt label Mar 11, 2024
v-jiaodi and others added 12 commits March 11, 2024 10:10
Update emitter packages.
### Packages impacted by this PR

- @azure/keyvault-keys
- @azure/keyvault-admin
- @azure/keyvault-secrets

### Describe the problem that is addressed by this PR

Fixes the glob path issue with the upgrade to `rimraf` since there were
extra calls to `rimraf` after the standard calls.
The `azsdkjsrush` storage account has seemingly been deleted, so this
will always fail and waste effort during CI.

Tracking issue for a full fix: Azure#28865
…n SDK (Azure#28847)

### Describe the problem that is addressed by this PR

Added the CreatCallFailed and AnswerFailed event.

This changed is tested against the Contoso app.
### Packages impacted by this PR

- `@azure/opentelemetry-instrumentation-azure-sdk`

### Issues associated with this PR


### Describe the problem that is addressed by this PR

Updates to latest OTEL

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR

- @azure-tests/perf-monitor-opentelemetry

### Issues associated with this PR


### Describe the problem that is addressed by this PR

Updates to latest OTEL packages

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
- convert pipelines to 1es-templates from all entrypoints. specifically archetype-sdk-tests, archetype-sdk-client, and cosmos-sdk-client.
- Move all image selection (outside of release deployments) to honor env variables instead of manually writing the pool (similar patterns for all other platforms)

Co-authored-by: Ben Broderick Phillips <[email protected]>
This is an automatic PR generated weekly with changes from running the
command rush update --full
@azure-sdk azure-sdk force-pushed the sdkAuto/28192/@azure_arm-appcontainers branch from 2dcb871 to c2513c3 Compare March 12, 2024 02:25
@azure-sdk azure-sdk force-pushed the sdkAuto/28192/@azure_arm-appcontainers branch 5 times, most recently from 80056c0 to 8966b55 Compare March 12, 2024 07:41
v-durgeshs and others added 3 commits March 13, 2024 15:30
### Issues associated with this PR
[User Story
3604450](https://skype.visualstudio.com/SPOOL/_workitems/edit/3604450):
[Alpha3][NodeJS][Transcription][SDK] Add Transcription packets parser.

[User Story
3595649](https://skype.visualstudio.com/SPOOL/_workitems/edit/3595649):
[Alpha3][NodeJS][Transcription][SDK] Add Duration for TranscriptionData
and Words

### Describe the problem that is addressed by this PR

Adding the parser for the stream data
### Packages impacted by this PR

- `@azure/core-lro`

### Describe the problem that is addressed by this PR

In the ESM migration it appears we accidentally removed the `files`
section from package.json for this package, so the built and packed
package includes everything including the source code. This PR restores
the field in line with the other ESMified Core packages.
@azure-sdk azure-sdk force-pushed the sdkAuto/28192/@azure_arm-appcontainers branch from 7fee133 to 91b8532 Compare March 14, 2024 05:45
@azure-sdk azure-sdk force-pushed the main branch 2 times, most recently from f9892bb to 34da487 Compare March 14, 2024 06:30
hectorhdzg and others added 14 commits March 14, 2024 09:32
### Packages impacted by this PR
@azure/monitor-opentelemetry

Fixed issue with quickpulse document duration
Fixed issue with miscalculation in dependency duration metric
Updated default quickpulse endpoint
Post release automated changes for azure-core-lro
### Packages impacted by this PR
`@azure-tools/test-recorder`

### Issues associated with this PR
Azure#28667 

### Describe the problem that is addressed by this PR
Releasing recorder 3.1.0 unblocks the Azure#28667 that upgrades recorder to
4.0.0 with vitest.
### Packages impacted by this PR
@azure/communication-phone-numbers

### Issues associated with this PR


### Describe the problem that is addressed by this PR
Update the Number Lookup public preview to include the Number Format
features we've been preparing for GA.

Azure/azure-rest-api-specs#27799

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
This design has been reviewed by the stewardship board

### Are there test cases added in this PR? _(If not, why?)_
yes

### Provide a list of related PRs _(if any)_
Azure/azure-rest-api-specs#27799
Azure/azure-sdk-for-java#38885
.NET _pending_
Python _pending_

### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
n/a

### Checklists
- [x] Added impacted package name to the issue description
- [x] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x] Added a changelog (if necessary)
### Packages impacted by this PR
`@azure/dev-tool`

### Issues associated with this PR
Fixing lint errors in `dev-tool` to unblock
Azure#28916 and [js -
eslint-plugin -
ci](https://dev.azure.com/azure-sdk/public/_build/results?buildId=3595289&view=logs&j=58292cae-3c74-5729-4cfd-9ceee65fe129&t=5e44d412-b571-5a43-3bb4-5c5145c0a5aa)
### Packages impacted by this PR
@azure/openai

### Issues associated with this PR
Azure#28889
…kpulse (Azure#28931)

### Packages impacted by this PR
@azure/monitor-opentelemetry
…28913)

### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)


### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
@azure-sdk azure-sdk force-pushed the sdkAuto/28192/@azure_arm-appcontainers branch from 91b8532 to 6545e83 Compare March 15, 2024 07:36
JacksonWeber and others added 4 commits March 15, 2024 11:38
### Packages impacted by this PR
@azure/monitor-opentelemetry

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x] Added a changelog (if necessary)
Merge 305cfdc175412d167c4952c6bc26644ae00f4c1c into 18fdfcc2f53363ca3298293d116227b31d4f1f33
@azure-sdk azure-sdk force-pushed the sdkAuto/28192/@azure_arm-appcontainers branch from 6545e83 to 93122d4 Compare March 18, 2024 05:27
@azure-sdk azure-sdk closed this Mar 24, 2024
@azure-sdk azure-sdk deleted the sdkAuto/28192/@azure_arm-appcontainers branch March 24, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.