[core-lro] Restore files section to package.json#28909
Merged
timovv merged 1 commit intoAzure:mainfrom Mar 13, 2024
Merged
Conversation
maorleger
approved these changes
Mar 13, 2024
Member
maorleger
left a comment
maorleger
left a comment
There was a problem hiding this comment.
I wonder if there's an automated check that would have caught this, maybe:
- Lint rule that
filesneeds to be present - Automated package size check
Something else?
Member
Author
|
Yeah, I think this is something that would have been picked up by the |
Collaborator
|
API change check API changes are not detected in this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/core-lroDescribe the problem that is addressed by this PR
In the ESM migration it appears we accidentally removed the
filessection from package.json for this package, so the built and packed package includes everything including the source code. This PR restores the field in line with the other ESMified Core packages.