[EngSys] Move from ts-node to tsx for tests#28801
Merged
mpodwysocki merged 4 commits intomainfrom Mar 6, 2024
Merged
Conversation
mpodwysocki
requested review from
HarshaNalluru,
ckairen,
deyaaeldeen,
jeremymeng,
mikeharder and
minhanh-phan
as code owners
github-actions
bot
added
the
App Configuration
Collaborator
|
API change check API changes are not detected in this pull request. |
maorleger
reviewed
Mar 6, 2024
Member
maorleger
left a comment
maorleger
left a comment
There was a problem hiding this comment.
Thanks for this! Will definitely use this on identity as well. I left a few comments but holding off on approving so we can get more eyes (since auto-merge is enabled) from the team 🚀
This was referenced Mar 7, 2024
maorleger
added a commit
that referenced
this pull request
Mar 8, 2024
### Packages impacted by this PR @azure/identity ### Describe the problem that is addressed by this PR Follows #28801 to use tsx for running identity tests, which avoids requiring the mocha workarounds ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? Using esm4mocha, but I think this is a good path forward to try
3 tasks
mpodwysocki
added a commit
that referenced
this pull request
Mar 9, 2024
### Packages impacted by this PR - @azure/dev-tool ### Issues associated with this PR ### Describe the problem that is addressed by this PR Reverts back to the original for the testing ts-node for JS and TS. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ - #28801 ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
maorleger
added a commit
that referenced
this pull request
Mar 12, 2024
Builds off of Matt's work on moving to tsx in #28801 by removing the `use-esm-workaround` flag from packages that needed it before we moved to tsx. There's additional cleanup to be had, but I am trying not to cause a build storm. We are at a point where we can delete `esm` globally! Contributes to #28617 which can be completed with a no-ci change to remove `esm` globally ****NO_CI****
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Removes dependency on
ts-nodeandesmand moves in favor of usingtsxWhat are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists