[instrumentation] Uprade to the latest OTEL#28811
Merged
mpodwysocki merged 9 commits intomainfrom Mar 11, 2024
Merged
Conversation
mpodwysocki
requested review from
ckairen,
deyaaeldeen,
jeremymeng and
maorleger
as code owners
Collaborator
|
API change check API changes are not detected in this pull request. |
mpodwysocki
requested review from
a team,
JacksonWeber,
hectorhdzg,
lmolkova and
srnagar
as code owners
mpodwysocki
requested review from
KarishmaGhiya,
gracewilcox,
joshfree,
nisha-bhatia,
pvaneck,
sarangan12 and
scottaddie
maorleger
reviewed
Mar 7, 2024
| // Function syntax | ||
| instrumenter.withContext(context.active(), function (this: any) { | ||
| assert.notExists(this); | ||
| assert.isDefined(this); |
Member
There was a problem hiding this comment.
This seems weird to me, but I don't want to block the PR. Feel free to pend the test and assign an issue to me to review it more closely. It's been like 2 years 😄
Member
There was a problem hiding this comment.
yeah feels like it should be undefined as it's not being explicitly bound to anything?
hectorhdzg
approved these changes
Mar 7, 2024
Member
hectorhdzg
left a comment
hectorhdzg
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking care of this
xirzec
approved these changes
Mar 7, 2024
| // Function syntax | ||
| instrumenter.withContext(context.active(), function (this: any) { | ||
| assert.notExists(this); | ||
| assert.isDefined(this); |
Member
There was a problem hiding this comment.
yeah feels like it should be undefined as it's not being explicitly bound to anything?
JacksonWeber
approved these changes
Mar 7, 2024
Member
|
/check-enforcer reset |
Member
|
/check-enforcer evaluate |
Member
|
@microsoft-github-policy-service rerun |
Member
|
/check-enforcer reset |
Member
|
/check-enforcer evaluate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/opentelemetry-instrumentation-azure-sdkIssues associated with this PR
Describe the problem that is addressed by this PR
Updates to latest OTEL
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists