Skip env processing on matrix import step #7854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbp
added
the
Central-EngSys
Collaborator
|
The following pipelines have been queued for testing: |
This was referenced Mar 11, 2024
weshaggard
approved these changes
Mar 11, 2024
azure-sdk
approved these changes
Mar 11, 2024
azure-sdk
approved these changes
Mar 11, 2024
benbp
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Mar 11, 2024
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7854 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Ben Broderick Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matrix filters are intended to work against the environment variable key, not the resolved value. There is a bug where resolve environment variables on an imported matrix, before processing any matrix filters passed in from the top level. This PR changes import behavior to skip env var lookup until after the imported matrix has been combined with the parent matrix.