Skip to content

Add password hashing#51

Merged
alexmt merged 16 commits intoargoproj:masterfrom
merenbach:add-password-hashing
Mar 27, 2018
Merged

Add password hashing#51
alexmt merged 16 commits intoargoproj:masterfrom
merenbach:add-password-hashing

Conversation

@merenbach
Copy link
Contributor

@merenbach merenbach commented Mar 23, 2018

To help us continue #29, allow specification of an admin username and password, as well as a namespace to store the secret, and hash passwords. These are now stored in running memory in a ArgoCDSettings.LocalUsers, which gives us flexibility to add more users later.

In the process, add a password hasher very loosely inspired by the state of Django's password hashing several years ago, with a prioritized list of preferred hashing algorithms (only one, Bcrypt, is currently implemented, based on an implementation from Argo.

@alexmt this queries for the secret name when running argocd install. I realize that with ./argocd install --config-map <config map name> --config-superuser, we will have the secret name in the config map specified, but if we don't have the config map name, we won't—is it worth seeing if we can skip the namespace input when the config map is specified, but including it when a config map is omitted?

@alexmt One other thing: it seems that argocd-server might start up with the default namespace if a namespace is not specified. Should it default to argocd, or is that namespace for the command-line tools?

@merenbach merenbach requested a review from alexmt March 23, 2018 22:51
@merenbach merenbach added the help-wanted Extra attention is needed label Mar 23, 2018
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secret name is specified in config map, so user might specify config map and provide different secret name here. Please use default secret name here or secret name from provided config map instead of asking user to retype it.

configMap, err := kubeclientset.CoreV1().ConfigMaps(i.Namespace).Get(i.InstallOptions.ConfigMap, metav1.GetOptions{})
errors.CheckError(err)

secretNameOverride, ok := configMap.Data[util.RootCredentialsSecretNameKey]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for asking to make changes again :) . Even if configMap is not supplied then configMap with default name might exist and it might have non-default admin secret name. If user requested to create secret with password installer needs to read either default config map or config map with the provided name. If map does not exist, then default secret name might be used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexmt to resolve this, I could see either just relying on the default secret name (ignoring the possibility of a default config map), or I could see us adding a default config map feature. I'm concerned that if we take the second route, it might actually go more smoothly if that's a follow up feature after some careful planning, because we have design decisions to make then (do we insist on there always being a default config map? when do we create it? for what is it consulted?). Interested in your thoughts!

@alexmt
Copy link
Collaborator

alexmt commented Mar 27, 2018

LGTM

@alexmt alexmt merged commit d093c8c into argoproj:master Mar 27, 2018
@merenbach merenbach removed the help-wanted Extra attention is needed label Mar 29, 2018
@merenbach merenbach deleted the add-password-hashing branch May 7, 2018 16:58
alexec pushed a commit that referenced this pull request Apr 24, 2019
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Sep 12, 2024
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Oct 28, 2024
gdsoumya pushed a commit to gdsoumya/argo-cd that referenced this pull request Nov 8, 2024
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Dec 6, 2024
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Dec 16, 2024
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Dec 20, 2024
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Jan 17, 2025
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Feb 28, 2025
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Mar 27, 2025
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Apr 3, 2025
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request May 22, 2025
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Jul 1, 2025
gdsoumya pushed a commit to gdsoumya/argo-cd that referenced this pull request Jul 7, 2025
gdsoumya pushed a commit to gdsoumya/argo-cd that referenced this pull request Jul 10, 2025
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Jul 11, 2025
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Jul 22, 2025
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Nov 20, 2025
alexmt added a commit to alexmt/argo-cd that referenced this pull request Nov 20, 2025
* chore: disable dependabot

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: user server side filtering & pagination to load Argo CD applications list

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: fix cluster filtering and refresh button on application list page

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: api server fails with "nil pointer dereference" error (argoproj#40)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): ui should show the same page number as in API (argoproj#38)

* feat: repository/Service.ListRefs returns raw list of refs (argoproj#42)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat(multi-cluster k8s dashboard): Make necessary changes for multi-cluster k8s dashboard feature in AKP (argoproj#48)

* feat: send data to agent

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* (wip)feat: send data to syncer APIs

* add support for columns info

* fix: resource deletion missing events

* feat: use resource sync and health info

* chore: disable dependabot

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: user server side filtering & pagination to load Argo CD applications list

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: fix cluster filtering and refresh button on application list page

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: api server fails with "nil pointer dereference" error (argoproj#40)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): ui should show the same page number as in API (argoproj#38)

* feat: repository/Service.ListRefs returns raw list of refs (argoproj#42)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): Reoreding filters (argoproj#44)

* fix(ui): Reoreding filters

* fix

* fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: enable dashboard feature by using env var

* fix: 1.21.0 -> 1.21

* chore: disable dependabot

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: user server side filtering & pagination to load Argo CD applications list

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: fix cluster filtering and refresh button on application list page

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: api server fails with "nil pointer dereference" error (argoproj#40)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): ui should show the same page number as in API (argoproj#38)

* feat: repository/Service.ListRefs returns raw list of refs (argoproj#42)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): Reoreding filters (argoproj#44)

* fix(ui): Reoreding filters

* fix

* fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

---------

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Co-authored-by: Rafal <rafpelczar@gmail.com>

* fix: using http client with timeout (argoproj#51)

* feat: send api resource count and object count from argocd application controller (argoproj#52)

* feat: add destination metadata for argocd UI repo calls (argoproj#53)

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* fix: argocd only send cluster info once (argoproj#54)

* send all health statuses (argoproj#55)

* feat: added commit abilities to reposerver (argoproj#56)

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* chore: use FedRAMP compliant binaries (argoproj#57)

Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>

* feat: implement resource filtering in app source and app filtering in appset (argoproj#58)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: helm binary path in image (argoproj#59)

* fix: application set should not attempt to talk to managed cluster (argoproj#60)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): Application stats flickers (argoproj#61)

* feat: add cluster scoped for kubevision resource info (argoproj#62)

* add namespaced

* use cluster scoped

* use v5

* fix: api server uses invalid matching while checking app namespace (argoproj#63)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: Undefined in Argo CD apps search box and app-in-any-namespace enabled (argoproj#64)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: support reading notifications settings from a different k8s (argoproj#66)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: add akuity-release-cli (argoproj#67)

* feat: add akuity-release-cli

Signed-off-by: Justin Marquis <justin@akuity.io>

* go mod tidy

Signed-off-by: Justin Marquis <justin@akuity.io>

---------

Signed-off-by: Justin Marquis <justin@akuity.io>

* fix: akuity-release-cli (argoproj#68)

Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>

* add skipOnFailure flag to appset filters (argoproj#69)

* fix(appset): improve git generator repo credential fallback (argoproj#21167)

* fix: read settings from host namespace instead of control plane namespace (argoproj#70)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: add support for deleting files/dir in repo server (argoproj#71)

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* feat: store original URL in global variable (argoproj#72)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: argocd app controller should not be affected when syncer is down (argoproj#73)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: handle delegated appset generate cli calls (argoproj#74)

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* refactor: local generate condition (argoproj#75)

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* feat: ensure appset generate call also filters the apps (argoproj#76)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: appset generator cannot access app metadata (argoproj#77)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: circular dependency error

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix sync status missing (argoproj#78)

* feat: favorite application filter (argoproj#79)

* feat: favorite filter

* feat: test

* fix: ap.pb.go

* fix: application-list

* fix: remove duplicate

* fix: proto

* fix: pagination for fav

* remove: debug logs

Signed-off-by: bhavyabhut <pbhavy4@gmail.com>

---------

Signed-off-by: bhavyabhut <pbhavy4@gmail.com>

* feat: add replace handler to power dashboard (argoproj#82)

Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com>

* handle only when repo-server delegated

* fix typo

* cache redis clients

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

---------

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>
Signed-off-by: Justin Marquis <justin@akuity.io>
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Signed-off-by: bhavyabhut <pbhavy4@gmail.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com>
Co-authored-by: Rafal <rafpelczar@gmail.com>
Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com>
Co-authored-by: Xiaopeng Han <hanxiaop8@outlook.com>
Co-authored-by: Anubhav Gupta <mail.anubhav06@gmail.com>
Co-authored-by: Rafal <rafal@akuity.io>
Co-authored-by: Yiwei Gong <imwithye@gmail.com>
Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Bhavya Bhut <pbhavy4@gmail.com>
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Jan 13, 2026
alexmt added a commit to alexmt/argo-cd that referenced this pull request Jan 13, 2026
* chore: disable dependabot

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: user server side filtering & pagination to load Argo CD applications list

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: fix cluster filtering and refresh button on application list page

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: api server fails with "nil pointer dereference" error (argoproj#40)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): ui should show the same page number as in API (argoproj#38)

* feat: repository/Service.ListRefs returns raw list of refs (argoproj#42)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat(multi-cluster k8s dashboard): Make necessary changes for multi-cluster k8s dashboard feature in AKP (argoproj#48)

* feat: send data to agent

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* (wip)feat: send data to syncer APIs

* add support for columns info

* fix: resource deletion missing events

* feat: use resource sync and health info

* chore: disable dependabot

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: user server side filtering & pagination to load Argo CD applications list

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: fix cluster filtering and refresh button on application list page

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: api server fails with "nil pointer dereference" error (argoproj#40)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): ui should show the same page number as in API (argoproj#38)

* feat: repository/Service.ListRefs returns raw list of refs (argoproj#42)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): Reoreding filters (argoproj#44)

* fix(ui): Reoreding filters

* fix

* fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: enable dashboard feature by using env var

* fix: 1.21.0 -> 1.21

* chore: disable dependabot

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: user server side filtering & pagination to load Argo CD applications list

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: fix cluster filtering and refresh button on application list page

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: api server fails with "nil pointer dereference" error (argoproj#40)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): ui should show the same page number as in API (argoproj#38)

* feat: repository/Service.ListRefs returns raw list of refs (argoproj#42)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): Reoreding filters (argoproj#44)

* fix(ui): Reoreding filters

* fix

* fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

---------

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Co-authored-by: Rafal <rafpelczar@gmail.com>

* fix: using http client with timeout (argoproj#51)

* feat: send api resource count and object count from argocd application controller (argoproj#52)

* feat: add destination metadata for argocd UI repo calls (argoproj#53)

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* fix: argocd only send cluster info once (argoproj#54)

* send all health statuses (argoproj#55)

* feat: added commit abilities to reposerver (argoproj#56)

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* chore: use FedRAMP compliant binaries (argoproj#57)

Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>

* feat: implement resource filtering in app source and app filtering in appset (argoproj#58)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: helm binary path in image (argoproj#59)

* fix: application set should not attempt to talk to managed cluster (argoproj#60)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): Application stats flickers (argoproj#61)

* feat: add cluster scoped for kubevision resource info (argoproj#62)

* add namespaced

* use cluster scoped

* use v5

* fix: api server uses invalid matching while checking app namespace (argoproj#63)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: Undefined in Argo CD apps search box and app-in-any-namespace enabled (argoproj#64)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: support reading notifications settings from a different k8s (argoproj#66)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: add akuity-release-cli (argoproj#67)

* feat: add akuity-release-cli

Signed-off-by: Justin Marquis <justin@akuity.io>

* go mod tidy

Signed-off-by: Justin Marquis <justin@akuity.io>

---------

Signed-off-by: Justin Marquis <justin@akuity.io>

* fix: akuity-release-cli (argoproj#68)

Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>

* add skipOnFailure flag to appset filters (argoproj#69)

* fix(appset): improve git generator repo credential fallback (argoproj#21167)

* fix: read settings from host namespace instead of control plane namespace (argoproj#70)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: add support for deleting files/dir in repo server (argoproj#71)

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* feat: store original URL in global variable (argoproj#72)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: argocd app controller should not be affected when syncer is down (argoproj#73)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: handle delegated appset generate cli calls (argoproj#74)

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* refactor: local generate condition (argoproj#75)

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* feat: ensure appset generate call also filters the apps (argoproj#76)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: appset generator cannot access app metadata (argoproj#77)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: circular dependency error

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix sync status missing (argoproj#78)

* feat: favorite application filter (argoproj#79)

* feat: favorite filter

* feat: test

* fix: ap.pb.go

* fix: application-list

* fix: remove duplicate

* fix: proto

* fix: pagination for fav

* remove: debug logs

Signed-off-by: bhavyabhut <pbhavy4@gmail.com>

---------

Signed-off-by: bhavyabhut <pbhavy4@gmail.com>

* feat: add replace handler to power dashboard (argoproj#82)

Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com>

* handle only when repo-server delegated

* fix typo

* cache redis clients

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

---------

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>
Signed-off-by: Justin Marquis <justin@akuity.io>
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Signed-off-by: bhavyabhut <pbhavy4@gmail.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com>
Co-authored-by: Rafal <rafpelczar@gmail.com>
Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com>
Co-authored-by: Xiaopeng Han <hanxiaop8@outlook.com>
Co-authored-by: Anubhav Gupta <mail.anubhav06@gmail.com>
Co-authored-by: Rafal <rafal@akuity.io>
Co-authored-by: Yiwei Gong <imwithye@gmail.com>
Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Bhavya Bhut <pbhavy4@gmail.com>
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Mar 21, 2026
alexmt added a commit to alexmt/argo-cd that referenced this pull request Mar 21, 2026
* chore: disable dependabot

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: user server side filtering & pagination to load Argo CD applications list

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: fix cluster filtering and refresh button on application list page

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: api server fails with "nil pointer dereference" error (argoproj#40)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): ui should show the same page number as in API (argoproj#38)

* feat: repository/Service.ListRefs returns raw list of refs (argoproj#42)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat(multi-cluster k8s dashboard): Make necessary changes for multi-cluster k8s dashboard feature in AKP (argoproj#48)

* feat: send data to agent

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* (wip)feat: send data to syncer APIs

* add support for columns info

* fix: resource deletion missing events

* feat: use resource sync and health info

* chore: disable dependabot

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: user server side filtering & pagination to load Argo CD applications list

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: fix cluster filtering and refresh button on application list page

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: api server fails with "nil pointer dereference" error (argoproj#40)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): ui should show the same page number as in API (argoproj#38)

* feat: repository/Service.ListRefs returns raw list of refs (argoproj#42)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): Reoreding filters (argoproj#44)

* fix(ui): Reoreding filters

* fix

* fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: enable dashboard feature by using env var

* fix: 1.21.0 -> 1.21

* chore: disable dependabot

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: user server side filtering & pagination to load Argo CD applications list

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: fix cluster filtering and refresh button on application list page

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: api server fails with "nil pointer dereference" error (argoproj#40)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): ui should show the same page number as in API (argoproj#38)

* feat: repository/Service.ListRefs returns raw list of refs (argoproj#42)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): Reoreding filters (argoproj#44)

* fix(ui): Reoreding filters

* fix

* fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

---------

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Co-authored-by: Rafal <rafpelczar@gmail.com>

* fix: using http client with timeout (argoproj#51)

* feat: send api resource count and object count from argocd application controller (argoproj#52)

* feat: add destination metadata for argocd UI repo calls (argoproj#53)

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* fix: argocd only send cluster info once (argoproj#54)

* send all health statuses (argoproj#55)

* feat: added commit abilities to reposerver (argoproj#56)

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* chore: use FedRAMP compliant binaries (argoproj#57)

Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>

* feat: implement resource filtering in app source and app filtering in appset (argoproj#58)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: helm binary path in image (argoproj#59)

* fix: application set should not attempt to talk to managed cluster (argoproj#60)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix(ui): Application stats flickers (argoproj#61)

* feat: add cluster scoped for kubevision resource info (argoproj#62)

* add namespaced

* use cluster scoped

* use v5

* fix: api server uses invalid matching while checking app namespace (argoproj#63)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: Undefined in Argo CD apps search box and app-in-any-namespace enabled (argoproj#64)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: support reading notifications settings from a different k8s (argoproj#66)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: add akuity-release-cli (argoproj#67)

* feat: add akuity-release-cli

Signed-off-by: Justin Marquis <justin@akuity.io>

* go mod tidy

Signed-off-by: Justin Marquis <justin@akuity.io>

---------

Signed-off-by: Justin Marquis <justin@akuity.io>

* fix: akuity-release-cli (argoproj#68)

Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>

* add skipOnFailure flag to appset filters (argoproj#69)

* fix(appset): improve git generator repo credential fallback (argoproj#21167)

* fix: read settings from host namespace instead of control plane namespace (argoproj#70)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: add support for deleting files/dir in repo server (argoproj#71)

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* feat: store original URL in global variable (argoproj#72)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: argocd app controller should not be affected when syncer is down (argoproj#73)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: handle delegated appset generate cli calls (argoproj#74)

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* refactor: local generate condition (argoproj#75)

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* feat: ensure appset generate call also filters the apps (argoproj#76)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: appset generator cannot access app metadata (argoproj#77)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix: circular dependency error

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix sync status missing (argoproj#78)

* feat: favorite application filter (argoproj#79)

* feat: favorite filter

* feat: test

* fix: ap.pb.go

* fix: application-list

* fix: remove duplicate

* fix: proto

* fix: pagination for fav

* remove: debug logs

Signed-off-by: bhavyabhut <pbhavy4@gmail.com>

---------

Signed-off-by: bhavyabhut <pbhavy4@gmail.com>

* feat: add replace handler to power dashboard (argoproj#82)

Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com>

* handle only when repo-server delegated

* fix typo

* cache redis clients

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

---------

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>
Signed-off-by: Justin Marquis <justin@akuity.io>
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Signed-off-by: bhavyabhut <pbhavy4@gmail.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com>
Co-authored-by: Rafal <rafpelczar@gmail.com>
Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com>
Co-authored-by: Xiaopeng Han <hanxiaop8@outlook.com>
Co-authored-by: Anubhav Gupta <mail.anubhav06@gmail.com>
Co-authored-by: Rafal <rafal@akuity.io>
Co-authored-by: Yiwei Gong <imwithye@gmail.com>
Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Bhavya Bhut <pbhavy4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants