Add JWT support by merenbach · Pull Request #60 · argoproj/argo-cd

merenbach · 2018-03-29T18:50:02Z

We're honing in on the end of #29. As an intermediate step toward supporting authentication endpoints, this PR adds support for JWT generation.

Changes

Add support for creating JWT tokens.
Add support for cryptographically-secure pseudorandom server-side signature generation. In short: make a new random string every time argocd install --create-signature is run, or (if --create-signature is not specified) when the server signature isn't set yet. This string is used to sign JWT tokens. A side effect is that every time argocd install --create-signature is run, all existing user sessions will be invalidated.
Automatically request superuser username and password if none are set upon running argocd install.
Don't allow admin username and password to be the same.
Mitigate timing attacks against dummy hasher to set a good example.

Notes for reviewer

I changed up the ConfigManager a bit in terms of how it responds to errors in GetSettings(), so that if a setting is missing it won't bail until the end of the function. This lets us return defaults for multiple settings and is in support of automatically requesting superuser credentials and automatically generating a signature. Please let me know if you think I may have missed any important ramifications of this change.

alexmt

LGTM

Signed-off-by: Mihir Shah <mrshah@us.ibm.com>

…rgoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat(multi-cluster k8s dashboard): Make necessary changes for multi-cluster k8s dashboard feature in AKP (argoproj#48) * feat: send data to agent Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * (wip)feat: send data to syncer APIs * add support for columns info * fix: resource deletion missing events * feat: use resource sync and health info * chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Reoreding filters (argoproj#44) * fix(ui): Reoreding filters * fix * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: enable dashboard feature by using env var * fix: 1.21.0 -> 1.21 * chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Reoreding filters (argoproj#44) * fix(ui): Reoreding filters * fix * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Rafal <rafpelczar@gmail.com> * fix: using http client with timeout (argoproj#51) * feat: send api resource count and object count from argocd application controller (argoproj#52) * feat: add destination metadata for argocd UI repo calls (argoproj#53) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * fix: argocd only send cluster info once (argoproj#54) * send all health statuses (argoproj#55) * feat: added commit abilities to reposerver (argoproj#56) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * chore: use FedRAMP compliant binaries (argoproj#57) Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com> * feat: implement resource filtering in app source and app filtering in appset (argoproj#58) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: helm binary path in image (argoproj#59) * fix: application set should not attempt to talk to managed cluster (argoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Application stats flickers (argoproj#61) * feat: add cluster scoped for kubevision resource info (argoproj#62) * add namespaced * use cluster scoped * use v5 * fix: api server uses invalid matching while checking app namespace (argoproj#63) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: Undefined in Argo CD apps search box and app-in-any-namespace enabled (argoproj#64) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: support reading notifications settings from a different k8s (argoproj#66) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: add akuity-release-cli (argoproj#67) * feat: add akuity-release-cli Signed-off-by: Justin Marquis <justin@akuity.io> * go mod tidy Signed-off-by: Justin Marquis <justin@akuity.io> --------- Signed-off-by: Justin Marquis <justin@akuity.io> * fix: akuity-release-cli (argoproj#68) Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * add skipOnFailure flag to appset filters (argoproj#69) * fix(appset): improve git generator repo credential fallback (argoproj#21167) * fix: read settings from host namespace instead of control plane namespace (argoproj#70) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: add support for deleting files/dir in repo server (argoproj#71) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: store original URL in global variable (argoproj#72) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: argocd app controller should not be affected when syncer is down (argoproj#73) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: handle delegated appset generate cli calls (argoproj#74) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * refactor: local generate condition (argoproj#75) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: ensure appset generate call also filters the apps (argoproj#76) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: appset generator cannot access app metadata (argoproj#77) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: circular dependency error Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix sync status missing (argoproj#78) * feat: favorite application filter (argoproj#79) * feat: favorite filter * feat: test * fix: ap.pb.go * fix: application-list * fix: remove duplicate * fix: proto * fix: pagination for fav * remove: debug logs Signed-off-by: bhavyabhut <pbhavy4@gmail.com> --------- Signed-off-by: bhavyabhut <pbhavy4@gmail.com> * feat: add replace handler to power dashboard (argoproj#82) Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com> * handle only when repo-server delegated * fix typo * cache redis clients Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com> Signed-off-by: Justin Marquis <justin@akuity.io> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: bhavyabhut <pbhavy4@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com> Co-authored-by: Rafal <rafpelczar@gmail.com> Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com> Co-authored-by: Xiaopeng Han <hanxiaop8@outlook.com> Co-authored-by: Anubhav Gupta <mail.anubhav06@gmail.com> Co-authored-by: Rafal <rafal@akuity.io> Co-authored-by: Yiwei Gong <imwithye@gmail.com> Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Bhavya Bhut <pbhavy4@gmail.com>

…rgoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat(multi-cluster k8s dashboard): Make necessary changes for multi-cluster k8s dashboard feature in AKP (argoproj#48) * feat: send data to agent Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * (wip)feat: send data to syncer APIs * add support for columns info * fix: resource deletion missing events * feat: use resource sync and health info * chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Reoreding filters (argoproj#44) * fix(ui): Reoreding filters * fix * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: enable dashboard feature by using env var * fix: 1.21.0 -> 1.21 * chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Reoreding filters (argoproj#44) * fix(ui): Reoreding filters * fix * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Rafal <rafpelczar@gmail.com> * fix: using http client with timeout (argoproj#51) * feat: send api resource count and object count from argocd application controller (argoproj#52) * feat: add destination metadata for argocd UI repo calls (argoproj#53) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * fix: argocd only send cluster info once (argoproj#54) * send all health statuses (argoproj#55) * feat: added commit abilities to reposerver (argoproj#56) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * chore: use FedRAMP compliant binaries (argoproj#57) Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com> * feat: implement resource filtering in app source and app filtering in appset (argoproj#58) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: helm binary path in image (argoproj#59) * fix: application set should not attempt to talk to managed cluster (argoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Application stats flickers (argoproj#61) * feat: add cluster scoped for kubevision resource info (argoproj#62) * add namespaced * use cluster scoped * use v5 * fix: api server uses invalid matching while checking app namespace (argoproj#63) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: Undefined in Argo CD apps search box and app-in-any-namespace enabled (argoproj#64) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: support reading notifications settings from a different k8s (argoproj#66) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: add akuity-release-cli (argoproj#67) * feat: add akuity-release-cli Signed-off-by: Justin Marquis <justin@akuity.io> * go mod tidy Signed-off-by: Justin Marquis <justin@akuity.io> --------- Signed-off-by: Justin Marquis <justin@akuity.io> * fix: akuity-release-cli (argoproj#68) Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * add skipOnFailure flag to appset filters (argoproj#69) * fix(appset): improve git generator repo credential fallback (argoproj#21167) * fix: read settings from host namespace instead of control plane namespace (argoproj#70) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: add support for deleting files/dir in repo server (argoproj#71) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: store original URL in global variable (argoproj#72) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: argocd app controller should not be affected when syncer is down (argoproj#73) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: handle delegated appset generate cli calls (argoproj#74) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * refactor: local generate condition (argoproj#75) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: ensure appset generate call also filters the apps (argoproj#76) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: appset generator cannot access app metadata (argoproj#77) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: circular dependency error Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix sync status missing (argoproj#78) * feat: favorite application filter (argoproj#79) * feat: favorite filter * feat: test * fix: ap.pb.go * fix: application-list * fix: remove duplicate * fix: proto * fix: pagination for fav * remove: debug logs Signed-off-by: bhavyabhut <pbhavy4@gmail.com> --------- Signed-off-by: bhavyabhut <pbhavy4@gmail.com> * feat: add replace handler to power dashboard (argoproj#82) Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com> * handle only when repo-server delegated * fix typo * cache redis clients Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com> Signed-off-by: Justin Marquis <justin@akuity.io> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: bhavyabhut <pbhavy4@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com> Co-authored-by: Rafal <rafpelczar@gmail.com> Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com> Co-authored-by: Xiaopeng Han <hanxiaop8@outlook.com> Co-authored-by: Anubhav Gupta <mail.anubhav06@gmail.com> Co-authored-by: Rafal <rafal@akuity.io> Co-authored-by: Yiwei Gong <imwithye@gmail.com> Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Bhavya Bhut <pbhavy4@gmail.com>

…rgoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat(multi-cluster k8s dashboard): Make necessary changes for multi-cluster k8s dashboard feature in AKP (argoproj#48) * feat: send data to agent Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * (wip)feat: send data to syncer APIs * add support for columns info * fix: resource deletion missing events * feat: use resource sync and health info * chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Reoreding filters (argoproj#44) * fix(ui): Reoreding filters * fix * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: enable dashboard feature by using env var * fix: 1.21.0 -> 1.21 * chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Reoreding filters (argoproj#44) * fix(ui): Reoreding filters * fix * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Rafal <rafpelczar@gmail.com> * fix: using http client with timeout (argoproj#51) * feat: send api resource count and object count from argocd application controller (argoproj#52) * feat: add destination metadata for argocd UI repo calls (argoproj#53) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * fix: argocd only send cluster info once (argoproj#54) * send all health statuses (argoproj#55) * feat: added commit abilities to reposerver (argoproj#56) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * chore: use FedRAMP compliant binaries (argoproj#57) Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com> * feat: implement resource filtering in app source and app filtering in appset (argoproj#58) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: helm binary path in image (argoproj#59) * fix: application set should not attempt to talk to managed cluster (argoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Application stats flickers (argoproj#61) * feat: add cluster scoped for kubevision resource info (argoproj#62) * add namespaced * use cluster scoped * use v5 * fix: api server uses invalid matching while checking app namespace (argoproj#63) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: Undefined in Argo CD apps search box and app-in-any-namespace enabled (argoproj#64) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: support reading notifications settings from a different k8s (argoproj#66) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: add akuity-release-cli (argoproj#67) * feat: add akuity-release-cli Signed-off-by: Justin Marquis <justin@akuity.io> * go mod tidy Signed-off-by: Justin Marquis <justin@akuity.io> --------- Signed-off-by: Justin Marquis <justin@akuity.io> * fix: akuity-release-cli (argoproj#68) Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * add skipOnFailure flag to appset filters (argoproj#69) * fix(appset): improve git generator repo credential fallback (argoproj#21167) * fix: read settings from host namespace instead of control plane namespace (argoproj#70) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: add support for deleting files/dir in repo server (argoproj#71) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: store original URL in global variable (argoproj#72) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: argocd app controller should not be affected when syncer is down (argoproj#73) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: handle delegated appset generate cli calls (argoproj#74) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * refactor: local generate condition (argoproj#75) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: ensure appset generate call also filters the apps (argoproj#76) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: appset generator cannot access app metadata (argoproj#77) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: circular dependency error Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix sync status missing (argoproj#78) * feat: favorite application filter (argoproj#79) * feat: favorite filter * feat: test * fix: ap.pb.go * fix: application-list * fix: remove duplicate * fix: proto * fix: pagination for fav * remove: debug logs Signed-off-by: bhavyabhut <pbhavy4@gmail.com> --------- Signed-off-by: bhavyabhut <pbhavy4@gmail.com> * feat: add replace handler to power dashboard (argoproj#82) Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com> * handle only when repo-server delegated * fix typo * cache redis clients Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com> Signed-off-by: Justin Marquis <justin@akuity.io> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: bhavyabhut <pbhavy4@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com> Co-authored-by: Rafal <rafpelczar@gmail.com> Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com> Co-authored-by: Xiaopeng Han <hanxiaop8@outlook.com> Co-authored-by: Anubhav Gupta <mail.anubhav06@gmail.com> Co-authored-by: Rafal <rafal@akuity.io> Co-authored-by: Yiwei Gong <imwithye@gmail.com> Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Bhavya Bhut <pbhavy4@gmail.com>

Andrew Merenbach added 12 commits March 29, 2018 11:24

Clone cluster => session

78938e4

Add sessionmanager and tests to util

dfc02f8

Return token claims type

2cabe2e

Flesh out basic login prototyping

91bb07c

Update dummy hasher to demonstrate mitigation of timing attacks

1efa57d

Return error on blank password entry

26102d1

Flesh out key retrieval logic some more

7240d75

Add server signature key generation

3354ef2

Don't mess about converting between strings and byte arrays

23c9e3a

Fix Gopkg.toml constraints

adbc5a4

Only update signature if it is not set yet

32ba28d

Don't convert server signature to string in memory

f538c4c

merenbach requested a review from alexmt March 29, 2018 18:50

merenbach added the enhancement New feature or request label Mar 29, 2018

alexmt approved these changes Mar 29, 2018

View reviewed changes

merenbach merged commit 6bc98f9 into argoproj:master Mar 29, 2018

merenbach deleted the add-jwt-support branch May 7, 2018 16:57

alexec pushed a commit that referenced this pull request Apr 24, 2019

Issue #681 - Display init container logs (#60)

9356994

sujeilyfonseca pushed a commit to sujeilyfonseca/argo-cd that referenced this pull request Jul 7, 2022

fix: Build tools by self to get by golang version issue (argoproj#60)

9d55c6b

Signed-off-by: Mihir Shah <mrshah@us.ibm.com>

sujeilyfonseca pushed a commit to sujeilyfonseca/argo-cd that referenced this pull request Sep 8, 2022

fix: Build tools by self to get by golang version issue (argoproj#60)

2643429

Signed-off-by: Mihir Shah <mrshah@us.ibm.com>

alexmt added a commit to alexmt/argo-cd that referenced this pull request Dec 20, 2024

fix: application set should not attempt to talk to managed cluster (a…

3938ec8

…rgoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

alexmt added a commit to alexmt/argo-cd that referenced this pull request Jan 17, 2025

fix: application set should not attempt to talk to managed cluster (a…

8ee3997

…rgoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

alexmt added a commit to alexmt/argo-cd that referenced this pull request Feb 28, 2025

fix: application set should not attempt to talk to managed cluster (a…

4586c6f

…rgoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

alexmt added a commit to alexmt/argo-cd that referenced this pull request Mar 27, 2025

fix: application set should not attempt to talk to managed cluster (a…

6a10c42

…rgoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

alexmt added a commit to alexmt/argo-cd that referenced this pull request Apr 3, 2025

fix: application set should not attempt to talk to managed cluster (a…

fa8abeb

…rgoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

alexmt added a commit to alexmt/argo-cd that referenced this pull request May 22, 2025

fix: application set should not attempt to talk to managed cluster (a…

855dbcf

…rgoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

alexmt added a commit to alexmt/argo-cd that referenced this pull request Jul 1, 2025

fix: application set should not attempt to talk to managed cluster (a…

ed45d20

…rgoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

gdsoumya pushed a commit to gdsoumya/argo-cd that referenced this pull request Jul 7, 2025

fix: application set should not attempt to talk to managed cluster (a…

7a171fc

…rgoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

gdsoumya pushed a commit to gdsoumya/argo-cd that referenced this pull request Jul 10, 2025

fix: application set should not attempt to talk to managed cluster (a…

53f2486

…rgoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

alexmt added a commit to alexmt/argo-cd that referenced this pull request Jul 11, 2025

fix: application set should not attempt to talk to managed cluster (a…

39d9d1a

…rgoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

alexmt added a commit to alexmt/argo-cd that referenced this pull request Jul 22, 2025

fix: application set should not attempt to talk to managed cluster (a…

5c2e9b3

…rgoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

alexmt added a commit to alexmt/argo-cd that referenced this pull request Nov 20, 2025

fix: application set should not attempt to talk to managed cluster (a…

3c9dc4d

…rgoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

alexmt added a commit to alexmt/argo-cd that referenced this pull request Jan 13, 2026

fix: application set should not attempt to talk to managed cluster (a…

8f69831

…rgoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

alexmt added a commit to alexmt/argo-cd that referenced this pull request Mar 21, 2026

fix: application set should not attempt to talk to managed cluster (a…

007d0d7

…rgoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add JWT support#60

Add JWT support#60
merenbach merged 12 commits intoargoproj:masterfrom
merenbach:add-jwt-support

merenbach commented Mar 29, 2018

Uh oh!

alexmt left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

merenbach commented Mar 29, 2018

Changes

Notes for reviewer

Uh oh!

alexmt left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants