[SPARK-37941][SQL] Use error classes in the compilation errors of casting#35292
Closed
ivoson wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-37941][SQL] Use error classes in the compilation errors of casting#35292ivoson wants to merge 3 commits intoapache:masterfrom
ivoson wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
Author
|
cc @MaxGekk Since there are some existing test cases in EncoderResolutionSuite, I am wondering whether we would like to move all compilation error cases to one test Suite. If we do that, the test file could be pretty big. |
HyukjinKwon
changed the title
|
Can one of the admins verify this patch? |
Member
We should add a test per every error class.
Need to try to reduce the number of error classes. For example, #35272 |
Contributor
Author
|
Thanks @MaxGekk . Will add the test case. |
Contributor
Author
|
Closing and open another PR #35366 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Migrate the following errors in QueryCompilationErrors onto use error classes:
upCastFailureError
unsupportedAbstractDataTypeForUpCastError
cannotUpCastAsAttributeError
Why are the changes needed?
Porting casting errors to new error framework.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT.