Skip to content

[SPARK-37941][SQL] Use error classes in the compilation errors of casting #35292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ivoson wants to merge 3 commits into from
Closed

[SPARK-37941][SQL] Use error classes in the compilation errors of casting #35292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5793aed
migrate upcast compilation error to new error fraemwork
ivoson Jan 23, 2022
c9dd0b4
update error message
ivoson Jan 23, 2022
b3b2336
fix ut
ivoson Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions core/src/main/resources/error/error-classes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,15 @@
"message" : [ "The target JDBC server does not support transaction and can only support ALTER TABLE with a single action." ],
"sqlState" : "0A000"
},
"UP_CAST_AS_ATTRIBUTE_UNSUPPORTED" : {
"message" : [ "Cannot up cast %s from %s to %s as it may truncate" ]
},
"UP_CAST_FAILURE" : {
"message" : [ "Cannot up cast %s from %s to %s.\nThe type path of the target object is:\n%sYou can either add an explicit cast to the input data or choose a higher precision type of the field in the target object" ]
},
"UP_CAST_UNSUPPORTED_ABSTRACT_DATA_TYPE" : {
"message" : [ "UpCast only support DecimalType as AbstractDataType yet, but got: %s" ]
},
"WRITING_JOB_ABORTED" : {
"message" : [ "Writing job aborted" ],
"sqlState" : "40000"
Expand Down
27 changes: 18 additions & 9 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,16 +158,21 @@ object QueryCompilationErrors {
def upCastFailureError(
fromStr: String, from: Expression, to: DataType, walkedTypePath: Seq[String]): Throwable = {
new AnalysisException(
s"Cannot up cast $fromStr from " +
s"${from.dataType.catalogString} to ${to.catalogString}.\n" +
s"The type path of the target object is:\n" + walkedTypePath.mkString("", "\n", "\n") +
"You can either add an explicit cast to the input data or choose a higher precision " +
"type of the field in the target object")
errorClass = "UP_CAST_FAILURE",
messageParameters = Array(
fromStr,
from.dataType.catalogString,
to.catalogString,
walkedTypePath.mkString("", "\n", "\n")
)
)
}

def unsupportedAbstractDataTypeForUpCastError(gotType: AbstractDataType): Throwable = {
new AnalysisException(
s"UpCast only support DecimalType as AbstractDataType yet, but got: $gotType")
errorClass = "UP_CAST_UNSUPPORTED_ABSTRACT_DATA_TYPE",
messageParameters = Array(gotType.toString)
)
}

def outerScopeFailureForNewInstanceError(className: String): Throwable = {
Expand Down Expand Up @@ -417,9 +422,13 @@ object QueryCompilationErrors {

def cannotUpCastAsAttributeError(
fromAttr: Attribute, toAttr: Attribute): Throwable = {
new AnalysisException(s"Cannot up cast ${fromAttr.sql} from " +
s"${fromAttr.dataType.catalogString} to ${toAttr.dataType.catalogString} " +
"as it may truncate")
new AnalysisException(
errorClass = "UP_CAST_AS_ATTRIBUTE_UNSUPPORTED",
messageParameters = Array(
fromAttr.sql,
fromAttr.dataType.catalogString,
toAttr.dataType.catalogString)
)
}

def functionUndefinedError(name: FunctionIdentifier): Throwable = {
Expand Down