Skip to content

[SPARK-37941][SQL] Use error classes in the compilation errors of casting#35366

Closed
ivoson wants to merge 1 commit intoapache:masterfrom
ivoson:SPARK-37941-new
Closed

[SPARK-37941][SQL] Use error classes in the compilation errors of casting#35366
ivoson wants to merge 1 commit intoapache:masterfrom
ivoson:SPARK-37941-new

Conversation

@ivoson
Copy link
Contributor

@ivoson ivoson commented Jan 30, 2022

What changes were proposed in this pull request?

Migrate the following errors in QueryCompilationErrors onto use error classes:

  1. upCastFailureError => CANNOT_UP_CAST_DATATYPE
  2. unsupportedAbstractDataTypeForUpCastError => UNSUPPORTED_FEATURE
  3. cannotUpCastAsAttributeError => removed as no longer used.

Why are the changes needed?

Porting casting errors to new error framework.

Does this PR introduce any user-facing change?

No

How was this patch tested?

New UT added.

@ivoson
Copy link
Contributor Author

ivoson commented Jan 31, 2022

cc @MaxGekk @cloud-fan

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@MaxGekk
Copy link
Member

MaxGekk commented Feb 3, 2022

+1, LGTM. Merging to master.
Thank you, @ivoson.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants