-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEODE-10369] if scratch ssd is used, fall back to n1 machine type. #7800
Open
smgoller
wants to merge
50
commits into
apache:develop
Choose a base branch
from
smgoller:GEODE-10369
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhoughton-pivot
approved these changes
Jun 13, 2022
dickcav
approved these changes
Jun 13, 2022
onichols-pivotal
approved these changes
Jun 13, 2022
…en though we get less (240)
n1-standard gets 3.75GiB/vcpu n1-highmem gets 0.9GiB/vcp
…ecause the pipeline was just flown (cherry picked from commit 3daf0c0f79e68a59c1ba4930d507d778e1ca7286) (cherry picked from commit 1fadba215ed664798305c2ec2f36e1bc1576aed3)
onichols-pivotal
requested changes
Jun 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
due to code freeze, please hold off merging this
just one review can approve codeowners is gone
- For RegionEntryFactory.getEntryClass
* Added what is returned by methods showJVMMetrics and showOSMetrics * Informtation include individual beans and what data type it is.
…#116) * processCpuTime no longer depends on deep reflection * added VMStats50Test to verify fix * removed add-opens for VMStats50 from product. It was still needed by the Jetty9CachingClientServerTest because of Jetty.
* Change all references to geode-examples to gemfire-examples.
…re Present (apache#93) * delay sync after member departure in peer-only configuration * delay time defaults to 60 seconds for all configurations * change via DistributionAdvisor.syncDelayForCrashedMemberMillis
* GEM-2712: InternalGemfireError while shutting down * Address review comment on bug reference
Use the `mockito-inline` to configure Mockito to use a mock-maker that works on JDK 17.
…che#132)" (apache#139) This reverts commit ae6e75e.
Changed several tests to make them stop spying concrete JDK classes. In Java 17, the packages of these classes are not open for reflection, causing Mockito to create spies that are incomplete and unusable.` Changed `ClientRegistrationEventQueueManagerTest` to subclass and override `java.util.concurrent.locks.ReentrantReadWriteLock` and`java.util.concurrent.locks.ReentrantReadWriteLock.ReadLock`. Changed `OverflowOplogFlushTest` to wrap the `java.nio.channels.FileChannel` instances in decorator classes that intercept and modify the channels' behavior. Changed `StartMemberUtilsTest` to use `mock(java.io.File.class)` instead of spying an existing instance. Even with these changes, `geode-test.gradle` must open these packages to tests, because `Jetty9CachingClientServerTest` still needs them to be opened. That will be fixed on a separate PR.
* GemfireHttpSession now implements Sizable which causes the eviction code to ask it for its size which it then computes. Its sizing implementation does not size objects it references that are shared with other sessions. * Added a test that confirms that eviction will detect changes to the size as attributes are added to the session.
* Convert all references to apache/geode-benchmarks to gemfire/gemfire-benchmarks * Add github and gcp credentials in order to access protected items. * pass commercial repo credentials via ssh
* fixes CVE-2022-32532 * also bumps slf4j from 1.7.32 to 1.7.36 * also fixes a stray issue with the tomcat7 removal
Rewrite `ObjectTraverser` to use `Unsafe` to access the objects in the object graph, bypassing Java's access checks.
PROBLEM LonerDistributionManager.getEquivalents(InetAddress) was removed by GEODE-7808 (HostAndPort changes). This introduced a regression in which the User API DistributedSystem.findDistributedMembers(InetAddress) was broken when invoked on loner members. SOLUTION Restore the removed LonerDistributionManager.getEquivalents() method exactly as it existed before and create tests to confirm its behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop
)?Is your initial contribution a single, squashed commit?
Does
gradlew build
run cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?