Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEODE-10369] if scratch ssd is used, fall back to n1 machine type. #7800

Open
wants to merge 50 commits into
base: develop
Choose a base branch
from

Conversation

smgoller
Copy link
Contributor

@smgoller smgoller commented Jun 13, 2022

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Copy link
Contributor

@onichols-pivotal onichols-pivotal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to code freeze, please hold off merging this

nabarunnag and others added 27 commits June 25, 2022 00:16
…#116)

* processCpuTime no longer depends on deep reflection
* added VMStats50Test to verify fix
* removed add-opens for VMStats50 from product. It was still needed by the Jetty9CachingClientServerTest because of Jetty.
* Change all references to geode-examples to gemfire-examples.
…re Present (apache#93)

* delay sync after member departure in peer-only configuration
* delay time defaults to 60 seconds for all configurations
* change via DistributionAdvisor.syncDelayForCrashedMemberMillis
* GEM-2712: InternalGemfireError while shutting down

* Address review comment on bug reference
Use the `mockito-inline` to configure Mockito to use a mock-maker that
works on JDK 17.
Changed several tests to make them stop spying concrete JDK classes. In
Java 17, the packages of these classes are not open for reflection,
causing Mockito to create spies that are incomplete and unusable.`

Changed `ClientRegistrationEventQueueManagerTest` to subclass and
override `java.util.concurrent.locks.ReentrantReadWriteLock`
and`java.util.concurrent.locks.ReentrantReadWriteLock.ReadLock`.

Changed `OverflowOplogFlushTest` to wrap the
`java.nio.channels.FileChannel` instances in decorator classes that
intercept and modify the channels' behavior.

Changed `StartMemberUtilsTest` to use `mock(java.io.File.class)` instead
of spying an existing instance.

Even with these changes, `geode-test.gradle` must open these packages to
tests, because `Jetty9CachingClientServerTest` still needs them to be
opened. That will be fixed on a separate PR.
* GemfireHttpSession now implements Sizable which causes the eviction code to ask it for its size which it then computes. Its sizing implementation does not size objects it references that are shared with other sessions.
* Added a test that confirms that eviction will detect changes to the size as attributes are added to the session.
* Convert all references to apache/geode-benchmarks to
  gemfire/gemfire-benchmarks
* Add github and gcp credentials in order to access protected items.
* pass commercial repo credentials via ssh
* fixes CVE-2022-32532 
* also bumps slf4j from 1.7.32 to 1.7.36
* also fixes a stray issue with the tomcat7 removal
Rewrite `ObjectTraverser` to use `Unsafe` to access the objects in the
object graph, bypassing Java's access checks.
PROBLEM

LonerDistributionManager.getEquivalents(InetAddress) was removed by
GEODE-7808 (HostAndPort changes). This introduced a regression in which
the User API DistributedSystem.findDistributedMembers(InetAddress) was
broken when invoked on loner members.

SOLUTION

Restore the removed LonerDistributionManager.getEquivalents() method
exactly as it existed before and create tests to confirm its behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.